[v1] Some bugfix and cleanup to mballoc

[PATCH 20/21] ext4: remove comment code ext4_discard_preallocations

Posted by Kemeng Shi 2 years, 7 months ago

Just remove comment code in ext4_discard_preallocations.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
 fs/ext4/mballoc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index dec716f331ac..5bc30cd5debf 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -4925,7 +4925,6 @@ void ext4_discard_preallocations(struct inode *inode, unsigned int needed)
 	int err;
 
 	if (!S_ISREG(inode->i_mode)) {
-		/*BUG_ON(!list_empty(&ei->i_prealloc_list));*/
 		return;
 	}
 
-- 
2.30.0

Re: [PATCH 20/21] ext4: remove comment code ext4_discard_preallocations

Posted by Ojaswin Mujoo 2 years, 7 months ago

On Fri, Feb 10, 2023 at 03:48:24AM +0800, Kemeng Shi wrote:
> Just remove comment code in ext4_discard_preallocations.
> 
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
> ---
>  fs/ext4/mballoc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index dec716f331ac..5bc30cd5debf 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -4925,7 +4925,6 @@ void ext4_discard_preallocations(struct inode *inode, unsigned int needed)
>  	int err;
>  
>  	if (!S_ISREG(inode->i_mode)) {
> -		/*BUG_ON(!list_empty(&ei->i_prealloc_list));*/
>  		return;
>  	}
>  
> -- 
> 2.30.0
> 
Feel free to add:

Reviewed-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>