drivers/soc/mediatek/mtk-svs.c | 5 ----- 1 file changed, 5 deletions(-)
From: Matthias Brugger <matthias.bgg@gmail.com>
The function svs_add_device_link is called only internally from the SoC
specific probe functions. We don't need to check if the node_name is
null because that would mean that we have a buggy SoC probe function in
the first place.
Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
---
drivers/soc/mediatek/mtk-svs.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
index 299f580847bdc..a7eb019b5157d 100644
--- a/drivers/soc/mediatek/mtk-svs.c
+++ b/drivers/soc/mediatek/mtk-svs.c
@@ -2027,11 +2027,6 @@ static struct device *svs_add_device_link(struct svs_platform *svsp,
struct device *dev;
struct device_link *sup_link;
- if (!node_name) {
- dev_err(svsp->dev, "node name cannot be null\n");
- return ERR_PTR(-EINVAL);
- }
-
dev = svs_get_subsys_device(svsp, node_name);
if (IS_ERR(dev))
return dev;
--
2.39.0
Il 09/02/23 17:24, matthias.bgg@kernel.org ha scritto: > From: Matthias Brugger <matthias.bgg@gmail.com> > > The function svs_add_device_link is called only internally from the SoC > specific probe functions. We don't need to check if the node_name is > null because that would mean that we have a buggy SoC probe function in > the first place. > > Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On Fri, 2023-02-10 at 13:01 +0100, AngeloGioacchino Del Regno wrote: > Il 09/02/23 17:24, matthias.bgg@kernel.org ha scritto: > > From: Matthias Brugger <matthias.bgg@gmail.com> > > > > The function svs_add_device_link is called only internally from the SoC > > specific probe functions. We don't need to check if the node_name is > > null because that would mean that we have a buggy SoC probe function in > > the first place. > > > > Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com> > > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> Reviewed-by: Roger Lu <roger.lu@mediatek.com>
On 11/02/2023 12:37, Roger Lu (陸瑞傑) wrote: > On Fri, 2023-02-10 at 13:01 +0100, AngeloGioacchino Del Regno wrote: >> Il 09/02/23 17:24, matthias.bgg@kernel.org ha scritto: >>> From: Matthias Brugger <matthias.bgg@gmail.com> >>> >>> The function svs_add_device_link is called only internally from the SoC >>> specific probe functions. We don't need to check if the node_name is >>> null because that would mean that we have a buggy SoC probe function in >>> the first place. >>> >>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com> >> >> Reviewed-by: AngeloGioacchino Del Regno < >> angelogioacchino.delregno@collabora.com> > > Reviewed-by: Roger Lu <roger.lu@mediatek.com> Applied, thanks for the reviews. Matthias
© 2016 - 2024 Red Hat, Inc.