sched/topology: remove duplicate include header in topology.c

[PATCH] sched/topology: remove duplicate include header in topology.c

Posted by ye.xingchen@zte.com.cn 2 years, 7 months ago

From: Ye Xingchen <ye.xingchen@zte.com.cn>

linux/bsearch.h is included more than once.

Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
---
 kernel/sched/topology.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index ebc8cbeb55dc..eb339751fe90 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -1766,7 +1766,6 @@ bool find_numa_distance(int distance)
  *   there is an intermediary node C, which is < N hops away from both
  *   nodes A and B, the system is a glueless mesh.
  */
-#include <linux/bsearch.h>

 static void init_numa_topology_type(int offline_node)
 {
-- 
2.25.1

Re: [PATCH] sched/topology: remove duplicate include header in topology.c

Posted by Valentin Schneider 2 years, 6 months ago

On 09/02/23 15:12, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
>
> linux/bsearch.h is included more than once.
>
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
> ---
>  kernel/sched/topology.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> index ebc8cbeb55dc..eb339751fe90 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -1766,7 +1766,6 @@ bool find_numa_distance(int distance)
>   *   there is an intermediary node C, which is < N hops away from both
>   *   nodes A and B, the system is a glueless mesh.
>   */
> -#include <linux/bsearch.h>
>

This doesn't exist upstream, and I can't find any proof of it ever existing
in the git history, so I don't think you're working on an upstream tree.

>  static void init_numa_topology_type(int offline_node)
>  {
> --
> 2.25.1