[PATCH v4 4/4] ASoC: cs35l41: Document CS35l41 shared boost

Lucas Tanure posted 4 patches 2 years, 7 months ago
There is a newer version of this series
[PATCH v4 4/4] ASoC: cs35l41: Document CS35l41 shared boost
Posted by Lucas Tanure 2 years, 7 months ago
Describe the properties used for shared boost configuration.
Based on David Rhodes shared boost patches.

Signed-off-by: Lucas Tanure <lucas.tanure@collabora.com>
---
 .../devicetree/bindings/sound/cirrus,cs35l41.yaml      | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml
index 18fb471aa891..f3c0a66f3474 100644
--- a/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml
+++ b/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml
@@ -85,11 +85,19 @@ properties:
       boost-cap-microfarad.
       External Boost must have GPIO1 as GPIO output. GPIO1 will be set high to
       enable boost voltage.
+      Shared boost allows two amplifiers to share a single boost circuit by
+      communicating on the MDSYNC bus. The passive amplifier does not control
+      the boost and receives data from the active amplifier. GPIO1 should be
+      configured for Sync when shared boost is used. Shared boost is not
+      compatible with External boost. Active amplifier requires
+      boost-peak-milliamp, boost-ind-nanohenry and boost-cap-microfarad.
       0 = Internal Boost
       1 = External Boost
+      2 = Shared Boost Active
+      3 = Shared Boost Passive
     $ref: /schemas/types.yaml#/definitions/uint32
     minimum: 0
-    maximum: 1
+    maximum: 3
 
   cirrus,gpio1-polarity-invert:
     description:
-- 
2.39.1
Re: [PATCH v4 4/4] ASoC: cs35l41: Document CS35l41 shared boost
Posted by Krzysztof Kozlowski 2 years, 7 months ago
On 09/02/2023 09:37, Lucas Tanure wrote:
> Describe the properties used for shared boost configuration.
> Based on David Rhodes shared boost patches.

No improvements in subject, I asked twice for it. What does the command,
I gave you, print?

> 
With fixed subject:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Re: [PATCH v4 4/4] ASoC: cs35l41: Document CS35l41 shared boost
Posted by Lucas Tanure 2 years, 7 months ago
On 09-02-2023 08:53, Krzysztof Kozlowski wrote:
> On 09/02/2023 09:37, Lucas Tanure wrote:
>> Describe the properties used for shared boost configuration.
>> Based on David Rhodes shared boost patches.
> 
> No improvements in subject, I asked twice for it. What does the command,
> I gave you, print?
> 
Should be
ASoC: dt-bindings: cirrus,cs35l41: Document CS35l41 shared boost

ok?

>>
> With fixed subject:
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Best regards,
> Krzysztof
>
Re: [PATCH v4 4/4] ASoC: cs35l41: Document CS35l41 shared boost
Posted by Krzysztof Kozlowski 2 years, 7 months ago
On 09/02/2023 11:26, Lucas Tanure wrote:
> On 09-02-2023 08:53, Krzysztof Kozlowski wrote:
>> On 09/02/2023 09:37, Lucas Tanure wrote:
>>> Describe the properties used for shared boost configuration.
>>> Based on David Rhodes shared boost patches.
>>
>> No improvements in subject, I asked twice for it. What does the command,
>> I gave you, print?
>>
> Should be
> ASoC: dt-bindings: cirrus,cs35l41: Document CS35l41 shared boost
>

Yes, thanks.

Best regards,
Krzysztof