arm64: dts: qcom: sm8550: remove invalid interconnect property from cryptobam

[PATCH] arm64: dts: qcom: sm8550: remove invalid interconnect property from cryptobam

Posted by Neil Armstrong 2 years, 7 months ago

The interconnect property is already present in the qce node, which
is the consumer of the cryptobam, so no need for an interconnect property
as documented by the bindings.

Fixes: 433477c3bf0b ("arm64: dts: qcom: sm8550: add QCrypto nodes")
Suggested-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
[1] https://lore.kernel.org/all/20230207-topic-sm8550-upstream-bam-dma-bindings-fix-v1-1-57dba71e8727@linaro.org/
---
 arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index 6ff135191ee0..206056890100 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -1858,8 +1858,6 @@ cryptobam: dma-controller@1dc4000 {
 			qcom,controlled-remotely;
 			iommus = <&apps_smmu 0x480 0x0>,
 				 <&apps_smmu 0x481 0x0>;
-			interconnects = <&aggre2_noc MASTER_CRYPTO 0 &mc_virt SLAVE_EBI1 0>;
-			interconnect-names = "memory";
 		};
 
 		crypto: crypto@1de0000 {

---
base-commit: 49a8133221c71b935f36a7c340c0271c2a9ee2db
change-id: 20230209-topic-sm8550-upstream-cryptobam-remove-interconnect-4a1d59b263a5

Best regards,
-- 
Neil Armstrong <neil.armstrong@linaro.org>

Re: [PATCH] arm64: dts: qcom: sm8550: remove invalid interconnect property from cryptobam

Posted by Bjorn Andersson 2 years, 7 months ago

On Thu, 09 Feb 2023 09:44:43 +0100, Neil Armstrong wrote:
> The interconnect property is already present in the qce node, which
> is the consumer of the cryptobam, so no need for an interconnect property
> as documented by the bindings.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: sm8550: remove invalid interconnect property from cryptobam
      commit: 26e95ff8a912fd787a65ae1ae4cc4684f5f84fce

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH] arm64: dts: qcom: sm8550: remove invalid interconnect property from cryptobam

Posted by Krzysztof Kozlowski 2 years, 7 months ago

On 09/02/2023 09:44, Neil Armstrong wrote:
> The interconnect property is already present in the qce node, which
> is the consumer of the cryptobam, so no need for an interconnect property
> as documented by the bindings.
> 
> Fixes: 433477c3bf0b ("arm64: dts: qcom: sm8550: add QCrypto nodes")
> Suggested-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof