mfd: atmel-flexcom: use devm_platform_get_and_ioremap_resource()

[PATCH] mfd: atmel-flexcom: use devm_platform_get_and_ioremap_resource()

Posted by ye.xingchen@zte.com.cn 2 years, 7 months ago

From: Ye Xingchen <ye.xingchen@zte.com.cn>

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
---
 drivers/mfd/atmel-flexcom.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
index 33caa4fba6af..b52f7ffdad35 100644
--- a/drivers/mfd/atmel-flexcom.c
+++ b/drivers/mfd/atmel-flexcom.c
@@ -37,7 +37,6 @@ struct atmel_flexcom {
 static int atmel_flexcom_probe(struct platform_device *pdev)
 {
 	struct device_node *np = pdev->dev.of_node;
-	struct resource *res;
 	struct atmel_flexcom *ddata;
 	int err;

@@ -55,8 +54,7 @@ static int atmel_flexcom_probe(struct platform_device *pdev)
 	    ddata->opmode > ATMEL_FLEXCOM_MODE_TWI)
 		return -EINVAL;

-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	ddata->base = devm_ioremap_resource(&pdev->dev, res);
+	ddata->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
 	if (IS_ERR(ddata->base))
 		return PTR_ERR(ddata->base);

-- 
2.25.1

Re: [PATCH] mfd: atmel-flexcom: use devm_platform_get_and_ioremap_resource()

Posted by Lee Jones 2 years, 6 months ago

On Wed, 08 Feb 2023, ye.xingchen@zte.com.cn wrote:

> From: Ye Xingchen <ye.xingchen@zte.com.cn>
> 
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
> ---
>  drivers/mfd/atmel-flexcom.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Applied, thanks

-- 
Lee Jones [李琼斯]

Re: [PATCH] mfd: atmel-flexcom: use devm_platform_get_and_ioremap_resource()

Posted by Claudiu.Beznea@microchip.com 2 years, 7 months ago

On 08.02.2023 11:31, ye.xingchen@zte.com.cn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
> 
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>

Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Tested-by: Claudiu Beznea <claudiu.beznea@microchip.com>

> ---
>  drivers/mfd/atmel-flexcom.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
> index 33caa4fba6af..b52f7ffdad35 100644
> --- a/drivers/mfd/atmel-flexcom.c
> +++ b/drivers/mfd/atmel-flexcom.c
> @@ -37,7 +37,6 @@ struct atmel_flexcom {
>  static int atmel_flexcom_probe(struct platform_device *pdev)
>  {
>         struct device_node *np = pdev->dev.of_node;
> -       struct resource *res;
>         struct atmel_flexcom *ddata;
>         int err;
> 
> @@ -55,8 +54,7 @@ static int atmel_flexcom_probe(struct platform_device *pdev)
>             ddata->opmode > ATMEL_FLEXCOM_MODE_TWI)
>                 return -EINVAL;
> 
> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       ddata->base = devm_ioremap_resource(&pdev->dev, res);
> +       ddata->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
>         if (IS_ERR(ddata->base))
>                 return PTR_ERR(ddata->base);
> 
> --
> 2.25.1