ARM: dts: exynos: correct max98090 DAI argument in Snow

[PATCH] ARM: dts: exynos: correct max98090 DAI argument in Snow

Posted by Krzysztof Kozlowski 2 years, 7 months ago

The max98090 has only one DAI and does not take argument to DAI
phandles:

  exynos5250-snow-rev5.dtb: audio-codec@10: #sound-dai-cells:0:0: 0 was expected

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/exynos5250-snow-rev5.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250-snow-rev5.dts b/arch/arm/boot/dts/exynos5250-snow-rev5.dts
index 0a47597d6f0d..3d32c3476e84 100644
--- a/arch/arm/boot/dts/exynos5250-snow-rev5.dts
+++ b/arch/arm/boot/dts/exynos5250-snow-rev5.dts
@@ -27,7 +27,7 @@ cpu {
 		};
 
 		codec {
-			sound-dai = <&max98090 0>, <&hdmi>;
+			sound-dai = <&max98090>, <&hdmi>;
 		};
 	};
 };
@@ -42,7 +42,7 @@ max98090: audio-codec@10 {
 		pinctrl-0 = <&max98090_irq>;
 		clocks = <&pmu_system_controller 0>;
 		clock-names = "mclk";
-		#sound-dai-cells = <1>;
+		#sound-dai-cells = <0>;
 	};
 };
 
-- 
2.34.1

Re: [PATCH] ARM: dts: exynos: correct max98090 DAI argument in Snow

Posted by Krzysztof Kozlowski 2 years, 7 months ago

On Wed, 8 Feb 2023 17:04:24 +0100, Krzysztof Kozlowski wrote:
> The max98090 has only one DAI and does not take argument to DAI
> phandles:
> 
>   exynos5250-snow-rev5.dtb: audio-codec@10: #sound-dai-cells:0:0: 0 was expected
> 
> 

Applied, thanks!

[1/1] ARM: dts: exynos: correct max98090 DAI argument in Snow
      https://git.kernel.org/krzk/linux/c/301d3dd05525e3a046f6cfa6ee4dea6a3b7111ee

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Re: [PATCH] ARM: dts: exynos: correct max98090 DAI argument in Snow

Posted by Marek Szyprowski 2 years, 7 months ago

On 08.02.2023 17:04, Krzysztof Kozlowski wrote:
> The max98090 has only one DAI and does not take argument to DAI
> phandles:
>
>    exynos5250-snow-rev5.dtb: audio-codec@10: #sound-dai-cells:0:0: 0 was expected
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>   arch/arm/boot/dts/exynos5250-snow-rev5.dts | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250-snow-rev5.dts b/arch/arm/boot/dts/exynos5250-snow-rev5.dts
> index 0a47597d6f0d..3d32c3476e84 100644
> --- a/arch/arm/boot/dts/exynos5250-snow-rev5.dts
> +++ b/arch/arm/boot/dts/exynos5250-snow-rev5.dts
> @@ -27,7 +27,7 @@ cpu {
>   		};
>   
>   		codec {
> -			sound-dai = <&max98090 0>, <&hdmi>;
> +			sound-dai = <&max98090>, <&hdmi>;
>   		};
>   	};
>   };
> @@ -42,7 +42,7 @@ max98090: audio-codec@10 {
>   		pinctrl-0 = <&max98090_irq>;
>   		clocks = <&pmu_system_controller 0>;
>   		clock-names = "mclk";
> -		#sound-dai-cells = <1>;
> +		#sound-dai-cells = <0>;
>   	};
>   };
>   

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland