dt-bindings: mt76: add active-low property for led

[PATCH v2] dt-bindings: mt76: add active-low property for led

Posted by Frank Wunderlich 1 year, 7 months ago

From: Frank Wunderlich <frank-w@public-files.de>

LEDs can be in low-active mode, driver already supports it, but
documentation is missing. Add documentation for the dt property.

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
v2:
- change commit message to mention that driver already support this
---
 .../devicetree/bindings/net/wireless/mediatek,mt76.yaml      | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
index f0c78f994491..212508672979 100644
--- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
@@ -112,6 +112,11 @@ properties:
     $ref: /schemas/leds/common.yaml#
     additionalProperties: false
     properties:
+      led-active-low:
+        description:
+          LED is enabled with ground signal.
+        type: boolean
+
       led-sources:
         maxItems: 1
 
-- 
2.34.1

Re: [PATCH v2] dt-bindings: mt76: add active-low property for led

Posted by Krzysztof Kozlowski 1 year, 7 months ago

On 07/02/2023 14:35, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> LEDs can be in low-active mode, driver already supports it, but
> documentation is missing. Add documentation for the dt property.
> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>\


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH v2] dt-bindings: mt76: add active-low property for led

Posted by Matthias Brugger 1 year, 5 months ago

Hi Felix and Kalle,

On 07/02/2023 14:36, Krzysztof Kozlowski wrote:
> On 07/02/2023 14:35, Frank Wunderlich wrote:
>> From: Frank Wunderlich <frank-w@public-files.de>
>>
>> LEDs can be in low-active mode, driver already supports it, but
>> documentation is missing. Add documentation for the dt property.
>>
>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>\
> 
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 

Can you take that through your tree or are fine if I take it through mine?

Regards,
Matthias

Re: [PATCH v2] dt-bindings: mt76: add active-low property for led

Posted by Kalle Valo 1 year, 5 months ago

Matthias Brugger <matthias.bgg@gmail.com> writes:

> On 07/02/2023 14:36, Krzysztof Kozlowski wrote:
>> On 07/02/2023 14:35, Frank Wunderlich wrote:
>>> From: Frank Wunderlich <frank-w@public-files.de>
>>>
>>> LEDs can be in low-active mode, driver already supports it, but
>>> documentation is missing. Add documentation for the dt property.
>>>
>>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>\
>>
>>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>
> Can you take that through your tree or are fine if I take it through mine?

It would be safest if Felix can take this to his tree, less conflicts
the better.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches