[PATCH v3 0/2] dt: bindings: net: ath11k: add dt entry for XO calibration support

Youghandhar Chintala posted 2 patches 2 years, 7 months ago
.../bindings/net/wireless/qcom,ath11k.yaml    |  4 ++++
drivers/net/wireless/ath/ath11k/ahb.c         |  8 +++++++
drivers/net/wireless/ath/ath11k/core.h        |  3 +++
drivers/net/wireless/ath/ath11k/qmi.c         | 24 +++++++++++++++++++
drivers/net/wireless/ath/ath11k/qmi.h         |  4 +++-
5 files changed, 42 insertions(+), 1 deletion(-)
[PATCH v3 0/2] dt: bindings: net: ath11k: add dt entry for XO calibration support
Posted by Youghandhar Chintala 2 years, 7 months ago
Add dt binding to get XO calibration data support for Wi-Fi RF clock.

Retrieve the XO trim offset via system firmware (e.g., device tree),
especially in the case where the device doesn't have a useful EEPROM
on which to store the calibrated XO offset.
Calibrated XO offset is sent to firmware, which compensate the RF clock
drift by programing the XO trim register.

Changes from v2:
 - Added proper commit text

Changes from v1:
 - Sending the series to right list

Youghandhar Chintala (2):
  dt: bindings: net: ath11k: add dt entry for XO calibration support
  wifi: ath11k: PMIC XO cal data support

 .../bindings/net/wireless/qcom,ath11k.yaml    |  4 ++++
 drivers/net/wireless/ath/ath11k/ahb.c         |  8 +++++++
 drivers/net/wireless/ath/ath11k/core.h        |  3 +++
 drivers/net/wireless/ath/ath11k/qmi.c         | 24 +++++++++++++++++++
 drivers/net/wireless/ath/ath11k/qmi.h         |  4 +++-
 5 files changed, 42 insertions(+), 1 deletion(-)

-- 
2.38.0
Re: [PATCH v3 0/2] dt: bindings: net: ath11k: add dt entry for XO calibration support
Posted by Krzysztof Kozlowski 2 years, 7 months ago
On 07/02/2023 11:36, Youghandhar Chintala wrote:
> Add dt binding to get XO calibration data support for Wi-Fi RF clock.
> 
> Retrieve the XO trim offset via system firmware (e.g., device tree),
> especially in the case where the device doesn't have a useful EEPROM
> on which to store the calibrated XO offset.
> Calibrated XO offset is sent to firmware, which compensate the RF clock
> drift by programing the XO trim register.
> 
> Changes from v2:
>  - Added proper commit text
> 

I received v2 and v3 the same time - it's confusing. You did not fix all
the things I asked for, so maybe you sent exactly the same patch - v2?

In any case, sent v4 implementing entire feedback, not parts.

Best regards,
Krzysztof