[PATCH] ath10k: Remove redundant assignment to changed_flags

Jiapeng Chong posted 1 patch 2 years, 7 months ago
drivers/net/wireless/ath/ath10k/mac.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] ath10k: Remove redundant assignment to changed_flags
Posted by Jiapeng Chong 2 years, 7 months ago
Variable changed_flags is assigned, but is not effectively used, so
delete it.

drivers/net/wireless/ath/ath10k/mac.c:6024:22: warning: parameter 'changed_flags' set but not used.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3963
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/net/wireless/ath/ath10k/mac.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index ec8d5b29bc72..7675858f069b 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -6030,7 +6030,6 @@ static void ath10k_configure_filter(struct ieee80211_hw *hw,
 
 	mutex_lock(&ar->conf_mutex);
 
-	changed_flags &= SUPPORTED_FILTERS;
 	*total_flags &= SUPPORTED_FILTERS;
 	ar->filter_flags = *total_flags;
 
-- 
2.20.1.7.g153144c
Re: [PATCH] ath10k: Remove redundant assignment to changed_flags
Posted by Kalle Valo 2 years, 6 months ago
Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:

> Variable changed_flags is assigned, but is not effectively used, so
> delete it.
> 
> drivers/net/wireless/ath/ath10k/mac.c:6024:22: warning: parameter 'changed_flags' set but not used.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3963
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

7c4c511f74ba wifi: ath10k: Remove redundant assignment to changed_flags

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230207052410.26337-1-jiapeng.chong@linux.alibaba.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: [PATCH] ath10k: Remove redundant assignment to changed_flags
Posted by Simon Horman 2 years, 7 months ago
On Tue, Feb 07, 2023 at 01:24:10PM +0800, Jiapeng Chong wrote:
> Variable changed_flags is assigned, but is not effectively used, so
> delete it.
> 
> drivers/net/wireless/ath/ath10k/mac.c:6024:22: warning: parameter 'changed_flags' set but not used.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3963
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>