remoteproc: qcom_q6v5_pas: enable sm8550 adsp & cdsp autoboot

[PATCH] remoteproc: qcom_q6v5_pas: enable sm8550 adsp & cdsp autoboot

Posted by Neil Armstrong 2 years, 7 months ago

Set the SM8550 adsp & cdsp auto_boot to true to match the behavior
of the previous platforms.

Fixes: 7eddedc97563 ("remoteproc: qcom_q6v5_pas: add sm8550 adsp, cdsp & mpss compatible & data")
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 drivers/remoteproc/qcom_q6v5_pas.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
index 4e1d9b08def4..90c5612a3045 100644
--- a/drivers/remoteproc/qcom_q6v5_pas.c
+++ b/drivers/remoteproc/qcom_q6v5_pas.c
@@ -1108,7 +1108,7 @@ static const struct adsp_data sm8550_adsp_resource = {
 	.pas_id = 1,
 	.dtb_pas_id = 0x24,
 	.minidump_id = 5,
-	.auto_boot = false,
+	.auto_boot = true,
 	.proxy_pd_names = (char*[]){
 		"lcx",
 		"lmx",
@@ -1127,7 +1127,7 @@ static const struct adsp_data sm8550_cdsp_resource = {
 	.pas_id = 18,
 	.dtb_pas_id = 0x25,
 	.minidump_id = 7,
-	.auto_boot = false,
+	.auto_boot = true,
 	.proxy_pd_names = (char*[]){
 		"cx",
 		"mxc",

---
base-commit: ea4dabbb4ad7eb52632a2ca0b8f89f0ea7c55dcf
change-id: 20230206-topic-sm8550-upstream-fix-remoteproc-autoboot-5c7effcf197c

Best regards,
-- 
Neil Armstrong <neil.armstrong@linaro.org>

Re: [PATCH] remoteproc: qcom_q6v5_pas: enable sm8550 adsp & cdsp autoboot

Posted by Bjorn Andersson 2 years, 7 months ago

On Mon, 06 Feb 2023 14:53:31 +0100, Neil Armstrong wrote:
> Set the SM8550 adsp & cdsp auto_boot to true to match the behavior
> of the previous platforms.
> 
> 

Applied, thanks!

[1/1] remoteproc: qcom_q6v5_pas: enable sm8550 adsp & cdsp autoboot
      commit: a8086bd9723ac8f1f795ab64f1de7dd0b9be889a

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH] remoteproc: qcom_q6v5_pas: enable sm8550 adsp & cdsp autoboot

Posted by Konrad Dybcio 2 years, 7 months ago


On 6.02.2023 14:53, Neil Armstrong wrote:
> Set the SM8550 adsp & cdsp auto_boot to true to match the behavior
> of the previous platforms.
> 
> Fixes: 7eddedc97563 ("remoteproc: qcom_q6v5_pas: add sm8550 adsp, cdsp & mpss compatible & data")
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  drivers/remoteproc/qcom_q6v5_pas.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index 4e1d9b08def4..90c5612a3045 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -1108,7 +1108,7 @@ static const struct adsp_data sm8550_adsp_resource = {
>  	.pas_id = 1,
>  	.dtb_pas_id = 0x24,
>  	.minidump_id = 5,
> -	.auto_boot = false,
> +	.auto_boot = true,
>  	.proxy_pd_names = (char*[]){
>  		"lcx",
>  		"lmx",
> @@ -1127,7 +1127,7 @@ static const struct adsp_data sm8550_cdsp_resource = {
>  	.pas_id = 18,
>  	.dtb_pas_id = 0x25,
>  	.minidump_id = 7,
> -	.auto_boot = false,
> +	.auto_boot = true,
>  	.proxy_pd_names = (char*[]){
>  		"cx",
>  		"mxc",
> 
> ---
> base-commit: ea4dabbb4ad7eb52632a2ca0b8f89f0ea7c55dcf
> change-id: 20230206-topic-sm8550-upstream-fix-remoteproc-autoboot-5c7effcf197c
P.S not sure if you wanted to send that to lkml
> 
> Best regards,

Re: [PATCH] remoteproc: qcom_q6v5_pas: enable sm8550 adsp & cdsp autoboot

Posted by Neil Armstrong 2 years, 7 months ago

On 06/02/2023 14:54, Konrad Dybcio wrote:
> 
> 
> On 6.02.2023 14:53, Neil Armstrong wrote:
>> Set the SM8550 adsp & cdsp auto_boot to true to match the behavior
>> of the previous platforms.
>>
>> Fixes: 7eddedc97563 ("remoteproc: qcom_q6v5_pas: add sm8550 adsp, cdsp & mpss compatible & data")
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> 
> Konrad
>>   drivers/remoteproc/qcom_q6v5_pas.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
>> index 4e1d9b08def4..90c5612a3045 100644
>> --- a/drivers/remoteproc/qcom_q6v5_pas.c
>> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
>> @@ -1108,7 +1108,7 @@ static const struct adsp_data sm8550_adsp_resource = {
>>   	.pas_id = 1,
>>   	.dtb_pas_id = 0x24,
>>   	.minidump_id = 5,
>> -	.auto_boot = false,
>> +	.auto_boot = true,
>>   	.proxy_pd_names = (char*[]){
>>   		"lcx",
>>   		"lmx",
>> @@ -1127,7 +1127,7 @@ static const struct adsp_data sm8550_cdsp_resource = {
>>   	.pas_id = 18,
>>   	.dtb_pas_id = 0x25,
>>   	.minidump_id = 7,
>> -	.auto_boot = false,
>> +	.auto_boot = true,
>>   	.proxy_pd_names = (char*[]){
>>   		"cx",
>>   		"mxc",
>>
>> ---
>> base-commit: ea4dabbb4ad7eb52632a2ca0b8f89f0ea7c55dcf
>> change-id: 20230206-topic-sm8550-upstream-fix-remoteproc-autoboot-5c7effcf197c
> P.S not sure if you wanted to send that to lkml

It's part of what b4 sends, there's nothing secret

Neil

>>
>> Best regards,