usb: host: USB_XHCI_RZV2M depends on USB_GADGET

[PATCH] usb: host: USB_XHCI_RZV2M depends on USB_GADGET

Posted by Tom Rix 2 years, 7 months ago

A rand config causes this link error
ld: drivers/usb/host/xhci-rzv2m.o: in function `xhci_rzv2m_init_quirk':
xhci-rzv2m.c:(.text+0x13): undefined reference to `rzv2m_usb3drd_reset'

xhci_rzv2m_init_quirk build is controlled by USB_XHCI_RZV2M
rzv2m_usb3drd_reset build is controlled by USB_RZV2M_USB3DRD

USE_XHCI_RZV2M does select USB_RZV2M_USB3DRD, but USB_RZV2M_USB3DRD
depends on USB_GADGET, so now does USE_XHCI_RZV2M.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/usb/host/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 2b80ce9587c1..2dd9e95a5b86 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -100,6 +100,7 @@ config USB_XHCI_RZV2M
 	tristate "xHCI support for Renesas RZ/V2M SoC"
 	depends on USB_XHCI_PLATFORM
 	depends on ARCH_R9A09G011 || COMPILE_TEST
+	depends on USB_GADGET
 	select USB_RZV2M_USB3DRD
 	help
 	  Say 'Y' to enable the support for the xHCI host controller
-- 
2.27.0

RE: [PATCH] usb: host: USB_XHCI_RZV2M depends on USB_GADGET

Posted by Biju Das 2 years, 7 months ago

Hi Tom,

Thanks for the patch.

Arnd send a patch for refactoring the USB_XHCI_RZV2M KConfig dependencies related to USB_GADGET on [1] and
is in usb-next. Do you see this issue after applying[1]?

[1] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id=ec5499d338ece9db9b7590649d3cfcc4d7f9603d

Cheers,
Biju

> -----Original Message-----
> From: Tom Rix <trix@redhat.com>
> Sent: Sunday, February 5, 2023 2:12 AM
> To: gregkh@linuxfoundation.org; arnd@arndb.de; linus.walleij@linaro.org;
> artur.bujdoso@gmail.com; miquel.raynal@bootlin.com; colin.i.king@gmail.com;
> Biju Das <biju.das.jz@bp.renesas.com>; tmaimon77@gmail.com
> Cc: linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; Tom Rix
> <trix@redhat.com>
> Subject: [PATCH] usb: host: USB_XHCI_RZV2M depends on USB_GADGET
> 
> A rand config causes this link error
> ld: drivers/usb/host/xhci-rzv2m.o: in function `xhci_rzv2m_init_quirk':
> xhci-rzv2m.c:(.text+0x13): undefined reference to `rzv2m_usb3drd_reset'
> 
> xhci_rzv2m_init_quirk build is controlled by USB_XHCI_RZV2M
> rzv2m_usb3drd_reset build is controlled by USB_RZV2M_USB3DRD
> 
> USE_XHCI_RZV2M does select USB_RZV2M_USB3DRD, but USB_RZV2M_USB3DRD depends
> on USB_GADGET, so now does USE_XHCI_RZV2M.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/usb/host/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index
> 2b80ce9587c1..2dd9e95a5b86 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -100,6 +100,7 @@ config USB_XHCI_RZV2M
>  	tristate "xHCI support for Renesas RZ/V2M SoC"
>  	depends on USB_XHCI_PLATFORM
>  	depends on ARCH_R9A09G011 || COMPILE_TEST
> +	depends on USB_GADGET
>  	select USB_RZV2M_USB3DRD
>  	help
>  	  Say 'Y' to enable the support for the xHCI host controller
> --
> 2.27.0

Re: [PATCH] usb: host: USB_XHCI_RZV2M depends on USB_GADGET

Posted by Tom Rix 2 years, 7 months ago

On 2/5/23 12:52 AM, Biju Das wrote:
> Hi Tom,
>
> Thanks for the patch.
>
> Arnd send a patch for refactoring the USB_XHCI_RZV2M KConfig dependencies related to USB_GADGET on [1] and
> is in usb-next. Do you see this issue after applying[1]?
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id=ec5499d338ece9db9b7590649d3cfcc4d7f9603d

 From reviewing, it will likely work.

Tom

> Cheers,
> Biju
>
>> -----Original Message-----
>> From: Tom Rix <trix@redhat.com>
>> Sent: Sunday, February 5, 2023 2:12 AM
>> To: gregkh@linuxfoundation.org; arnd@arndb.de; linus.walleij@linaro.org;
>> artur.bujdoso@gmail.com; miquel.raynal@bootlin.com; colin.i.king@gmail.com;
>> Biju Das <biju.das.jz@bp.renesas.com>; tmaimon77@gmail.com
>> Cc: linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; Tom Rix
>> <trix@redhat.com>
>> Subject: [PATCH] usb: host: USB_XHCI_RZV2M depends on USB_GADGET
>>
>> A rand config causes this link error
>> ld: drivers/usb/host/xhci-rzv2m.o: in function `xhci_rzv2m_init_quirk':
>> xhci-rzv2m.c:(.text+0x13): undefined reference to `rzv2m_usb3drd_reset'
>>
>> xhci_rzv2m_init_quirk build is controlled by USB_XHCI_RZV2M
>> rzv2m_usb3drd_reset build is controlled by USB_RZV2M_USB3DRD
>>
>> USE_XHCI_RZV2M does select USB_RZV2M_USB3DRD, but USB_RZV2M_USB3DRD depends
>> on USB_GADGET, so now does USE_XHCI_RZV2M.
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>> ---
>>   drivers/usb/host/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index
>> 2b80ce9587c1..2dd9e95a5b86 100644
>> --- a/drivers/usb/host/Kconfig
>> +++ b/drivers/usb/host/Kconfig
>> @@ -100,6 +100,7 @@ config USB_XHCI_RZV2M
>>   	tristate "xHCI support for Renesas RZ/V2M SoC"
>>   	depends on USB_XHCI_PLATFORM
>>   	depends on ARCH_R9A09G011 || COMPILE_TEST
>> +	depends on USB_GADGET
>>   	select USB_RZV2M_USB3DRD
>>   	help
>>   	  Say 'Y' to enable the support for the xHCI host controller
>> --
>> 2.27.0