thermal: intel_powerclamp: Add dependency on CPU_IDLE

[PATCH] thermal: intel_powerclamp: Add dependency on CPU_IDLE

Posted by Srinivas Pandruvada 2 years, 7 months ago

Fix error:
   WARNING: unmet direct dependencies detected for IDLE_INJECT
     Depends on [n]: POWERCAP [=y] && CPU_IDLE [=n]
     Selected by [y]:
     - INTEL_POWERCLAMP [=y] && THERMAL [=y] && (X86 [=y] ||
X86_INTEL_QUARK [=n] || COMPILE_TEST [=y]) && X86 [=y] && CPU_SUP_INTEL [=y]

Since IDLE_INJECT depends on CPU_IDLE, add that to INTEL_POWERCLAMP.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
This is for kernel
https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge

 drivers/thermal/intel/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/thermal/intel/Kconfig b/drivers/thermal/intel/Kconfig
index b346a646fffb..b5808f92702d 100644
--- a/drivers/thermal/intel/Kconfig
+++ b/drivers/thermal/intel/Kconfig
@@ -3,6 +3,7 @@ config INTEL_POWERCLAMP
 	tristate "Intel PowerClamp idle injection driver"
 	depends on X86
 	depends on CPU_SUP_INTEL
+	depends on CPU_IDLE
 	select POWERCAP
 	select IDLE_INJECT
 	help
-- 
2.39.1

Re: [PATCH] thermal: intel_powerclamp: Add dependency on CPU_IDLE

Posted by Rafael J. Wysocki 2 years, 7 months ago

On Fri, Feb 3, 2023 at 1:35 PM Srinivas Pandruvada
<srinivas.pandruvada@linux.intel.com> wrote:
>
> Fix error:
>    WARNING: unmet direct dependencies detected for IDLE_INJECT
>      Depends on [n]: POWERCAP [=y] && CPU_IDLE [=n]
>      Selected by [y]:
>      - INTEL_POWERCLAMP [=y] && THERMAL [=y] && (X86 [=y] ||
> X86_INTEL_QUARK [=n] || COMPILE_TEST [=y]) && X86 [=y] && CPU_SUP_INTEL [=y]
>
> Since IDLE_INJECT depends on CPU_IDLE, add that to INTEL_POWERCLAMP.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

I have folded this into the original patch that introduced the issue.

> ---
> This is for kernel
> https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
>
>  drivers/thermal/intel/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/thermal/intel/Kconfig b/drivers/thermal/intel/Kconfig
> index b346a646fffb..b5808f92702d 100644
> --- a/drivers/thermal/intel/Kconfig
> +++ b/drivers/thermal/intel/Kconfig
> @@ -3,6 +3,7 @@ config INTEL_POWERCLAMP
>         tristate "Intel PowerClamp idle injection driver"
>         depends on X86
>         depends on CPU_SUP_INTEL
> +       depends on CPU_IDLE
>         select POWERCAP
>         select IDLE_INJECT
>         help
> --
> 2.39.1
>