arch/riscv/Kconfig | 1 + arch/riscv/kernel/image-vars.h | 2 - arch/riscv/mm/init.c | 2 +- arch/riscv/mm/kasan_init.c | 516 ++++++++++++++++++--------------- arch/riscv/mm/ptdump.c | 24 +- 5 files changed, 298 insertions(+), 247 deletions(-)
As described in patch 2, our current kasan implementation is intricate, so I tried to simplify the implementation and mimic what arm64/x86 are doing. In addition it fixes UEFI bootflow with a kasan kernel and kasan inline instrumentation: all kasan configurations were tested on a large ubuntu kernel with success with KASAN_KUNIT_TEST and KASAN_MODULE_TEST. inline ubuntu config + uefi: sv39: OK sv48: OK sv57: OK outline ubuntu config + uefi: sv39: OK sv48: OK sv57: OK Actually 1 test always fails with KASAN_KUNIT_TEST that I have to check: # kasan_bitops_generic: EXPECTATION FAILED at mm/kasan/kasan__test.c:1020 KASAN failure expected in "set_bit(nr, addr)", but none occurrred Note that Palmer recently proposed to remove COMMAND_LINE_SIZE from the userspace abi https://lore.kernel.org/lkml/20221211061358.28035-1-palmer@rivosinc.com/T/ so that we can finally increase the command line to fit all kasan kernel parameters. All of this should hopefully fix the syzkaller riscv build that has been failing for a few months now, any test is appreciated and if I can help in any way, please ask. base-commit-tag: v6.2-rc6 v4: - Fix build warning by declaring create_tmp_mapping as static, kernel test robot v3: - Add AB from Ard in patch 4, thanks - Fix checkpatch issues in patch 1, thanks Conor v2: - Rebase on top of v6.2-rc3 - patch 4 is now way simpler than it used to be since Ard already moved the string functions into the efistub. Alexandre Ghiti (6): riscv: Split early and final KASAN population functions riscv: Rework kasan population functions riscv: Move DTB_EARLY_BASE_VA to the kernel address space riscv: Fix EFI stub usage of KASAN instrumented strcmp function riscv: Fix ptdump when KASAN is enabled riscv: Unconditionnally select KASAN_VMALLOC if KASAN arch/riscv/Kconfig | 1 + arch/riscv/kernel/image-vars.h | 2 - arch/riscv/mm/init.c | 2 +- arch/riscv/mm/kasan_init.c | 516 ++++++++++++++++++--------------- arch/riscv/mm/ptdump.c | 24 +- 5 files changed, 298 insertions(+), 247 deletions(-) -- 2.37.2
On Fri, 3 Feb 2023 08:52:26 +0100, Alexandre Ghiti wrote:
> As described in patch 2, our current kasan implementation is intricate,
> so I tried to simplify the implementation and mimic what arm64/x86 are
> doing.
>
> In addition it fixes UEFI bootflow with a kasan kernel and kasan inline
> instrumentation: all kasan configurations were tested on a large ubuntu
> kernel with success with KASAN_KUNIT_TEST and KASAN_MODULE_TEST.
>
> [...]
Applied, thanks!
[1/6] riscv: Split early and final KASAN population functions
https://git.kernel.org/palmer/c/70a3bb1e1fd9
[2/6] riscv: Rework kasan population functions
https://git.kernel.org/palmer/c/fec8e4f66e4d
[3/6] riscv: Move DTB_EARLY_BASE_VA to the kernel address space
https://git.kernel.org/palmer/c/1cdf594686a3
[4/6] riscv: Fix EFI stub usage of KASAN instrumented strcmp function
https://git.kernel.org/palmer/c/415e9a115124
[5/6] riscv: Fix ptdump when KASAN is enabled
https://git.kernel.org/palmer/c/fe0c8624d20d
[6/6] riscv: Unconditionnally select KASAN_VMALLOC if KASAN
https://git.kernel.org/palmer/c/4cdc06c5c741
Best regards,
--
Palmer Dabbelt <palmer@rivosinc.com>
On Tue, 07 Mar 2023 19:29:11 PST (-0800), Palmer Dabbelt wrote: > > On Fri, 3 Feb 2023 08:52:26 +0100, Alexandre Ghiti wrote: >> As described in patch 2, our current kasan implementation is intricate, >> so I tried to simplify the implementation and mimic what arm64/x86 are >> doing. >> >> In addition it fixes UEFI bootflow with a kasan kernel and kasan inline >> instrumentation: all kasan configurations were tested on a large ubuntu >> kernel with success with KASAN_KUNIT_TEST and KASAN_MODULE_TEST. >> >> [...] > > Applied, thanks! > > [1/6] riscv: Split early and final KASAN population functions > https://git.kernel.org/palmer/c/70a3bb1e1fd9 > [2/6] riscv: Rework kasan population functions > https://git.kernel.org/palmer/c/fec8e4f66e4d > [3/6] riscv: Move DTB_EARLY_BASE_VA to the kernel address space > https://git.kernel.org/palmer/c/1cdf594686a3 > [4/6] riscv: Fix EFI stub usage of KASAN instrumented strcmp function > https://git.kernel.org/palmer/c/415e9a115124 > [5/6] riscv: Fix ptdump when KASAN is enabled > https://git.kernel.org/palmer/c/fe0c8624d20d > [6/6] riscv: Unconditionnally select KASAN_VMALLOC if KASAN > https://git.kernel.org/palmer/c/4cdc06c5c741 > > Best regards, Sorry, this one didn't actually get tested -- I'd thought it was in the queue before I kicked off the run, but it wasn't. It's testing now, I've dropped it from for-next for a bit as I don't remember if this is one of the patch sets that had a bulid/test failure.
On Fri, 03 Feb 2023 08:52:26 +0100, Alexandre Ghiti wrote:
> As described in patch 2, our current kasan implementation is intricate,
> so I tried to simplify the implementation and mimic what arm64/x86 are
> doing.
>
> In addition it fixes UEFI bootflow with a kasan kernel and kasan inline
> instrumentation: all kasan configurations were tested on a large ubuntu
> kernel with success with KASAN_KUNIT_TEST and KASAN_MODULE_TEST.
>
> [...]
Applied, thanks!
[1/6] riscv: Split early and final KASAN population functions
https://git.kernel.org/palmer/c/cd0334e1c091
[2/6] riscv: Rework kasan population functions
https://git.kernel.org/palmer/c/96f9d4daf745
[3/6] riscv: Move DTB_EARLY_BASE_VA to the kernel address space
https://git.kernel.org/palmer/c/401e84488800
[4/6] riscv: Fix EFI stub usage of KASAN instrumented strcmp function
https://git.kernel.org/palmer/c/617955ca6e27
[5/6] riscv: Fix ptdump when KASAN is enabled
https://git.kernel.org/palmer/c/ecd7ebaf0b5a
[6/6] riscv: Unconditionnally select KASAN_VMALLOC if KASAN
https://git.kernel.org/palmer/c/864046c512c2
Best regards,
--
Palmer Dabbelt <palmer@rivosinc.com>
Hello:
This series was applied to riscv/linux.git (for-next)
by Palmer Dabbelt <palmer@rivosinc.com>:
On Fri, 3 Feb 2023 08:52:26 +0100 you wrote:
> As described in patch 2, our current kasan implementation is intricate,
> so I tried to simplify the implementation and mimic what arm64/x86 are
> doing.
>
> In addition it fixes UEFI bootflow with a kasan kernel and kasan inline
> instrumentation: all kasan configurations were tested on a large ubuntu
> kernel with success with KASAN_KUNIT_TEST and KASAN_MODULE_TEST.
>
> [...]
Here is the summary with links:
- [v4,1/6] riscv: Split early and final KASAN population functions
https://git.kernel.org/riscv/c/70a3bb1e1fd9
- [v4,2/6] riscv: Rework kasan population functions
https://git.kernel.org/riscv/c/fec8e4f66e4d
- [v4,3/6] riscv: Move DTB_EARLY_BASE_VA to the kernel address space
https://git.kernel.org/riscv/c/1cdf594686a3
- [v4,4/6] riscv: Fix EFI stub usage of KASAN instrumented strcmp function
https://git.kernel.org/riscv/c/415e9a115124
- [v4,5/6] riscv: Fix ptdump when KASAN is enabled
https://git.kernel.org/riscv/c/fe0c8624d20d
- [v4,6/6] riscv: Unconditionnally select KASAN_VMALLOC if KASAN
https://git.kernel.org/riscv/c/4cdc06c5c741
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
On Fri, 03 Feb 2023 08:52:26 +0100, Alexandre Ghiti wrote:
> As described in patch 2, our current kasan implementation is intricate,
> so I tried to simplify the implementation and mimic what arm64/x86 are
> doing.
>
> In addition it fixes UEFI bootflow with a kasan kernel and kasan inline
> instrumentation: all kasan configurations were tested on a large ubuntu
> kernel with success with KASAN_KUNIT_TEST and KASAN_MODULE_TEST.
>
> [...]
Applied, thanks!
[1/6] riscv: Split early and final KASAN population functions
https://git.kernel.org/palmer/c/cd0334e1c091
[2/6] riscv: Rework kasan population functions
https://git.kernel.org/palmer/c/96f9d4daf745
[3/6] riscv: Move DTB_EARLY_BASE_VA to the kernel address space
https://git.kernel.org/palmer/c/401e84488800
[4/6] riscv: Fix EFI stub usage of KASAN instrumented strcmp function
https://git.kernel.org/palmer/c/617955ca6e27
[5/6] riscv: Fix ptdump when KASAN is enabled
https://git.kernel.org/palmer/c/ecd7ebaf0b5a
[6/6] riscv: Unconditionnally select KASAN_VMALLOC if KASAN
https://git.kernel.org/palmer/c/864046c512c2
Best regards,
--
Palmer Dabbelt <palmer@rivosinc.com>
© 2016 - 2025 Red Hat, Inc.