[v1] Tegra TPM driver with hw flow control

[PATCH 0/4] Tegra TPM driver with hw flow control

Krishna Yarlagadda posted 4 patches 2 years, 7 months ago

Diff against v2
Download series mbox

There is a newer version of this series

.../security/tpm/nvidia,tegra-tpm-spi.txt     |  14 ++
...nvidia,tegra210-quad-peripheral-props.yaml |   6 +
drivers/char/tpm/Makefile                     |   1 +
drivers/char/tpm/tpm_tis_spi.h                |   1 +
drivers/char/tpm/tpm_tis_spi_main.c           |   4 +-
drivers/char/tpm/tpm_tis_spi_tegra.c          | 123 ++++++++++++++++++
drivers/spi/spi-tegra210-quad.c               |  16 +++
7 files changed, 164 insertions(+), 1 deletion(-)
create mode 100644 Documentation/devicetree/bindings/security/tpm/nvidia,tegra-tpm-spi.txt
create mode 100644 drivers/char/tpm/tpm_tis_spi_tegra.c

Expand all Fold all

[PATCH 0/4] Tegra TPM driver with hw flow control

Posted by Krishna Yarlagadda 2 years, 7 months ago

Tegra234 and Tegra241 chips have QSPI controller that supports TCG
PC Client Specific TPM Interface Specification (TIS) flow control.
Since the controller only supports half duplex, sw wait polling
(flow control using full duplex transfers) method implemented in
tpm_tis_spi_main.c does not suffice.
Added extended driver to disable sw flow control and send
all transfers in single message. Flow control is handled by hardware.

Krishna Yarlagadda (4):
  dt-bindings: tpm: Add compatible for Tegra TPM
  tpm: tegra: Support SPI tpm wait state detect
  spi: dt-bindings: Add Tegra TPM wait polling flag
  spi: tegra210-quad: Enable TPM wait polling

 .../security/tpm/nvidia,tegra-tpm-spi.txt     |  14 ++
 ...nvidia,tegra210-quad-peripheral-props.yaml |   6 +
 drivers/char/tpm/Makefile                     |   1 +
 drivers/char/tpm/tpm_tis_spi.h                |   1 +
 drivers/char/tpm/tpm_tis_spi_main.c           |   4 +-
 drivers/char/tpm/tpm_tis_spi_tegra.c          | 123 ++++++++++++++++++
 drivers/spi/spi-tegra210-quad.c               |  16 +++
 7 files changed, 164 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/security/tpm/nvidia,tegra-tpm-spi.txt
 create mode 100644 drivers/char/tpm/tpm_tis_spi_tegra.c

-- 
2.17.1

Re: [PATCH 0/4] Tegra TPM driver with hw flow control

Posted by Jarkko Sakkinen 2 years, 7 months ago

On Thu, Feb 02, 2023 at 09:47:46PM +0530, Krishna Yarlagadda wrote:
> Tegra234 and Tegra241 chips have QSPI controller that supports TCG
> PC Client Specific TPM Interface Specification (TIS) flow control.
> Since the controller only supports half duplex, sw wait polling
> (flow control using full duplex transfers) method implemented in
> tpm_tis_spi_main.c does not suffice.
> Added extended driver to disable sw flow control and send

s/Added/Add/

What is "extended driver"?

> all transfers in single message. Flow control is handled by hardware.
> 
> Krishna Yarlagadda (4):
>   dt-bindings: tpm: Add compatible for Tegra TPM
>   tpm: tegra: Support SPI tpm wait state detect
>   spi: dt-bindings: Add Tegra TPM wait polling flag
>   spi: tegra210-quad: Enable TPM wait polling
> 
>  .../security/tpm/nvidia,tegra-tpm-spi.txt     |  14 ++
>  ...nvidia,tegra210-quad-peripheral-props.yaml |   6 +
>  drivers/char/tpm/Makefile                     |   1 +
>  drivers/char/tpm/tpm_tis_spi.h                |   1 +
>  drivers/char/tpm/tpm_tis_spi_main.c           |   4 +-
>  drivers/char/tpm/tpm_tis_spi_tegra.c          | 123 ++++++++++++++++++
>  drivers/spi/spi-tegra210-quad.c               |  16 +++
>  7 files changed, 164 insertions(+), 1 deletion(-)
>  create mode 100644 Documentation/devicetree/bindings/security/tpm/nvidia,tegra-tpm-spi.txt
>  create mode 100644 drivers/char/tpm/tpm_tis_spi_tegra.c
> 
> -- 
> 2.17.1
> 

BR, Jarkko