[PATCH] tools/lib/thermal: fix thermal_sampling_exit()

Vincent Guittot posted 1 patch 3 years, 2 months ago
tools/lib/thermal/sampling.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] tools/lib/thermal: fix thermal_sampling_exit()
Posted by Vincent Guittot 3 years, 2 months ago
thermal_sampling_init() suscribes to THERMAL_GENL_SAMPLING_GROUP_NAME group
so thermal_sampling_exit() should unsubscribe from the same group.

Fixes: 47c4b0de080a ("tools/lib/thermal: Add a thermal library")
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
---
 tools/lib/thermal/sampling.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/lib/thermal/sampling.c b/tools/lib/thermal/sampling.c
index ee818f4e9654..70577423a9f0 100644
--- a/tools/lib/thermal/sampling.c
+++ b/tools/lib/thermal/sampling.c
@@ -54,7 +54,7 @@ int thermal_sampling_fd(struct thermal_handler *th)
 thermal_error_t thermal_sampling_exit(struct thermal_handler *th)
 {
 	if (nl_unsubscribe_thermal(th->sk_sampling, th->cb_sampling,
-				   THERMAL_GENL_EVENT_GROUP_NAME))
+				   THERMAL_GENL_SAMPLING_GROUP_NAME))
 		return THERMAL_ERROR;
 
 	nl_thermal_disconnect(th->sk_sampling, th->cb_sampling);
-- 
2.34.1
Re: [PATCH] tools/lib/thermal: fix thermal_sampling_exit()
Posted by Daniel Lezcano 3 years, 2 months ago
On 02/02/2023 11:28, Vincent Guittot wrote:
> thermal_sampling_init() suscribes to THERMAL_GENL_SAMPLING_GROUP_NAME group
> so thermal_sampling_exit() should unsubscribe from the same group.
> 
> Fixes: 47c4b0de080a ("tools/lib/thermal: Add a thermal library")
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
> ---

Thanks for the fix, applied


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog