colibri.dtsi: Refactor ASoC driver name

[PATCH v1] colibri.dtsi: Refactor ASoC driver name

Posted by Markus Burri 2 years, 7 months ago

From: Manuel Traut <manuel.traut@mt.com>

ASoC driver names have a 15 character size limit:
[   21.917463] imx-sgtl5000 sound: ASoC: driver name too long 'imx6dl-colibri-sgtl5000' -> 'imx6dl-colibri-'

Use a name that fits.

Signed-off-by: Manuel Traut <manuel.traut@mt.com>
Signed-off-by: Markus Burri <markus.burri@mt.com>
---
 arch/arm/boot/dts/imx6qdl-colibri.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl-colibri.dtsi b/arch/arm/boot/dts/imx6qdl-colibri.dtsi
index d8f985f297e4..f50030cf208a 100644
--- a/arch/arm/boot/dts/imx6qdl-colibri.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-colibri.dtsi
@@ -129,7 +129,7 @@ sound {
 			"LINE_IN", "Line In Jack",
 			"MIC_IN", "Mic Jack",
 			"Mic Jack", "Mic Bias";
-		model = "imx6dl-colibri-sgtl5000";
+		model = "imx-sgtl5000";
 		mux-int-port = <1>;
 		mux-ext-port = <5>;
 		ssi-controller = <&ssi1>;
-- 
2.25.1

Re: [PATCH v1] colibri.dtsi: Refactor ASoC driver name

Posted by Krzysztof Kozlowski 2 years, 7 months ago

On 01/02/2023 13:09, Markus Burri wrote:
> From: Manuel Traut <manuel.traut@mt.com>
> 

Use subject prefixes matching the subsystem (which you can get for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching).

Best regards,
Krzysztof

Re: [PATCH v1] colibri.dtsi: Refactor ASoC driver name

Posted by Fabio Estevam 2 years, 7 months ago

On Wed, Feb 1, 2023 at 9:09 AM Markus Burri <markus.burri@mt.com> wrote:
>
> From: Manuel Traut <manuel.traut@mt.com>
>
> ASoC driver names have a 15 character size limit:
> [   21.917463] imx-sgtl5000 sound: ASoC: driver name too long 'imx6dl-colibri-sgtl5000' -> 'imx6dl-colibri-'
>
> Use a name that fits.
>
> Signed-off-by: Manuel Traut <manuel.traut@mt.com>
> Signed-off-by: Markus Burri <markus.burri@mt.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>

[PATCH v2] ARM: dts: imx6qdl-colibri: Refactor ASoC driver name

Posted by Markus Burri 2 years, 7 months ago

From: Manuel Traut <manuel.traut@mt.com>

ASoC driver names have a 15 character size limit:
[   21.917463] imx-sgtl5000 sound: ASoC: driver name too long 'imx6dl-colibri-sgtl5000' -> 'imx6dl-colibri-'

Use a name that fits.

Signed-off-by: Manuel Traut <manuel.traut@mt.com>
Signed-off-by: Markus Burri <markus.burri@mt.com>
---
 arch/arm/boot/dts/imx6qdl-colibri.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl-colibri.dtsi b/arch/arm/boot/dts/imx6qdl-colibri.dtsi
index d8f985f297e4..f50030cf208a 100644
--- a/arch/arm/boot/dts/imx6qdl-colibri.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-colibri.dtsi
@@ -129,7 +129,7 @@ sound {
 			"LINE_IN", "Line In Jack",
 			"MIC_IN", "Mic Jack",
 			"Mic Jack", "Mic Bias";
-		model = "imx6dl-colibri-sgtl5000";
+		model = "imx-sgtl5000";
 		mux-int-port = <1>;
 		mux-ext-port = <5>;
 		ssi-controller = <&ssi1>;
-- 
2.25.1