iio: adis16480: select CONFIG_CRC32

[PATCH] iio: adis16480: select CONFIG_CRC32

Posted by Arnd Bergmann 3 years ago

From: Arnd Bergmann <arnd@arndb.de>

In rare randconfig builds, the missing CRC32 helper causes
a link error:

ld.lld: error: undefined symbol: crc32_le
>>> referenced by usercopy_64.c
>>>               vmlinux.o:(adis16480_trigger_handler)

Fixes: 941f130881fa ("iio: adis16480: support burst read function")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/iio/imu/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/imu/Kconfig b/drivers/iio/imu/Kconfig
index f1d7d4b5e222..c2f97629e9cd 100644
--- a/drivers/iio/imu/Kconfig
+++ b/drivers/iio/imu/Kconfig
@@ -47,6 +47,7 @@ config ADIS16480
 	depends on SPI
 	select IIO_ADIS_LIB
 	select IIO_ADIS_LIB_BUFFER if IIO_BUFFER
+	select CRC32
 	help
 	  Say yes here to build support for Analog Devices ADIS16375, ADIS16480,
 	  ADIS16485, ADIS16488 inertial sensors.
-- 
2.39.0

Re: [PATCH] iio: adis16480: select CONFIG_CRC32

Posted by Nuno Sá 3 years ago

On Tue, 2023-01-31 at 10:46 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> In rare randconfig builds, the missing CRC32 helper causes
> a link error:
> 
> ld.lld: error: undefined symbol: crc32_le
> > > > referenced by usercopy_64.c
> > > >               vmlinux.o:(adis16480_trigger_handler)
> 
> Fixes: 941f130881fa ("iio: adis16480: support burst read function")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Reviewed-by: Nuno Sá <nuno.sa@analog.com>

Re: [PATCH] iio: adis16480: select CONFIG_CRC32

Posted by Jonathan Cameron 3 years ago

On Tue, 31 Jan 2023 11:23:10 +0100
Nuno Sá <noname.nuno@gmail.com> wrote:

> On Tue, 2023-01-31 at 10:46 +0100, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> > 
> > In rare randconfig builds, the missing CRC32 helper causes
> > a link error:
> > 
> > ld.lld: error: undefined symbol: crc32_le  
> > > > > referenced by usercopy_64.c
> > > > >               vmlinux.o:(adis16480_trigger_handler)  
> > 
> > Fixes: 941f130881fa ("iio: adis16480: support burst read function")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---  
> 
> Reviewed-by: Nuno Sá <nuno.sa@analog.com>
> 
> 
Applied to the fixes-togreg branch of iio.git and marked
for stable.

Thanks,

Jonathan