[PATCH -next] mm/swapfile: remove pr_debug in get_swap_pages()

Longlong Xia posted 1 patch 2 years, 7 months ago
mm/swapfile.c | 2 --
1 file changed, 2 deletions(-)
[PATCH -next] mm/swapfile: remove pr_debug in get_swap_pages()
Posted by Longlong Xia 2 years, 7 months ago
It's known that get_swap_pages() may fail to find available space
under some extreme case, but pr_debug() provides useless information.
Let's remove it.

Signed-off-by: Longlong Xia <xialonglong1@huawei.com>
---
 mm/swapfile.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/mm/swapfile.c b/mm/swapfile.c
index 6202a6668a63..99143875d6f0 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -1098,8 +1098,6 @@ int get_swap_pages(int n_goal, swp_entry_t swp_entries[], int entry_size)
 		spin_unlock(&si->lock);
 		if (n_ret || size == SWAPFILE_CLUSTER)
 			goto check_out;
-		pr_debug("scan_swap_map of si %d failed to find offset\n",
-			si->type);
 		cond_resched();
 
 		spin_lock(&swap_avail_lock);
-- 
2.25.1
Re: [PATCH -next] mm/swapfile: remove pr_debug in get_swap_pages()
Posted by Huang, Ying 2 years, 7 months ago
Longlong Xia <xialonglong1@huawei.com> writes:

> It's known that get_swap_pages() may fail to find available space
> under some extreme case, but pr_debug() provides useless information.
> Let's remove it.
>
> Signed-off-by: Longlong Xia <xialonglong1@huawei.com>

Thanks!

Reviewed-by: "Huang, Ying" <ying.huang@intel.com>

> ---
>  mm/swapfile.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/mm/swapfile.c b/mm/swapfile.c
> index 6202a6668a63..99143875d6f0 100644
> --- a/mm/swapfile.c
> +++ b/mm/swapfile.c
> @@ -1098,8 +1098,6 @@ int get_swap_pages(int n_goal, swp_entry_t swp_entries[], int entry_size)
>  		spin_unlock(&si->lock);
>  		if (n_ret || size == SWAPFILE_CLUSTER)
>  			goto check_out;
> -		pr_debug("scan_swap_map of si %d failed to find offset\n",
> -			si->type);
>  		cond_resched();
>  
>  		spin_lock(&swap_avail_lock);