[PATCH 0/4] perf intel-pt: Fix the pipe mode (v2)

Namhyung Kim posted 4 patches 2 years, 7 months ago
tools/perf/Documentation/perf-intel-pt.txt | 30 ++++++++++++++++++++++
tools/perf/builtin-inject.c                |  6 ++---
tools/perf/tests/shell/test_intel_pt.sh    | 17 ++++++++++++
tools/perf/util/auxtrace.c                 |  3 +++
tools/perf/util/intel-pt.c                 |  6 +++++
tools/perf/util/session.c                  |  9 +++++--
6 files changed, 66 insertions(+), 5 deletions(-)
[PATCH 0/4] perf intel-pt: Fix the pipe mode (v2)
Posted by Namhyung Kim 2 years, 7 months ago
Hello,

I found some problems in Intel-PT and auxtrace in general with pipe.
In the past it used to work with pipe, but recent code fails.  As it
also touches the generic code, other auxtrace users like ARM SPE will
be affected too.  I added a test case to verify it works with pipes.

Changes in v2)
 * add a warning in intel_pt_process_auxtrace_info()
 * add Reviewed-by from James

At last, I can run this command without a problem.

  $ perf record -o- -e intel_pt// true | perf inject -b | perf report -i- --itrace=i1000

The code is available at 'perf/auxtrace-pipe-v2' branch in

  git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Thanks,
Namhyung


Namhyung Kim (4):
  perf inject: Use perf_data__read() for auxtrace
  perf intel-pt: Do not try to queue auxtrace data on pipe
  perf session: Avoid calling lseek(2) for pipe
  perf test: Add pipe mode test to the Intel PT test suite

 tools/perf/Documentation/perf-intel-pt.txt | 30 ++++++++++++++++++++++
 tools/perf/builtin-inject.c                |  6 ++---
 tools/perf/tests/shell/test_intel_pt.sh    | 17 ++++++++++++
 tools/perf/util/auxtrace.c                 |  3 +++
 tools/perf/util/intel-pt.c                 |  6 +++++
 tools/perf/util/session.c                  |  9 +++++--
 6 files changed, 66 insertions(+), 5 deletions(-)


base-commit: 5670ebf54bd26482f57a094c53bdc562c106e0a9
-- 
2.39.1.456.gfc5497dd1b-goog
Re: [PATCH 0/4] perf intel-pt: Fix the pipe mode (v2)
Posted by Adrian Hunter 2 years, 7 months ago
On 31/01/23 04:33, Namhyung Kim wrote:
> Hello,
> 
> I found some problems in Intel-PT and auxtrace in general with pipe.
> In the past it used to work with pipe, but recent code fails.  As it
> also touches the generic code, other auxtrace users like ARM SPE will
> be affected too.  I added a test case to verify it works with pipes.
> 
> Changes in v2)
>  * add a warning in intel_pt_process_auxtrace_info()
>  * add Reviewed-by from James

Minor changes suggested for patch 2, otherwise:

Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>

> 
> At last, I can run this command without a problem.
> 
>   $ perf record -o- -e intel_pt// true | perf inject -b | perf report -i- --itrace=i1000
> 
> The code is available at 'perf/auxtrace-pipe-v2' branch in
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
> 
> Thanks,
> Namhyung
> 
> 
> Namhyung Kim (4):
>   perf inject: Use perf_data__read() for auxtrace
>   perf intel-pt: Do not try to queue auxtrace data on pipe
>   perf session: Avoid calling lseek(2) for pipe
>   perf test: Add pipe mode test to the Intel PT test suite
> 
>  tools/perf/Documentation/perf-intel-pt.txt | 30 ++++++++++++++++++++++
>  tools/perf/builtin-inject.c                |  6 ++---
>  tools/perf/tests/shell/test_intel_pt.sh    | 17 ++++++++++++
>  tools/perf/util/auxtrace.c                 |  3 +++
>  tools/perf/util/intel-pt.c                 |  6 +++++
>  tools/perf/util/session.c                  |  9 +++++--
>  6 files changed, 66 insertions(+), 5 deletions(-)
> 
> 
> base-commit: 5670ebf54bd26482f57a094c53bdc562c106e0a9