[PATCH 8/9] leaking_addresses: also skip canonical ftrace path

Ross Zwisler posted 9 patches 2 years, 7 months ago
There is a newer version of this series
[PATCH 8/9] leaking_addresses: also skip canonical ftrace path
Posted by Ross Zwisler 2 years, 7 months ago
The canonical location for the tracefs filesystem is at /sys/kernel/tracing.

But, from Documentation/trace/ftrace.rst:

  Before 4.1, all ftrace tracing control files were within the debugfs
  file system, which is typically located at /sys/kernel/debug/tracing.
  For backward compatibility, when mounting the debugfs file system,
  the tracefs file system will be automatically mounted at:

  /sys/kernel/debug/tracing

scripts/leaking_addresses.pl only skipped this older debugfs path, so
let's add the canonical path as well.

Signed-off-by: Ross Zwisler <zwisler@google.com>
---
 scripts/leaking_addresses.pl | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl
index 8f636a23bc3f..e695634d153d 100755
--- a/scripts/leaking_addresses.pl
+++ b/scripts/leaking_addresses.pl
@@ -61,6 +61,7 @@ my @skip_abs = (
 	'/proc/device-tree',
 	'/proc/1/syscall',
 	'/sys/firmware/devicetree',
+	'/sys/kernel/tracing/trace_pipe',
 	'/sys/kernel/debug/tracing/trace_pipe',
 	'/sys/kernel/security/apparmor/revision');
 
-- 
2.39.1.456.gfc5497dd1b-goog
Re: [PATCH 8/9] leaking_addresses: also skip canonical ftrace path
Posted by Tycho Andersen 2 years, 7 months ago
On Mon, Jan 30, 2023 at 11:19:14AM -0700, Ross Zwisler wrote:
> The canonical location for the tracefs filesystem is at /sys/kernel/tracing.
> 
> But, from Documentation/trace/ftrace.rst:
> 
>   Before 4.1, all ftrace tracing control files were within the debugfs
>   file system, which is typically located at /sys/kernel/debug/tracing.
>   For backward compatibility, when mounting the debugfs file system,
>   the tracefs file system will be automatically mounted at:
> 
>   /sys/kernel/debug/tracing
> 
> scripts/leaking_addresses.pl only skipped this older debugfs path, so
> let's add the canonical path as well.
> 
> Signed-off-by: Ross Zwisler <zwisler@google.com>
> ---
>  scripts/leaking_addresses.pl | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl
> index 8f636a23bc3f..e695634d153d 100755
> --- a/scripts/leaking_addresses.pl
> +++ b/scripts/leaking_addresses.pl
> @@ -61,6 +61,7 @@ my @skip_abs = (
>  	'/proc/device-tree',
>  	'/proc/1/syscall',
>  	'/sys/firmware/devicetree',
> +	'/sys/kernel/tracing/trace_pipe',
>  	'/sys/kernel/debug/tracing/trace_pipe',
>  	'/sys/kernel/security/apparmor/revision');

Thanks.

Acked-by: Tycho Andersen <tycho@tycho.pizza>