[PATCH net-next v1] net: phy: fix the spelling problem of Sentinel

Frank Sae posted 1 patch 2 years, 7 months ago
drivers/net/phy/motorcomm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH net-next v1] net: phy: fix the spelling problem of Sentinel
Posted by Frank Sae 2 years, 7 months ago
 CHECK: 'sentinal' may be misspelled - perhaps 'sentinel'?

Signed-off-by: Frank Sae <Frank.Sae@motor-comm.com>
---
 drivers/net/phy/motorcomm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c
index 685190db72de..b6968c78c303 100644
--- a/drivers/net/phy/motorcomm.c
+++ b/drivers/net/phy/motorcomm.c
@@ -1804,7 +1804,7 @@ static const struct mdio_device_id __maybe_unused motorcomm_tbl[] = {
 	{ PHY_ID_MATCH_EXACT(PHY_ID_YT8511) },
 	{ PHY_ID_MATCH_EXACT(PHY_ID_YT8521) },
 	{ PHY_ID_MATCH_EXACT(PHY_ID_YT8531S) },
-	{ /* sentinal */ }
+	{ /* sentinel */ }
 };
 
 MODULE_DEVICE_TABLE(mdio, motorcomm_tbl);
-- 
2.34.1
Re: [PATCH net-next v1] net: phy: fix the spelling problem of Sentinel
Posted by Andrew Lunn 2 years, 7 months ago
On Sat, Jan 28, 2023 at 02:35:57PM +0800, Frank Sae wrote:
>  CHECK: 'sentinal' may be misspelled - perhaps 'sentinel'?
> 
> Signed-off-by: Frank Sae <Frank.Sae@motor-comm.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
[PATCH net-next v1] net: phy: motorcomm: change the phy id of yt8521 and yt8531s to lowercase
Posted by Frank Sae 2 years, 7 months ago
 The phy id is usually defined in lower case.

Signed-off-by: Frank Sae <Frank.Sae@motor-comm.com>
---
 drivers/net/phy/motorcomm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c
index b6968c78c303..aa02e722c51d 100644
--- a/drivers/net/phy/motorcomm.c
+++ b/drivers/net/phy/motorcomm.c
@@ -12,8 +12,8 @@
 #include <linux/phy.h>
 
 #define PHY_ID_YT8511		0x0000010a
-#define PHY_ID_YT8521		0x0000011A
-#define PHY_ID_YT8531S		0x4F51E91A
+#define PHY_ID_YT8521		0x0000011a
+#define PHY_ID_YT8531S		0x4f51e91a
 
 /* YT8521/YT8531S Register Overview
  *	UTP Register space	|	FIBER Register space
-- 
2.34.1
Re: [PATCH net-next v1] net: phy: motorcomm: change the phy id of yt8521 and yt8531s to lowercase
Posted by Andrew Lunn 2 years, 7 months ago
On Sat, Jan 28, 2023 at 02:35:58PM +0800, Frank Sae wrote:
>  The phy id is usually defined in lower case.
> 
> Signed-off-by: Frank Sae <Frank.Sae@motor-comm.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew