drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
From: Rob Clark <robdclark@chromium.org>
No longer needed since the removal of dependency on DMA helper.
Fixes: 2ea8aec56bf1 ("drm/mediatek: Remove dependency on GEM DMA helper")
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index cd5b18ef7951..7e2fad8e8444 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -20,8 +20,8 @@
#include <drm/drm_fbdev_generic.h>
#include <drm/drm_fourcc.h>
#include <drm/drm_gem.h>
-#include <drm/drm_gem_dma_helper.h>
#include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_ioctl.h>
#include <drm/drm_of.h>
#include <drm/drm_probe_helper.h>
#include <drm/drm_vblank.h>
--
2.38.1
Hi, Rob: Rob Clark <robdclark@gmail.com> 於 2023年1月28日 週六 上午12:54寫道: > > From: Rob Clark <robdclark@chromium.org> > > No longer needed since the removal of dependency on DMA helper. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Fixes: 2ea8aec56bf1 ("drm/mediatek: Remove dependency on GEM DMA helper") > Signed-off-by: Rob Clark <robdclark@chromium.org> > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > index cd5b18ef7951..7e2fad8e8444 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > @@ -20,8 +20,8 @@ > #include <drm/drm_fbdev_generic.h> > #include <drm/drm_fourcc.h> > #include <drm/drm_gem.h> > -#include <drm/drm_gem_dma_helper.h> > #include <drm/drm_gem_framebuffer_helper.h> > +#include <drm/drm_ioctl.h> > #include <drm/drm_of.h> > #include <drm/drm_probe_helper.h> > #include <drm/drm_vblank.h> > -- > 2.38.1 >
Hi, On Fri, Jan 27, 2023 at 8:54 AM Rob Clark <robdclark@gmail.com> wrote: > > From: Rob Clark <robdclark@chromium.org> > > No longer needed since the removal of dependency on DMA helper. > > Fixes: 2ea8aec56bf1 ("drm/mediatek: Remove dependency on GEM DMA helper") > Signed-off-by: Rob Clark <robdclark@chromium.org> Reported-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > index cd5b18ef7951..7e2fad8e8444 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > @@ -20,8 +20,8 @@ > #include <drm/drm_fbdev_generic.h> > #include <drm/drm_fourcc.h> > #include <drm/drm_gem.h> > -#include <drm/drm_gem_dma_helper.h> > #include <drm/drm_gem_framebuffer_helper.h> > +#include <drm/drm_ioctl.h> It took me a little while to realize why you needed this extra include. I guess DEFINE_DRM_GEM_FOPS implicitly refers to drm_ioctl(). Seems like really drm_gem.h ought to be the one including drm_ioctl.h, but maybe there's a good reason why we don't do that? -Doug
© 2016 - 2024 Red Hat, Inc.