[PATCH] gpio: ep93xx: remove unused variable

Arnd Bergmann posted 1 patch 2 years, 7 months ago
drivers/gpio/gpio-ep93xx.c | 2 --
1 file changed, 2 deletions(-)
[PATCH] gpio: ep93xx: remove unused variable
Posted by Arnd Bergmann 2 years, 7 months ago
From: Arnd Bergmann <arnd@arndb.de>

This one was left behind by a previous cleanup patch:

drivers/gpio/gpio-ep93xx.c: In function 'ep93xx_gpio_add_bank':
drivers/gpio/gpio-ep93xx.c:366:34: error: unused variable 'ic' [-Werror=unused-variable]

Fixes: 216f37366e86 ("gpio: ep93xx: Make irqchip immutable")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpio/gpio-ep93xx.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c
index 192be99b1392..6cedf46efec6 100644
--- a/drivers/gpio/gpio-ep93xx.c
+++ b/drivers/gpio/gpio-ep93xx.c
@@ -363,8 +363,6 @@ static int ep93xx_gpio_add_bank(struct ep93xx_gpio_chip *egc,
 
 	girq = &gc->irq;
 	if (bank->has_irq || bank->has_hierarchical_irq) {
-		struct irq_chip *ic;
-
 		gc->set_config = ep93xx_gpio_set_config;
 		egc->eic = devm_kcalloc(dev, 1,
 					sizeof(*egc->eic),
-- 
2.39.0
Re: [PATCH] gpio: ep93xx: remove unused variable
Posted by Bartosz Golaszewski 2 years, 7 months ago
On Fri, Jan 27, 2023 at 10:35 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> This one was left behind by a previous cleanup patch:
>
> drivers/gpio/gpio-ep93xx.c: In function 'ep93xx_gpio_add_bank':
> drivers/gpio/gpio-ep93xx.c:366:34: error: unused variable 'ic' [-Werror=unused-variable]
>
> Fixes: 216f37366e86 ("gpio: ep93xx: Make irqchip immutable")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/gpio/gpio-ep93xx.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c
> index 192be99b1392..6cedf46efec6 100644
> --- a/drivers/gpio/gpio-ep93xx.c
> +++ b/drivers/gpio/gpio-ep93xx.c
> @@ -363,8 +363,6 @@ static int ep93xx_gpio_add_bank(struct ep93xx_gpio_chip *egc,
>
>         girq = &gc->irq;
>         if (bank->has_irq || bank->has_hierarchical_irq) {
> -               struct irq_chip *ic;
> -
>                 gc->set_config = ep93xx_gpio_set_config;
>                 egc->eic = devm_kcalloc(dev, 1,
>                                         sizeof(*egc->eic),
> --
> 2.39.0
>

Applied, thanks!

Bart