[PATCH] regulator: max20411: Directly include bitfield.h

broonie@kernel.org posted 1 patch 2 years, 7 months ago
drivers/regulator/max20411-regulator.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] regulator: max20411: Directly include bitfield.h
Posted by broonie@kernel.org 2 years, 7 months ago
From: Mark Brown <broonie@kernel.org>

The max20411 driver uses bitfield.h but does not directly include
it, add an inclusion to avoid build errors in configurations
which do not result in an implicit inclusion.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/regulator/max20411-regulator.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/max20411-regulator.c b/drivers/regulator/max20411-regulator.c
index 69f04cbe69f1..b4faad54c458 100644
--- a/drivers/regulator/max20411-regulator.c
+++ b/drivers/regulator/max20411-regulator.c
@@ -4,6 +4,7 @@
  * Copyright (c) 2022, Linaro Ltd.
  */
 
+#include <linux/bitfield.h>
 #include <linux/gpio/consumer.h>
 #include <linux/i2c.h>
 #include <linux/module.h>
-- 
2.34.1
Re: [PATCH] regulator: max20411: Directly include bitfield.h
Posted by Bjorn Andersson 2 years, 7 months ago
On Thu, Jan 26, 2023 at 10:54:03PM +0000, broonie@kernel.org wrote:
> From: Mark Brown <broonie@kernel.org>
> 
> The max20411 driver uses bitfield.h but does not directly include
> it, add an inclusion to avoid build errors in configurations
> which do not result in an implicit inclusion.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>

Reviewed-by: Bjorn Andersson <quic_bjorande@quicinc.com>

> ---
>  drivers/regulator/max20411-regulator.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/regulator/max20411-regulator.c b/drivers/regulator/max20411-regulator.c
> index 69f04cbe69f1..b4faad54c458 100644
> --- a/drivers/regulator/max20411-regulator.c
> +++ b/drivers/regulator/max20411-regulator.c
> @@ -4,6 +4,7 @@
>   * Copyright (c) 2022, Linaro Ltd.
>   */
>  
> +#include <linux/bitfield.h>
>  #include <linux/gpio/consumer.h>
>  #include <linux/i2c.h>
>  #include <linux/module.h>
> -- 
> 2.34.1
>