[PATCH 2/3] gpio: Add new flag BGPIOF_NO_INPUT

Niall Leonard via B4 Submission Endpoint posted 3 patches 2 years, 7 months ago
[PATCH 2/3] gpio: Add new flag BGPIOF_NO_INPUT
Posted by Niall Leonard via B4 Submission Endpoint 2 years, 7 months ago
From: Niall Leonard <nl250060@ncr.com>

Signed-off-by: Niall Leonard <nl250060@ncr.com>
---
 include/linux/gpio/driver.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index 44783fc16125..e8e57310e3b8 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -682,6 +682,7 @@ int bgpio_init(struct gpio_chip *gc, struct device *dev,
 #define BGPIOF_READ_OUTPUT_REG_SET	BIT(4) /* reg_set stores output value */
 #define BGPIOF_NO_OUTPUT		BIT(5) /* only input */
 #define BGPIOF_NO_SET_ON_INPUT		BIT(6)
+#define BGPIOF_NO_INPUT				BIT(7)	/* only output */
 
 int gpiochip_irq_map(struct irq_domain *d, unsigned int irq,
 		     irq_hw_number_t hwirq);

-- 
2.34.1
Re: [PATCH 2/3] gpio: Add new flag BGPIOF_NO_INPUT
Posted by Linus Walleij 2 years, 7 months ago
On Thu, Jan 26, 2023 at 11:18 AM Niall Leonard via B4 Submission
Endpoint <devnull+nl250060.ncr.com@kernel.org> wrote:

> From: Niall Leonard <nl250060@ncr.com>
>
> Signed-off-by: Niall Leonard <nl250060@ncr.com>

I would squash this with the other patch adding it to the MMIO driver
per the principle one patch = one technical step.

Anyway:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Re: [PATCH 2/3] gpio: Add new flag BGPIOF_NO_INPUT
Posted by Leonard, Niall 2 years, 7 months ago
On 27/01/2023 12:54, Linus Walleij wrote:
> *External Message* - Use caution before opening links or attachments
> 
> On Thu, Jan 26, 2023 at 11:18 AM Niall Leonard via B4 Submission
> Endpoint <devnull+nl250060.ncr.com@kernel.org> wrote:
> 
>> From: Niall Leonard <nl250060@ncr.com>
>>
>> Signed-off-by: Niall Leonard <nl250060@ncr.com>
> 
> I would squash this with the other patch adding it to the MMIO driver
> per the principle one patch = one technical step.
> 
> Anyway:
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Yours,
> Linus Walleij
Thanks for reviewing.
I will do as you suggest in the next version.

Regards,
Niall Leonard