From: Balsam CHIHI <bchihi@baylibre.com>
Add LVTS thermal controllers dt-binding definition for mt8195.
Signed-off-by: Balsam CHIHI <bchihi@baylibre.com>
---
.../thermal/mediatek,lvts-thermal.yaml | 107 ++++++++++++++++++
include/dt-bindings/thermal/mediatek-lvts.h | 19 ++++
2 files changed, 126 insertions(+)
create mode 100644 Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
create mode 100644 include/dt-bindings/thermal/mediatek-lvts.h
diff --git a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
new file mode 100644
index 000000000000..12bfbdd8ff89
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
@@ -0,0 +1,107 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/thermal/mediatek,lvts-thermal.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek SoC Low Voltage Thermal Sensor (LVTS)
+
+maintainers:
+ - Balsam CHIHI <bchihi@baylibre.com>
+
+description: |
+ LVTS is a thermal management architecture composed of three subsystems,
+ a Sensing device - Thermal Sensing Micro Circuit Unit (TSMCU),
+ a Converter - Low Voltage Thermal Sensor converter (LVTS), and
+ a Digital controller (LVTS_CTRL).
+
+properties:
+ compatible:
+ enum:
+ - mediatek,mt8195-lvts-ap
+ - mediatek,mt8195-lvts-mcu
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ resets:
+ maxItems: 1
+ description: LVTS reset for clearing temporary data on AP/MCU.
+
+ nvmem-cells:
+ minItems: 1
+ items:
+ - description: Calibration eFuse data 1 for LVTS
+ - description: Calibration eFuse data 2 for LVTS
+
+ nvmem-cell-names:
+ minItems: 1
+ items:
+ - const: lvts-calib-data-1
+ - const: lvts-calib-data-2
+
+ "#thermal-sensor-cells":
+ const: 1
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - resets
+ - nvmem-cells
+ - nvmem-cell-names
+ - "#thermal-sensor-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/clock/mt8195-clk.h>
+ #include <dt-bindings/reset/mt8195-resets.h>
+ #include <dt-bindings/thermal/mediatek-lvts.h>
+
+ soc {
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ lvts_mcu: thermal-sensor@11278000 {
+ compatible = "mediatek,mt8195-lvts-mcu";
+ reg = <0 0x11278000 0 0x1000>;
+ interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH 0>;
+ clocks = <&infracfg_ao CLK_INFRA_AO_THERM>;
+ resets = <&infracfg_ao MT8195_INFRA_RST4_THERM_CTRL_MCU_SWRST>;
+ nvmem-cells = <&lvts_efuse_data1 &lvts_efuse_data2>;
+ nvmem-cell-names = "lvts-calib-data-1", "lvts-calib-data-2";
+ #thermal-sensor-cells = <1>;
+ };
+ };
+
+ thermal_zones: thermal-zones {
+ cpu0-thermal {
+ polling-delay = <1000>;
+ polling-delay-passive = <250>;
+ thermal-sensors = <&lvts_mcu MT8195_MCU_LITTLE_CPU0>;
+
+ trips {
+ cpu0_alert: trip-alert {
+ temperature = <85000>;
+ hysteresis = <2000>;
+ type = "passive";
+ };
+
+ cpu0_crit: trip-crit {
+ temperature = <100000>;
+ hysteresis = <2000>;
+ type = "critical";
+ };
+ };
+ };
+ };
diff --git a/include/dt-bindings/thermal/mediatek-lvts.h b/include/dt-bindings/thermal/mediatek-lvts.h
new file mode 100644
index 000000000000..428a95c18509
--- /dev/null
+++ b/include/dt-bindings/thermal/mediatek-lvts.h
@@ -0,0 +1,19 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright (c) 2023 MediaTek Inc.
+ * Author: Balsam CHIHI <bchihi@baylibre.com>
+ */
+
+#ifndef __MEDIATEK_LVTS_DT_H
+#define __MEDIATEK_LVTS_DT_H
+
+#define MT8195_MCU_BIG_CPU0 0
+#define MT8195_MCU_BIG_CPU1 1
+#define MT8195_MCU_BIG_CPU2 2
+#define MT8195_MCU_BIG_CPU3 3
+#define MT8195_MCU_LITTLE_CPU0 4
+#define MT8195_MCU_LITTLE_CPU1 5
+#define MT8195_MCU_LITTLE_CPU2 6
+#define MT8195_MCU_LITTLE_CPU3 7
+
+#endif /* __MEDIATEK_LVTS_DT_H */
--
2.34.1On Tue, Jan 24, 2023 at 02:17:13PM +0100, bchihi@baylibre.com wrote:
> From: Balsam CHIHI <bchihi@baylibre.com>
>
dt-bindings: thermal: ... for the subject
> Add LVTS thermal controllers dt-binding definition for mt8195.
>
> Signed-off-by: Balsam CHIHI <bchihi@baylibre.com>
> ---
> .../thermal/mediatek,lvts-thermal.yaml | 107 ++++++++++++++++++
> include/dt-bindings/thermal/mediatek-lvts.h | 19 ++++
> 2 files changed, 126 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
> create mode 100644 include/dt-bindings/thermal/mediatek-lvts.h
>
> diff --git a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
> new file mode 100644
> index 000000000000..12bfbdd8ff89
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
> @@ -0,0 +1,107 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/mediatek,lvts-thermal.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek SoC Low Voltage Thermal Sensor (LVTS)
> +
> +maintainers:
> + - Balsam CHIHI <bchihi@baylibre.com>
> +
> +description: |
> + LVTS is a thermal management architecture composed of three subsystems,
> + a Sensing device - Thermal Sensing Micro Circuit Unit (TSMCU),
> + a Converter - Low Voltage Thermal Sensor converter (LVTS), and
> + a Digital controller (LVTS_CTRL).
> +
> +properties:
> + compatible:
> + enum:
> + - mediatek,mt8195-lvts-ap
> + - mediatek,mt8195-lvts-mcu
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> + description: LVTS reset for clearing temporary data on AP/MCU.
> +
> + nvmem-cells:
> + minItems: 1
> + items:
> + - description: Calibration eFuse data 1 for LVTS
> + - description: Calibration eFuse data 2 for LVTS
> +
> + nvmem-cell-names:
> + minItems: 1
> + items:
> + - const: lvts-calib-data-1
> + - const: lvts-calib-data-2
> +
> + "#thermal-sensor-cells":
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - resets
> + - nvmem-cells
> + - nvmem-cell-names
> + - "#thermal-sensor-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/clock/mt8195-clk.h>
> + #include <dt-bindings/reset/mt8195-resets.h>
> + #include <dt-bindings/thermal/mediatek-lvts.h>
> +
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + lvts_mcu: thermal-sensor@11278000 {
> + compatible = "mediatek,mt8195-lvts-mcu";
> + reg = <0 0x11278000 0 0x1000>;
> + interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH 0>;
> + clocks = <&infracfg_ao CLK_INFRA_AO_THERM>;
> + resets = <&infracfg_ao MT8195_INFRA_RST4_THERM_CTRL_MCU_SWRST>;
> + nvmem-cells = <&lvts_efuse_data1 &lvts_efuse_data2>;
> + nvmem-cell-names = "lvts-calib-data-1", "lvts-calib-data-2";
> + #thermal-sensor-cells = <1>;
> + };
> + };
> +
> + thermal_zones: thermal-zones {
> + cpu0-thermal {
> + polling-delay = <1000>;
> + polling-delay-passive = <250>;
> + thermal-sensors = <&lvts_mcu MT8195_MCU_LITTLE_CPU0>;
> +
> + trips {
> + cpu0_alert: trip-alert {
> + temperature = <85000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> +
> + cpu0_crit: trip-crit {
> + temperature = <100000>;
> + hysteresis = <2000>;
> + type = "critical";
> + };
> + };
> + };
> + };
> diff --git a/include/dt-bindings/thermal/mediatek-lvts.h b/include/dt-bindings/thermal/mediatek-lvts.h
> new file mode 100644
> index 000000000000..428a95c18509
> --- /dev/null
> +++ b/include/dt-bindings/thermal/mediatek-lvts.h
> @@ -0,0 +1,19 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
Okay with GPL 4? GPL-2.0-only
Dual license please. Consistent with your .dts files.
> +/*
> + * Copyright (c) 2023 MediaTek Inc.
> + * Author: Balsam CHIHI <bchihi@baylibre.com>
> + */
> +
> +#ifndef __MEDIATEK_LVTS_DT_H
> +#define __MEDIATEK_LVTS_DT_H
> +
> +#define MT8195_MCU_BIG_CPU0 0
> +#define MT8195_MCU_BIG_CPU1 1
> +#define MT8195_MCU_BIG_CPU2 2
> +#define MT8195_MCU_BIG_CPU3 3
> +#define MT8195_MCU_LITTLE_CPU0 4
> +#define MT8195_MCU_LITTLE_CPU1 5
> +#define MT8195_MCU_LITTLE_CPU2 6
> +#define MT8195_MCU_LITTLE_CPU3 7
> +
> +#endif /* __MEDIATEK_LVTS_DT_H */
> --
> 2.34.1
>
Hi Rob,
On Wed, Jan 25, 2023 at 9:34 PM Rob Herring <robh@kernel.org> wrote:
>
> On Tue, Jan 24, 2023 at 02:17:13PM +0100, bchihi@baylibre.com wrote:
> > From: Balsam CHIHI <bchihi@baylibre.com>
> >
>
> dt-bindings: thermal: ... for the subject
I will fix it.
>
> > Add LVTS thermal controllers dt-binding definition for mt8195.
> >
> > Signed-off-by: Balsam CHIHI <bchihi@baylibre.com>
> > ---
> > .../thermal/mediatek,lvts-thermal.yaml | 107 ++++++++++++++++++
> > include/dt-bindings/thermal/mediatek-lvts.h | 19 ++++
> > 2 files changed, 126 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
> > create mode 100644 include/dt-bindings/thermal/mediatek-lvts.h
> >
> > diff --git a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
> > new file mode 100644
> > index 000000000000..12bfbdd8ff89
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
> > @@ -0,0 +1,107 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/thermal/mediatek,lvts-thermal.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: MediaTek SoC Low Voltage Thermal Sensor (LVTS)
> > +
> > +maintainers:
> > + - Balsam CHIHI <bchihi@baylibre.com>
> > +
> > +description: |
> > + LVTS is a thermal management architecture composed of three subsystems,
> > + a Sensing device - Thermal Sensing Micro Circuit Unit (TSMCU),
> > + a Converter - Low Voltage Thermal Sensor converter (LVTS), and
> > + a Digital controller (LVTS_CTRL).
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - mediatek,mt8195-lvts-ap
> > + - mediatek,mt8195-lvts-mcu
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > + resets:
> > + maxItems: 1
> > + description: LVTS reset for clearing temporary data on AP/MCU.
> > +
> > + nvmem-cells:
> > + minItems: 1
> > + items:
> > + - description: Calibration eFuse data 1 for LVTS
> > + - description: Calibration eFuse data 2 for LVTS
> > +
> > + nvmem-cell-names:
> > + minItems: 1
> > + items:
> > + - const: lvts-calib-data-1
> > + - const: lvts-calib-data-2
> > +
> > + "#thermal-sensor-cells":
> > + const: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - clocks
> > + - resets
> > + - nvmem-cells
> > + - nvmem-cell-names
> > + - "#thermal-sensor-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + #include <dt-bindings/clock/mt8195-clk.h>
> > + #include <dt-bindings/reset/mt8195-resets.h>
> > + #include <dt-bindings/thermal/mediatek-lvts.h>
> > +
> > + soc {
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > +
> > + lvts_mcu: thermal-sensor@11278000 {
> > + compatible = "mediatek,mt8195-lvts-mcu";
> > + reg = <0 0x11278000 0 0x1000>;
> > + interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH 0>;
> > + clocks = <&infracfg_ao CLK_INFRA_AO_THERM>;
> > + resets = <&infracfg_ao MT8195_INFRA_RST4_THERM_CTRL_MCU_SWRST>;
> > + nvmem-cells = <&lvts_efuse_data1 &lvts_efuse_data2>;
> > + nvmem-cell-names = "lvts-calib-data-1", "lvts-calib-data-2";
> > + #thermal-sensor-cells = <1>;
> > + };
> > + };
> > +
> > + thermal_zones: thermal-zones {
> > + cpu0-thermal {
> > + polling-delay = <1000>;
> > + polling-delay-passive = <250>;
> > + thermal-sensors = <&lvts_mcu MT8195_MCU_LITTLE_CPU0>;
> > +
> > + trips {
> > + cpu0_alert: trip-alert {
> > + temperature = <85000>;
> > + hysteresis = <2000>;
> > + type = "passive";
> > + };
> > +
> > + cpu0_crit: trip-crit {
> > + temperature = <100000>;
> > + hysteresis = <2000>;
> > + type = "critical";
> > + };
> > + };
> > + };
> > + };
> > diff --git a/include/dt-bindings/thermal/mediatek-lvts.h b/include/dt-bindings/thermal/mediatek-lvts.h
> > new file mode 100644
> > index 000000000000..428a95c18509
> > --- /dev/null
> > +++ b/include/dt-bindings/thermal/mediatek-lvts.h
> > @@ -0,0 +1,19 @@
> > +/* SPDX-License-Identifier: GPL-2.0+ */
>
> Okay with GPL 4? GPL-2.0-only
>
> Dual license please. Consistent with your .dts files.
I will fix this too.
>
> > +/*
> > + * Copyright (c) 2023 MediaTek Inc.
> > + * Author: Balsam CHIHI <bchihi@baylibre.com>
> > + */
> > +
> > +#ifndef __MEDIATEK_LVTS_DT_H
> > +#define __MEDIATEK_LVTS_DT_H
> > +
> > +#define MT8195_MCU_BIG_CPU0 0
> > +#define MT8195_MCU_BIG_CPU1 1
> > +#define MT8195_MCU_BIG_CPU2 2
> > +#define MT8195_MCU_BIG_CPU3 3
> > +#define MT8195_MCU_LITTLE_CPU0 4
> > +#define MT8195_MCU_LITTLE_CPU1 5
> > +#define MT8195_MCU_LITTLE_CPU2 6
> > +#define MT8195_MCU_LITTLE_CPU3 7
> > +
> > +#endif /* __MEDIATEK_LVTS_DT_H */
> > --
> > 2.34.1
> >
Thank you for the review.
Best regards,
Balsam
On 24/01/2023 14:17, bchihi@baylibre.com wrote:
> From: Balsam CHIHI <bchihi@baylibre.com>
>
> Add LVTS thermal controllers dt-binding definition for mt8195.
>
> Signed-off-by: Balsam CHIHI <bchihi@baylibre.com>
> ---
Krzysztof, Rob,
are you ok with these changes ?
> .../thermal/mediatek,lvts-thermal.yaml | 107 ++++++++++++++++++
> include/dt-bindings/thermal/mediatek-lvts.h | 19 ++++
> 2 files changed, 126 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
> create mode 100644 include/dt-bindings/thermal/mediatek-lvts.h
>
> diff --git a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
> new file mode 100644
> index 000000000000..12bfbdd8ff89
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
> @@ -0,0 +1,107 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/mediatek,lvts-thermal.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek SoC Low Voltage Thermal Sensor (LVTS)
> +
> +maintainers:
> + - Balsam CHIHI <bchihi@baylibre.com>
> +
> +description: |
> + LVTS is a thermal management architecture composed of three subsystems,
> + a Sensing device - Thermal Sensing Micro Circuit Unit (TSMCU),
> + a Converter - Low Voltage Thermal Sensor converter (LVTS), and
> + a Digital controller (LVTS_CTRL).
> +
> +properties:
> + compatible:
> + enum:
> + - mediatek,mt8195-lvts-ap
> + - mediatek,mt8195-lvts-mcu
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> + description: LVTS reset for clearing temporary data on AP/MCU.
> +
> + nvmem-cells:
> + minItems: 1
> + items:
> + - description: Calibration eFuse data 1 for LVTS
> + - description: Calibration eFuse data 2 for LVTS
> +
> + nvmem-cell-names:
> + minItems: 1
> + items:
> + - const: lvts-calib-data-1
> + - const: lvts-calib-data-2
> +
> + "#thermal-sensor-cells":
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - resets
> + - nvmem-cells
> + - nvmem-cell-names
> + - "#thermal-sensor-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/clock/mt8195-clk.h>
> + #include <dt-bindings/reset/mt8195-resets.h>
> + #include <dt-bindings/thermal/mediatek-lvts.h>
> +
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + lvts_mcu: thermal-sensor@11278000 {
> + compatible = "mediatek,mt8195-lvts-mcu";
> + reg = <0 0x11278000 0 0x1000>;
> + interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH 0>;
> + clocks = <&infracfg_ao CLK_INFRA_AO_THERM>;
> + resets = <&infracfg_ao MT8195_INFRA_RST4_THERM_CTRL_MCU_SWRST>;
> + nvmem-cells = <&lvts_efuse_data1 &lvts_efuse_data2>;
> + nvmem-cell-names = "lvts-calib-data-1", "lvts-calib-data-2";
> + #thermal-sensor-cells = <1>;
> + };
> + };
> +
> + thermal_zones: thermal-zones {
> + cpu0-thermal {
> + polling-delay = <1000>;
> + polling-delay-passive = <250>;
> + thermal-sensors = <&lvts_mcu MT8195_MCU_LITTLE_CPU0>;
> +
> + trips {
> + cpu0_alert: trip-alert {
> + temperature = <85000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> +
> + cpu0_crit: trip-crit {
> + temperature = <100000>;
> + hysteresis = <2000>;
> + type = "critical";
> + };
> + };
> + };
> + };
> diff --git a/include/dt-bindings/thermal/mediatek-lvts.h b/include/dt-bindings/thermal/mediatek-lvts.h
> new file mode 100644
> index 000000000000..428a95c18509
> --- /dev/null
> +++ b/include/dt-bindings/thermal/mediatek-lvts.h
> @@ -0,0 +1,19 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +/*
> + * Copyright (c) 2023 MediaTek Inc.
> + * Author: Balsam CHIHI <bchihi@baylibre.com>
> + */
> +
> +#ifndef __MEDIATEK_LVTS_DT_H
> +#define __MEDIATEK_LVTS_DT_H
> +
> +#define MT8195_MCU_BIG_CPU0 0
> +#define MT8195_MCU_BIG_CPU1 1
> +#define MT8195_MCU_BIG_CPU2 2
> +#define MT8195_MCU_BIG_CPU3 3
> +#define MT8195_MCU_LITTLE_CPU0 4
> +#define MT8195_MCU_LITTLE_CPU1 5
> +#define MT8195_MCU_LITTLE_CPU2 6
> +#define MT8195_MCU_LITTLE_CPU3 7
> +
> +#endif /* __MEDIATEK_LVTS_DT_H */
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
On Wed, Jan 25, 2023 at 12:14:17PM +0100, Daniel Lezcano wrote: > On 24/01/2023 14:17, bchihi@baylibre.com wrote: > > From: Balsam CHIHI <bchihi@baylibre.com> > > > > Add LVTS thermal controllers dt-binding definition for mt8195. > > > > Signed-off-by: Balsam CHIHI <bchihi@baylibre.com> > > --- > > Krzysztof, Rob, > > are you ok with these changes ? It says v11, but I sure don't recall the 10 other versions... Rob
On 25/01/2023 21:35, Rob Herring wrote: > On Wed, Jan 25, 2023 at 12:14:17PM +0100, Daniel Lezcano wrote: >> On 24/01/2023 14:17, bchihi@baylibre.com wrote: >>> From: Balsam CHIHI <bchihi@baylibre.com> >>> >>> Add LVTS thermal controllers dt-binding definition for mt8195. >>> >>> Signed-off-by: Balsam CHIHI <bchihi@baylibre.com> >>> --- >> >> Krzysztof, Rob, >> >> are you ok with these changes ? > > It says v11, but I sure don't recall the 10 other versions... Ah, yes indeed. I remember Krzysztof told Balsam to fix the recipient list because some maintainers were missing. -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
From: Balsam CHIHI <bchihi@baylibre.com>
Add LVTS thermal controllers dt-binding definition for mt8195.
Signed-off-by: Balsam CHIHI <bchihi@baylibre.com>
---
Changelog:
v12:
- Fixed subject prefix
- Fixed licences GPL-2.0+ to GPL-2.0
- Added dual licenses
v11:
- Rebase on top of "thermal/linux-next" :
base=0d568e144ead70189e7f16066dcb155b78ff9266
- Remove unsupported SoC (mt8192) from dt-binding definition
v10:
- Rebase on top of "thermal/linux-next" : thermal-v6.3-rc1
v9:
- Rebase on top of 6.0.0-rc1
- Update dt-bindings :
- Add "allOf:if:then:"
- Use mt8192 as example (instead of mt8195)
- Fix dt-binding errors
- Fix DTS errors
v8:
- Fix coding style issues
- Rebase on top of next-20220803
- Add multi-instance support :
- Rewrite DT-binding and DTS :
- Add DT-binding and DTS for LVTS_v4 (MT8192 and MT8195)
- One LVTS node for each HW Domain (AP and MCU)
- One SW Instance for each HW Domain
v7:
- Fix coding style issues
- Rewrite dt bindings
- was not accurate
- Use mt8195 for example (instead of mt8192)
- Rename mt6873 to mt8192
- Remove clock name
---
---
.../thermal/mediatek,lvts-thermal.yaml | 107 ++++++++++++++++++
include/dt-bindings/thermal/mediatek-lvts.h | 19 ++++
2 files changed, 126 insertions(+)
create mode 100644 Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
create mode 100644 include/dt-bindings/thermal/mediatek-lvts.h
diff --git a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
new file mode 100644
index 000000000000..12bfbdd8ff89
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
@@ -0,0 +1,107 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/thermal/mediatek,lvts-thermal.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek SoC Low Voltage Thermal Sensor (LVTS)
+
+maintainers:
+ - Balsam CHIHI <bchihi@baylibre.com>
+
+description: |
+ LVTS is a thermal management architecture composed of three subsystems,
+ a Sensing device - Thermal Sensing Micro Circuit Unit (TSMCU),
+ a Converter - Low Voltage Thermal Sensor converter (LVTS), and
+ a Digital controller (LVTS_CTRL).
+
+properties:
+ compatible:
+ enum:
+ - mediatek,mt8195-lvts-ap
+ - mediatek,mt8195-lvts-mcu
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ resets:
+ maxItems: 1
+ description: LVTS reset for clearing temporary data on AP/MCU.
+
+ nvmem-cells:
+ minItems: 1
+ items:
+ - description: Calibration eFuse data 1 for LVTS
+ - description: Calibration eFuse data 2 for LVTS
+
+ nvmem-cell-names:
+ minItems: 1
+ items:
+ - const: lvts-calib-data-1
+ - const: lvts-calib-data-2
+
+ "#thermal-sensor-cells":
+ const: 1
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - resets
+ - nvmem-cells
+ - nvmem-cell-names
+ - "#thermal-sensor-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/clock/mt8195-clk.h>
+ #include <dt-bindings/reset/mt8195-resets.h>
+ #include <dt-bindings/thermal/mediatek-lvts.h>
+
+ soc {
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ lvts_mcu: thermal-sensor@11278000 {
+ compatible = "mediatek,mt8195-lvts-mcu";
+ reg = <0 0x11278000 0 0x1000>;
+ interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH 0>;
+ clocks = <&infracfg_ao CLK_INFRA_AO_THERM>;
+ resets = <&infracfg_ao MT8195_INFRA_RST4_THERM_CTRL_MCU_SWRST>;
+ nvmem-cells = <&lvts_efuse_data1 &lvts_efuse_data2>;
+ nvmem-cell-names = "lvts-calib-data-1", "lvts-calib-data-2";
+ #thermal-sensor-cells = <1>;
+ };
+ };
+
+ thermal_zones: thermal-zones {
+ cpu0-thermal {
+ polling-delay = <1000>;
+ polling-delay-passive = <250>;
+ thermal-sensors = <&lvts_mcu MT8195_MCU_LITTLE_CPU0>;
+
+ trips {
+ cpu0_alert: trip-alert {
+ temperature = <85000>;
+ hysteresis = <2000>;
+ type = "passive";
+ };
+
+ cpu0_crit: trip-crit {
+ temperature = <100000>;
+ hysteresis = <2000>;
+ type = "critical";
+ };
+ };
+ };
+ };
diff --git a/include/dt-bindings/thermal/mediatek-lvts.h b/include/dt-bindings/thermal/mediatek-lvts.h
new file mode 100644
index 000000000000..902d5b1e4f43
--- /dev/null
+++ b/include/dt-bindings/thermal/mediatek-lvts.h
@@ -0,0 +1,19 @@
+/* SPDX-License-Identifier: (GPL-2.0 or MIT) */
+/*
+ * Copyright (c) 2023 MediaTek Inc.
+ * Author: Balsam CHIHI <bchihi@baylibre.com>
+ */
+
+#ifndef __MEDIATEK_LVTS_DT_H
+#define __MEDIATEK_LVTS_DT_H
+
+#define MT8195_MCU_BIG_CPU0 0
+#define MT8195_MCU_BIG_CPU1 1
+#define MT8195_MCU_BIG_CPU2 2
+#define MT8195_MCU_BIG_CPU3 3
+#define MT8195_MCU_LITTLE_CPU0 4
+#define MT8195_MCU_LITTLE_CPU1 5
+#define MT8195_MCU_LITTLE_CPU2 6
+#define MT8195_MCU_LITTLE_CPU3 7
+
+#endif /* __MEDIATEK_LVTS_DT_H */
--
2.34.1On 26/01/2023 17:10, bchihi@baylibre.com wrote: > From: Balsam CHIHI <bchihi@baylibre.com> > > Add LVTS thermal controllers dt-binding definition for mt8195. Subject: drop second/last, redundant "dt-binding definition". The "dt-bindings" prefix is already stating that these are bindings. Plus two comments at the end. > > Signed-off-by: Balsam CHIHI <bchihi@baylibre.com> > --- > Changelog: > v12: > - Fixed subject prefix > - Fixed licences GPL-2.0+ to GPL-2.0 > - Added dual licenses > + }; > diff --git a/include/dt-bindings/thermal/mediatek-lvts.h b/include/dt-bindings/thermal/mediatek-lvts.h > new file mode 100644 > index 000000000000..902d5b1e4f43 > --- /dev/null > +++ b/include/dt-bindings/thermal/mediatek-lvts.h Same filename as bindings. > @@ -0,0 +1,19 @@ > +/* SPDX-License-Identifier: (GPL-2.0 or MIT) */ Although this is correct, any reason why not using exactly the same license as bindings? > +/* > + * Copyright (c) 2023 MediaTek Inc. > + * Author: Balsam CHIHI <bchihi@baylibre.com> > + */ Best regards, Krzysztof
Hi Krzysztof, Thank you for the feedback. On Sat, Jan 28, 2023 at 11:48 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 26/01/2023 17:10, bchihi@baylibre.com wrote: > > From: Balsam CHIHI <bchihi@baylibre.com> > > > > Add LVTS thermal controllers dt-binding definition for mt8195. > > Subject: drop second/last, redundant "dt-binding definition". The > "dt-bindings" prefix is already stating that these are bindings. fixed. The patch title has been fixed as you suggested : "dt-bindings: thermal: mediatek: Add LVTS thermal controllers" > > Plus two comments at the end. > > > > > Signed-off-by: Balsam CHIHI <bchihi@baylibre.com> > > --- > > Changelog: > > v12: > > - Fixed subject prefix > > - Fixed licences GPL-2.0+ to GPL-2.0 > > - Added dual licenses > > > > + }; > > diff --git a/include/dt-bindings/thermal/mediatek-lvts.h b/include/dt-bindings/thermal/mediatek-lvts.h > > new file mode 100644 > > index 000000000000..902d5b1e4f43 > > --- /dev/null > > +++ b/include/dt-bindings/thermal/mediatek-lvts.h > > Same filename as bindings. fixed. rename : include/dt-bindings/thermal/mediatek-lvts.h => include/dt-bindings/thermal/mediatek-lvts-thermal.h > > > @@ -0,0 +1,19 @@ > > +/* SPDX-License-Identifier: (GPL-2.0 or MIT) */ > > Although this is correct, any reason why not using exactly the same > license as bindings? fixed. both files are now using the same license : "SPDX-License-Identifier: (GPL-2.0 or MIT)" > > > +/* > > + * Copyright (c) 2023 MediaTek Inc. > > + * Author: Balsam CHIHI <bchihi@baylibre.com> > > + */ > > Best regards, > Krzysztof > I'll send the changes soon. Best regards, Balsam
On 30/01/2023 11:40, Balsam CHIHI wrote: >>> diff --git a/include/dt-bindings/thermal/mediatek-lvts.h b/include/dt-bindings/thermal/mediatek-lvts.h >>> new file mode 100644 >>> index 000000000000..902d5b1e4f43 >>> --- /dev/null >>> +++ b/include/dt-bindings/thermal/mediatek-lvts.h >> >> Same filename as bindings. > > fixed. > rename : > include/dt-bindings/thermal/mediatek-lvts.h => > include/dt-bindings/thermal/mediatek-lvts-thermal.h Missing coma, so mediatek,lvts-thermal.h Best regards, Krzysztof
On 31/01/2023 17:53, Krzysztof Kozlowski wrote: > On 30/01/2023 11:40, Balsam CHIHI wrote: >>>> diff --git a/include/dt-bindings/thermal/mediatek-lvts.h b/include/dt-bindings/thermal/mediatek-lvts.h >>>> new file mode 100644 >>>> index 000000000000..902d5b1e4f43 >>>> --- /dev/null >>>> +++ b/include/dt-bindings/thermal/mediatek-lvts.h >>> >>> Same filename as bindings. >> >> fixed. >> rename : >> include/dt-bindings/thermal/mediatek-lvts.h => >> include/dt-bindings/thermal/mediatek-lvts-thermal.h > > Missing coma, so mediatek,lvts-thermal.h Yeah, actually Balsam resent a new version but numbered v3 taking into account your comments. The versioning is becoming a bit messy now but if you are ok with the changes I'll pick the patch as is so we can go forward for this series. -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
On 30/01/2023 11:40, Balsam CHIHI wrote: > Hi Krzysztof, > > Thank you for the feedback. > > On Sat, Jan 28, 2023 at 11:48 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 26/01/2023 17:10, bchihi@baylibre.com wrote: >>> From: Balsam CHIHI <bchihi@baylibre.com> >>> >>> Add LVTS thermal controllers dt-binding definition for mt8195. >> >> Subject: drop second/last, redundant "dt-binding definition". The >> "dt-bindings" prefix is already stating that these are bindings. > > fixed. > The patch title has been fixed as you suggested : > "dt-bindings: thermal: mediatek: Add LVTS thermal controllers" > >> >> Plus two comments at the end. >> >>> >>> Signed-off-by: Balsam CHIHI <bchihi@baylibre.com> >>> --- >>> Changelog: >>> v12: >>> - Fixed subject prefix >>> - Fixed licences GPL-2.0+ to GPL-2.0 >>> - Added dual licenses >> >> >>> + }; >>> diff --git a/include/dt-bindings/thermal/mediatek-lvts.h b/include/dt-bindings/thermal/mediatek-lvts.h >>> new file mode 100644 >>> index 000000000000..902d5b1e4f43 >>> --- /dev/null >>> +++ b/include/dt-bindings/thermal/mediatek-lvts.h >> >> Same filename as bindings. > > fixed. > rename : > include/dt-bindings/thermal/mediatek-lvts.h => > include/dt-bindings/thermal/mediatek-lvts-thermal.h > I think it should be include/dt-bindings/thermal/mediatek,lvts-thermal.yaml Regards, Matthias >> >>> @@ -0,0 +1,19 @@ >>> +/* SPDX-License-Identifier: (GPL-2.0 or MIT) */ >> >> Although this is correct, any reason why not using exactly the same >> license as bindings? > > fixed. > both files are now using the same license : > "SPDX-License-Identifier: (GPL-2.0 or MIT)" > >> >>> +/* >>> + * Copyright (c) 2023 MediaTek Inc. >>> + * Author: Balsam CHIHI <bchihi@baylibre.com> >>> + */ >> >> Best regards, >> Krzysztof >> > > I'll send the changes soon. > > Best regards, > Balsam
Hi Matthias,
On Mon, Jan 30, 2023 at 12:18 PM Matthias Brugger
<matthias.bgg@gmail.com> wrote:
>
>
>
> On 30/01/2023 11:40, Balsam CHIHI wrote:
> > Hi Krzysztof,
> >
> > Thank you for the feedback.
> >
> > On Sat, Jan 28, 2023 at 11:48 AM Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >>
> >> On 26/01/2023 17:10, bchihi@baylibre.com wrote:
> >>> From: Balsam CHIHI <bchihi@baylibre.com>
> >>>
> >>> Add LVTS thermal controllers dt-binding definition for mt8195.
> >>
> >> Subject: drop second/last, redundant "dt-binding definition". The
> >> "dt-bindings" prefix is already stating that these are bindings.
> >
> > fixed.
> > The patch title has been fixed as you suggested :
> > "dt-bindings: thermal: mediatek: Add LVTS thermal controllers"
> >
> >>
> >> Plus two comments at the end.
> >>
> >>>
> >>> Signed-off-by: Balsam CHIHI <bchihi@baylibre.com>
> >>> ---
> >>> Changelog:
> >>> v12:
> >>> - Fixed subject prefix
> >>> - Fixed licences GPL-2.0+ to GPL-2.0
> >>> - Added dual licenses
> >>
> >>
> >>> + };
> >>> diff --git a/include/dt-bindings/thermal/mediatek-lvts.h b/include/dt-bindings/thermal/mediatek-lvts.h
> >>> new file mode 100644
> >>> index 000000000000..902d5b1e4f43
> >>> --- /dev/null
> >>> +++ b/include/dt-bindings/thermal/mediatek-lvts.h
> >>
> >> Same filename as bindings.
> >
> > fixed.
> > rename :
> > include/dt-bindings/thermal/mediatek-lvts.h =>
> > include/dt-bindings/thermal/mediatek-lvts-thermal.h
> >
>
> I think it should be
> include/dt-bindings/thermal/mediatek,lvts-thermal.yaml
OK,
I will change it like that.
(".h" and not ".yaml" I believe (just to be sure).).
>
> Regards,
> Matthias
>
> >>
> >>> @@ -0,0 +1,19 @@
> >>> +/* SPDX-License-Identifier: (GPL-2.0 or MIT) */
> >>
> >> Although this is correct, any reason why not using exactly the same
> >> license as bindings?
> >
> > fixed.
> > both files are now using the same license :
> > "SPDX-License-Identifier: (GPL-2.0 or MIT)"
> >
> >>
> >>> +/*
> >>> + * Copyright (c) 2023 MediaTek Inc.
> >>> + * Author: Balsam CHIHI <bchihi@baylibre.com>
> >>> + */
> >>
> >> Best regards,
> >> Krzysztof
> >>
> >
> > I'll send the changes soon.
> >
> > Best regards,
> > Balsam
Best regards,
Balsam
On 30/01/2023 13:19, Balsam CHIHI wrote:
> Hi Matthias,
>
> On Mon, Jan 30, 2023 at 12:18 PM Matthias Brugger
> <matthias.bgg@gmail.com> wrote:
>>
>>
>>
>> On 30/01/2023 11:40, Balsam CHIHI wrote:
>>> Hi Krzysztof,
>>>
>>> Thank you for the feedback.
>>>
>>> On Sat, Jan 28, 2023 at 11:48 AM Krzysztof Kozlowski
>>> <krzysztof.kozlowski@linaro.org> wrote:
>>>>
>>>> On 26/01/2023 17:10, bchihi@baylibre.com wrote:
>>>>> From: Balsam CHIHI <bchihi@baylibre.com>
>>>>>
>>>>> Add LVTS thermal controllers dt-binding definition for mt8195.
>>>>
>>>> Subject: drop second/last, redundant "dt-binding definition". The
>>>> "dt-bindings" prefix is already stating that these are bindings.
>>>
>>> fixed.
>>> The patch title has been fixed as you suggested :
>>> "dt-bindings: thermal: mediatek: Add LVTS thermal controllers"
>>>
>>>>
>>>> Plus two comments at the end.
>>>>
>>>>>
>>>>> Signed-off-by: Balsam CHIHI <bchihi@baylibre.com>
>>>>> ---
>>>>> Changelog:
>>>>> v12:
>>>>> - Fixed subject prefix
>>>>> - Fixed licences GPL-2.0+ to GPL-2.0
>>>>> - Added dual licenses
>>>>
>>>>
>>>>> + };
>>>>> diff --git a/include/dt-bindings/thermal/mediatek-lvts.h b/include/dt-bindings/thermal/mediatek-lvts.h
>>>>> new file mode 100644
>>>>> index 000000000000..902d5b1e4f43
>>>>> --- /dev/null
>>>>> +++ b/include/dt-bindings/thermal/mediatek-lvts.h
>>>>
>>>> Same filename as bindings.
>>>
>>> fixed.
>>> rename :
>>> include/dt-bindings/thermal/mediatek-lvts.h =>
>>> include/dt-bindings/thermal/mediatek-lvts-thermal.h
>>>
>>
>> I think it should be
>> include/dt-bindings/thermal/mediatek,lvts-thermal.yaml
>
> OK,
> I will change it like that.
> (".h" and not ".yaml" I believe (just to be sure).).
>
Yes sure, .h. Sorry for the confusion.
Regards,
Matthias
>>
>> Regards,
>> Matthias
>>
>>>>
>>>>> @@ -0,0 +1,19 @@
>>>>> +/* SPDX-License-Identifier: (GPL-2.0 or MIT) */
>>>>
>>>> Although this is correct, any reason why not using exactly the same
>>>> license as bindings?
>>>
>>> fixed.
>>> both files are now using the same license :
>>> "SPDX-License-Identifier: (GPL-2.0 or MIT)"
>>>
>>>>
>>>>> +/*
>>>>> + * Copyright (c) 2023 MediaTek Inc.
>>>>> + * Author: Balsam CHIHI <bchihi@baylibre.com>
>>>>> + */
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>>
>>>
>>> I'll send the changes soon.
>>>
>>> Best regards,
>>> Balsam
>
> Best regards,
> Balsam
Hi Rob,
I think Balsam took into account your comments. Is it fine for you ?
On 26/01/2023 17:10, bchihi@baylibre.com wrote:
> From: Balsam CHIHI <bchihi@baylibre.com>
>
> Add LVTS thermal controllers dt-binding definition for mt8195.
>
> Signed-off-by: Balsam CHIHI <bchihi@baylibre.com>
> ---
> Changelog:
> v12:
> - Fixed subject prefix
> - Fixed licences GPL-2.0+ to GPL-2.0
> - Added dual licenses
> v11:
> - Rebase on top of "thermal/linux-next" :
> base=0d568e144ead70189e7f16066dcb155b78ff9266
> - Remove unsupported SoC (mt8192) from dt-binding definition
> v10:
> - Rebase on top of "thermal/linux-next" : thermal-v6.3-rc1
> v9:
> - Rebase on top of 6.0.0-rc1
> - Update dt-bindings :
> - Add "allOf:if:then:"
> - Use mt8192 as example (instead of mt8195)
> - Fix dt-binding errors
> - Fix DTS errors
> v8:
> - Fix coding style issues
> - Rebase on top of next-20220803
> - Add multi-instance support :
> - Rewrite DT-binding and DTS :
> - Add DT-binding and DTS for LVTS_v4 (MT8192 and MT8195)
> - One LVTS node for each HW Domain (AP and MCU)
> - One SW Instance for each HW Domain
> v7:
> - Fix coding style issues
> - Rewrite dt bindings
> - was not accurate
> - Use mt8195 for example (instead of mt8192)
> - Rename mt6873 to mt8192
> - Remove clock name
> ---
> ---
> .../thermal/mediatek,lvts-thermal.yaml | 107 ++++++++++++++++++
> include/dt-bindings/thermal/mediatek-lvts.h | 19 ++++
> 2 files changed, 126 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
> create mode 100644 include/dt-bindings/thermal/mediatek-lvts.h
>
> diff --git a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
> new file mode 100644
> index 000000000000..12bfbdd8ff89
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
> @@ -0,0 +1,107 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/mediatek,lvts-thermal.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek SoC Low Voltage Thermal Sensor (LVTS)
> +
> +maintainers:
> + - Balsam CHIHI <bchihi@baylibre.com>
> +
> +description: |
> + LVTS is a thermal management architecture composed of three subsystems,
> + a Sensing device - Thermal Sensing Micro Circuit Unit (TSMCU),
> + a Converter - Low Voltage Thermal Sensor converter (LVTS), and
> + a Digital controller (LVTS_CTRL).
> +
> +properties:
> + compatible:
> + enum:
> + - mediatek,mt8195-lvts-ap
> + - mediatek,mt8195-lvts-mcu
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> + description: LVTS reset for clearing temporary data on AP/MCU.
> +
> + nvmem-cells:
> + minItems: 1
> + items:
> + - description: Calibration eFuse data 1 for LVTS
> + - description: Calibration eFuse data 2 for LVTS
> +
> + nvmem-cell-names:
> + minItems: 1
> + items:
> + - const: lvts-calib-data-1
> + - const: lvts-calib-data-2
> +
> + "#thermal-sensor-cells":
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - resets
> + - nvmem-cells
> + - nvmem-cell-names
> + - "#thermal-sensor-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/clock/mt8195-clk.h>
> + #include <dt-bindings/reset/mt8195-resets.h>
> + #include <dt-bindings/thermal/mediatek-lvts.h>
> +
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + lvts_mcu: thermal-sensor@11278000 {
> + compatible = "mediatek,mt8195-lvts-mcu";
> + reg = <0 0x11278000 0 0x1000>;
> + interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH 0>;
> + clocks = <&infracfg_ao CLK_INFRA_AO_THERM>;
> + resets = <&infracfg_ao MT8195_INFRA_RST4_THERM_CTRL_MCU_SWRST>;
> + nvmem-cells = <&lvts_efuse_data1 &lvts_efuse_data2>;
> + nvmem-cell-names = "lvts-calib-data-1", "lvts-calib-data-2";
> + #thermal-sensor-cells = <1>;
> + };
> + };
> +
> + thermal_zones: thermal-zones {
> + cpu0-thermal {
> + polling-delay = <1000>;
> + polling-delay-passive = <250>;
> + thermal-sensors = <&lvts_mcu MT8195_MCU_LITTLE_CPU0>;
> +
> + trips {
> + cpu0_alert: trip-alert {
> + temperature = <85000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> +
> + cpu0_crit: trip-crit {
> + temperature = <100000>;
> + hysteresis = <2000>;
> + type = "critical";
> + };
> + };
> + };
> + };
> diff --git a/include/dt-bindings/thermal/mediatek-lvts.h b/include/dt-bindings/thermal/mediatek-lvts.h
> new file mode 100644
> index 000000000000..902d5b1e4f43
> --- /dev/null
> +++ b/include/dt-bindings/thermal/mediatek-lvts.h
> @@ -0,0 +1,19 @@
> +/* SPDX-License-Identifier: (GPL-2.0 or MIT) */
> +/*
> + * Copyright (c) 2023 MediaTek Inc.
> + * Author: Balsam CHIHI <bchihi@baylibre.com>
> + */
> +
> +#ifndef __MEDIATEK_LVTS_DT_H
> +#define __MEDIATEK_LVTS_DT_H
> +
> +#define MT8195_MCU_BIG_CPU0 0
> +#define MT8195_MCU_BIG_CPU1 1
> +#define MT8195_MCU_BIG_CPU2 2
> +#define MT8195_MCU_BIG_CPU3 3
> +#define MT8195_MCU_LITTLE_CPU0 4
> +#define MT8195_MCU_LITTLE_CPU1 5
> +#define MT8195_MCU_LITTLE_CPU2 6
> +#define MT8195_MCU_LITTLE_CPU3 7
> +
> +#endif /* __MEDIATEK_LVTS_DT_H */
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
On 27/01/2023 23:10, Daniel Lezcano wrote: > > Hi Rob, > > I think Balsam took into account your comments. Is it fine for you ? > The patchset was not sent to us at all, so it is the second version we see. Therefore it's not v12 for us. It's v2 and it still needs fixes. I replied with minor comments (which could be fixed during applying) and the license concern (which you rather cannot change while applying). Best regards, Krzysztof
Hi Krzysztof, On Sat, Jan 28, 2023 at 11:50 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 27/01/2023 23:10, Daniel Lezcano wrote: > > > > Hi Rob, > > > > I think Balsam took into account your comments. Is it fine for you ? > > > > The patchset was not sent to us at all, so it is the second version we > see. Therefore it's not v12 for us. It's v2 and it still needs fixes. > > I replied with minor comments (which could be fixed during applying) and > the license concern (which you rather cannot change while applying). I apologize for forgetting to add some email addresses while sending previous versions. The changes you asked in your preview comment are taken in account and ready to be sent. Please let me know what version number should the patch have. > > Best regards, > Krzysztof > Best regards, Balsam
From: Balsam CHIHI <bchihi@baylibre.com>
Replace memcpy 2 bytes by sizeof(int) bytes of LVTS calibration data.
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Balsam CHIHI <bchihi@baylibre.com>
---
Rebased on top of thermal/linux-next
base-commit: 6828e402d06f7c574430b61c05db784cd847b19f
Original email :
Hello Balsam CHIHI,
The patch f5f633b18234: "thermal/drivers/mediatek: Add the Low
Voltage Thermal Sensor driver" from Feb 9, 2023, leads to the
following Smatch static checker warning:
drivers/thermal/mediatek/lvts_thermal.c:562 lvts_calibration_init()
warn: not copying enough bytes for '&lvts_ctrl->calibration[i]' (4 vs 2 bytes)
drivers/thermal/mediatek/lvts_thermal.c
555 static int lvts_calibration_init(struct device *dev, struct lvts_ctrl *lvts_ctrl,
556 const struct lvts_ctrl_data *lvts_ctrl_data,
557 u8 *efuse_calibration)
558 {
559 int i;
560
561 for (i = 0; i < lvts_ctrl_data->num_lvts_sensor; i++)
--> 562 memcpy(&lvts_ctrl->calibration[i],
563 efuse_calibration + lvts_ctrl_data->cal_offset[i], 2);
^
This is copying an array of known ints to a u32 array. It should copy
sizeof(int) instead of 2. It only works because the data you're on
little endian and the data is small.
564
565 return 0;
566 }
regards,
dan carpenter
---
---
drivers/thermal/mediatek/lvts_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c
index ddfdcbcf6d86..b505c6b49031 100644
--- a/drivers/thermal/mediatek/lvts_thermal.c
+++ b/drivers/thermal/mediatek/lvts_thermal.c
@@ -575,7 +575,7 @@ static int lvts_calibration_init(struct device *dev, struct lvts_ctrl *lvts_ctrl
for (i = 0; i < lvts_ctrl_data->num_lvts_sensor; i++)
memcpy(&lvts_ctrl->calibration[i],
- efuse_calibration + lvts_ctrl_data->cal_offset[i], 2);
+ efuse_calibration + lvts_ctrl_data->cal_offset[i], sizeof(int));
return 0;
}
base-commit: 6828e402d06f7c574430b61c05db784cd847b19f
prerequisite-patch-id: 73be949bd16979769e5b94905b244dcee4a8f687
prerequisite-patch-id: d23d83a946e5b876ef01a717fd51b07df1fa08dd
prerequisite-patch-id: d67f2455eef1c4a9ecc460dbf3c2e3ad47d213ec
prerequisite-patch-id: 9076e9b3bd3cc411b7b80344211364db5f0cca17
prerequisite-patch-id: e220d6ae26786f524c249588433f02e5f5f906ad
prerequisite-patch-id: b407d2998e57678952128b3a4bac92a379132b09
prerequisite-patch-id: fbb9212ce8c3530da17d213f56fa334ce4fa1b2b
prerequisite-patch-id: 5db9eed2659028cf4419f2de3d093af7df6c2dad
prerequisite-patch-id: a83c00c628605d1c8fbe1d97074f9f28efb1bcfc
prerequisite-patch-id: 56a245620a4f8238cf1ba3844dc348de3db33845
prerequisite-patch-id: 7df24b0bf11129ddd3356eacf192cc3fdb2bcded
prerequisite-patch-id: 3213ca70cb5b26d54a7137ff40ca8cd2a795c414
prerequisite-patch-id: 6c2202e85215d1c7e8ab16a6b85922e994c68d9b
--
2.34.1Il 07/03/23 14:42, bchihi@baylibre.com ha scritto: > From: Balsam CHIHI <bchihi@baylibre.com> > > Replace memcpy 2 bytes by sizeof(int) bytes of LVTS calibration data. sizeof(int) is architecture dependant... please use a fixed size type instead. Also, shouldn't this be u16?! Regards, Angelo
On Wed, Mar 08, 2023 at 10:10:34AM +0100, AngeloGioacchino Del Regno wrote: > Il 07/03/23 14:42, bchihi@baylibre.com ha scritto: > > From: Balsam CHIHI <bchihi@baylibre.com> > > > > Replace memcpy 2 bytes by sizeof(int) bytes of LVTS calibration data. > > sizeof(int) is architecture dependant... > On Linux sizeof(int) is always 4. I'm just so confused what you are talking about. Are you thinking about sizeof(long)? Are you thinking about CPUs from the 1970s? Linux wasn't invented until the 90s so the old CPUs were already in museums at that point. > please use a fixed size type instead. This is an unusual style opinion that I have not heard before. Hopefully, you just got ints and longs confused so we can move on without discussing it too much. We're copying an int so sizeof(int) is obviously correct. It's hard to know how to respond. > Also, shouldn't this be u16?! What? Why would you think that? regards, dan carpenter
From: Balsam CHIHI <bchihi@baylibre.com>
Add LVTS thermal controllers dt-binding definition for mt8195.
Signed-off-by: Balsam CHIHI <bchihi@baylibre.com>
---
Changelog:
v3:
- Fixed subject prefix
- Fixed licenses GPL-2.0-only OR BSD-2-Clause
to GPL-2.0 OR MIT (to match DT)
- Fixed matching dt-binding file names
v2:
- Fixed subject prefix
- Fixed licenses GPL-2.0+ to GPL-2.0
- Added dual licenses
---
---
.../thermal/mediatek,lvts-thermal.yaml | 107 ++++++++++++++++++
.../thermal/mediatek,lvts-thermal.h | 19 ++++
2 files changed, 126 insertions(+)
create mode 100644 Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
create mode 100644 include/dt-bindings/thermal/mediatek,lvts-thermal.h
diff --git a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
new file mode 100644
index 000000000000..5fa5c7a1a417
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
@@ -0,0 +1,107 @@
+# SPDX-License-Identifier: (GPL-2.0 OR MIT)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/thermal/mediatek,lvts-thermal.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek SoC Low Voltage Thermal Sensor (LVTS)
+
+maintainers:
+ - Balsam CHIHI <bchihi@baylibre.com>
+
+description: |
+ LVTS is a thermal management architecture composed of three subsystems,
+ a Sensing device - Thermal Sensing Micro Circuit Unit (TSMCU),
+ a Converter - Low Voltage Thermal Sensor converter (LVTS), and
+ a Digital controller (LVTS_CTRL).
+
+properties:
+ compatible:
+ enum:
+ - mediatek,mt8195-lvts-ap
+ - mediatek,mt8195-lvts-mcu
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ resets:
+ maxItems: 1
+ description: LVTS reset for clearing temporary data on AP/MCU.
+
+ nvmem-cells:
+ minItems: 1
+ items:
+ - description: Calibration eFuse data 1 for LVTS
+ - description: Calibration eFuse data 2 for LVTS
+
+ nvmem-cell-names:
+ minItems: 1
+ items:
+ - const: lvts-calib-data-1
+ - const: lvts-calib-data-2
+
+ "#thermal-sensor-cells":
+ const: 1
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - resets
+ - nvmem-cells
+ - nvmem-cell-names
+ - "#thermal-sensor-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/clock/mt8195-clk.h>
+ #include <dt-bindings/reset/mt8195-resets.h>
+ #include <dt-bindings/thermal/mediatek,lvts-thermal.h>
+
+ soc {
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ lvts_mcu: thermal-sensor@11278000 {
+ compatible = "mediatek,mt8195-lvts-mcu";
+ reg = <0 0x11278000 0 0x1000>;
+ interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH 0>;
+ clocks = <&infracfg_ao CLK_INFRA_AO_THERM>;
+ resets = <&infracfg_ao MT8195_INFRA_RST4_THERM_CTRL_MCU_SWRST>;
+ nvmem-cells = <&lvts_efuse_data1 &lvts_efuse_data2>;
+ nvmem-cell-names = "lvts-calib-data-1", "lvts-calib-data-2";
+ #thermal-sensor-cells = <1>;
+ };
+ };
+
+ thermal_zones: thermal-zones {
+ cpu0-thermal {
+ polling-delay = <1000>;
+ polling-delay-passive = <250>;
+ thermal-sensors = <&lvts_mcu MT8195_MCU_LITTLE_CPU0>;
+
+ trips {
+ cpu0_alert: trip-alert {
+ temperature = <85000>;
+ hysteresis = <2000>;
+ type = "passive";
+ };
+
+ cpu0_crit: trip-crit {
+ temperature = <100000>;
+ hysteresis = <2000>;
+ type = "critical";
+ };
+ };
+ };
+ };
diff --git a/include/dt-bindings/thermal/mediatek,lvts-thermal.h b/include/dt-bindings/thermal/mediatek,lvts-thermal.h
new file mode 100644
index 000000000000..ca1ef29a8fee
--- /dev/null
+++ b/include/dt-bindings/thermal/mediatek,lvts-thermal.h
@@ -0,0 +1,19 @@
+/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */
+/*
+ * Copyright (c) 2023 MediaTek Inc.
+ * Author: Balsam CHIHI <bchihi@baylibre.com>
+ */
+
+#ifndef __MEDIATEK_LVTS_DT_H
+#define __MEDIATEK_LVTS_DT_H
+
+#define MT8195_MCU_BIG_CPU0 0
+#define MT8195_MCU_BIG_CPU1 1
+#define MT8195_MCU_BIG_CPU2 2
+#define MT8195_MCU_BIG_CPU3 3
+#define MT8195_MCU_LITTLE_CPU0 4
+#define MT8195_MCU_LITTLE_CPU1 5
+#define MT8195_MCU_LITTLE_CPU2 6
+#define MT8195_MCU_LITTLE_CPU3 7
+
+#endif /* __MEDIATEK_LVTS_DT_H */
--
2.34.1On 31/01/2023 15:04, bchihi@baylibre.com wrote:
> From: Balsam CHIHI <bchihi@baylibre.com>
>
> Add LVTS thermal controllers dt-binding definition for mt8195.
>
> Signed-off-by: Balsam CHIHI <bchihi@baylibre.com>
> ---
> Changelog:
> v3:
> - Fixed subject prefix
> - Fixed licenses GPL-2.0-only OR BSD-2-Clause
> to GPL-2.0 OR MIT (to match DT)
> - Fixed matching dt-binding file names
If this is v3 with only one patch, where is the driver or DTS using
these bindings? Please link it. It's unusual to see only bindings,
without the users.
> v2:
> - Fixed subject prefix
> - Fixed licenses GPL-2.0+ to GPL-2.0
> - Added dual licenses
Is there a reason to make our review more difficult and keep versions
broken, threads attached to some other threads?
------------
Grabbing thread from
lore.kernel.org/all/20230131140439.600164-1-bchihi%40baylibre.com/t.mbox.gz
Checking for newer revisions on https://lore.kernel.org/all/
Analyzing 38 messages in the thread
Will use the latest revision: v12
You can pick other revisions using the -vN flag
Checking attestation on all messages, may take a moment...
---
✓ [PATCH v12] thermal: drivers: mediatek: Add the Low Voltage Thermal
Sensor driver
✓ Signed: DKIM/baylibre-com.20210112.gappssmtp.com (From:
bchihi@baylibre.com)
+ Link:
https://lore.kernel.org/r/20230131153816.21709-1-bchihi@baylibre.com
✓ [PATCH v12 2/6] dt-bindings: thermal: mediatek: Add LVTS thermal
controllers dt-binding definition
✓ Signed: DKIM/baylibre-com.20210112.gappssmtp.com (From:
bchihi@baylibre.com)
+ Link:
https://lore.kernel.org/r/20230126161048.94089-1-bchihi@baylibre.com
ERROR: missing [3/1]!
ERROR: missing [4/1]!
ERROR: missing [5/1]!
ERROR: missing [6/1]!
--------
b4 diff '<20230131140439.600164-1-bchihi@baylibre.com>'
Checking for older revisions on https://lore.kernel.org/all/
---
Analyzing 38 messages in the thread
Assuming new revision: v4 ([PATCH v12] thermal: drivers: mediatek: Add
the Low Voltage Thermal Sensor driver)
Preparing fake-am for v3: dt-bindings: thermal: mediatek: Add LVTS
thermal controllers
range: 291580cde5f6..de7fe5e0293a
Preparing fake-am for v12: arm64: dts: mediatek: mt8195: Add thermal
zones and thermal nodes
ERROR: Could not find matching blob for
arch/arm64/boot/dts/mediatek/mt8195.dtsi (09df105f4606)
If you know on which tree this patchset is based,
add it as a remote and perform "git remote update"
in order to fetch the missing objects.
---
Could not create fake-am range for upper series v12
> ---
> ---
> .../thermal/mediatek,lvts-thermal.yaml | 107 ++++++++++++++++++
> .../thermal/mediatek,lvts-thermal.h | 19 ++++
> 2 files changed, 126 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
> create mode 100644 include/dt-bindings/thermal/mediatek,lvts-thermal.h
>
> diff --git a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
> new file mode 100644
> index 000000000000..5fa5c7a1a417
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
> @@ -0,0 +1,107 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR MIT)
WARNING: DT binding documents should be licensed (GPL-2.0-only OR
BSD-2-Clause)
#24: FILE:
Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml:1:
+# SPDX-License-Identifier: (GPL-2.0 OR MIT)
I asked you to use the binding license for header file. Then you changed
binding license... why? Why do you need other SPDX text? Why do you need
MIT?
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/mediatek,lvts-thermal.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek SoC Low Voltage Thermal Sensor (LVTS)
> +
> +maintainers:
> + - Balsam CHIHI <bchihi@baylibre.com>
> +
> +description: |
> + LVTS is a thermal management architecture composed of three subsystems,
> + a Sensing device - Thermal Sensing Micro Circuit Unit (TSMCU),
> + a Converter - Low Voltage Thermal Sensor converter (LVTS), and
> + a Digital controller (LVTS_CTRL).
> +
> +properties:
> + compatible:
> + enum:
> + - mediatek,mt8195-lvts-ap
> + - mediatek,mt8195-lvts-mcu
What about other devices? You called the file name as generic for all
Mediatek SoCs, so why only one SoC is here? Is there going to be more?
If yes, why they cannot be added now?
Best regards,
Krzysztof
Hi Krzysztof On Wed, Feb 1, 2023 at 8:46 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 31/01/2023 15:04, bchihi@baylibre.com wrote: > > From: Balsam CHIHI <bchihi@baylibre.com> > > > > Add LVTS thermal controllers dt-binding definition for mt8195. > > > > Signed-off-by: Balsam CHIHI <bchihi@baylibre.com> > > --- > > Changelog: > > v3: > > - Fixed subject prefix > > - Fixed licenses GPL-2.0-only OR BSD-2-Clause > > to GPL-2.0 OR MIT (to match DT) > > - Fixed matching dt-binding file names > > If this is v3 with only one patch, where is the driver or DTS using > these bindings? Please link it. It's unusual to see only bindings, > without the users. sorry, I'll be careful next time. and I will take into account the new change requests in the next full version of the series. I apologize for the mess. > > > v2: > > - Fixed subject prefix > > - Fixed licenses GPL-2.0+ to GPL-2.0 > > - Added dual licenses > > Is there a reason to make our review more difficult and keep versions > broken, threads attached to some other threads? sorry again. > > ------------ > > Grabbing thread from > lore.kernel.org/all/20230131140439.600164-1-bchihi%40baylibre.com/t.mbox.gz > Checking for newer revisions on https://lore.kernel.org/all/ > Analyzing 38 messages in the thread > Will use the latest revision: v12 > You can pick other revisions using the -vN flag > Checking attestation on all messages, may take a moment... > --- > ✓ [PATCH v12] thermal: drivers: mediatek: Add the Low Voltage Thermal > Sensor driver > ✓ Signed: DKIM/baylibre-com.20210112.gappssmtp.com (From: > bchihi@baylibre.com) > + Link: > https://lore.kernel.org/r/20230131153816.21709-1-bchihi@baylibre.com > ✓ [PATCH v12 2/6] dt-bindings: thermal: mediatek: Add LVTS thermal > controllers dt-binding definition > ✓ Signed: DKIM/baylibre-com.20210112.gappssmtp.com (From: > bchihi@baylibre.com) > + Link: > https://lore.kernel.org/r/20230126161048.94089-1-bchihi@baylibre.com > ERROR: missing [3/1]! > ERROR: missing [4/1]! > ERROR: missing [5/1]! > ERROR: missing [6/1]! > > -------- > > b4 diff '<20230131140439.600164-1-bchihi@baylibre.com>' > Checking for older revisions on https://lore.kernel.org/all/ > --- > Analyzing 38 messages in the thread > Assuming new revision: v4 ([PATCH v12] thermal: drivers: mediatek: Add > the Low Voltage Thermal Sensor driver) > Preparing fake-am for v3: dt-bindings: thermal: mediatek: Add LVTS > thermal controllers > range: 291580cde5f6..de7fe5e0293a > Preparing fake-am for v12: arm64: dts: mediatek: mt8195: Add thermal > zones and thermal nodes > ERROR: Could not find matching blob for > arch/arm64/boot/dts/mediatek/mt8195.dtsi (09df105f4606) > If you know on which tree this patchset is based, > add it as a remote and perform "git remote update" > in order to fetch the missing objects. > --- > Could not create fake-am range for upper series v12 > > > > --- > > --- > > .../thermal/mediatek,lvts-thermal.yaml | 107 ++++++++++++++++++ > > .../thermal/mediatek,lvts-thermal.h | 19 ++++ > > 2 files changed, 126 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml > > create mode 100644 include/dt-bindings/thermal/mediatek,lvts-thermal.h > > > > diff --git a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml > > new file mode 100644 > > index 000000000000..5fa5c7a1a417 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml > > @@ -0,0 +1,107 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR MIT) > > WARNING: DT binding documents should be licensed (GPL-2.0-only OR > BSD-2-Clause) > #24: FILE: > Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml:1: > +# SPDX-License-Identifier: (GPL-2.0 OR MIT) > > I asked you to use the binding license for header file. Then you changed > binding license... why? Why do you need other SPDX text? Why do you need > MIT? I will put it back "GPL-2.0-only OR BSD-2-Clause" in the binding and do the same for the header. > > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/thermal/mediatek,lvts-thermal.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: MediaTek SoC Low Voltage Thermal Sensor (LVTS) > > + > > +maintainers: > > + - Balsam CHIHI <bchihi@baylibre.com> > > + > > +description: | > > + LVTS is a thermal management architecture composed of three subsystems, > > + a Sensing device - Thermal Sensing Micro Circuit Unit (TSMCU), > > + a Converter - Low Voltage Thermal Sensor converter (LVTS), and > > + a Digital controller (LVTS_CTRL). > > + > > +properties: > > + compatible: > > + enum: > > + - mediatek,mt8195-lvts-ap > > + - mediatek,mt8195-lvts-mcu > > What about other devices? You called the file name as generic for all > Mediatek SoCs, so why only one SoC is here? Is there going to be more? > If yes, why they cannot be added now? Yes, there is another MTK SoC mt8192 that supports LVTS, I was asked in v10 of the series to remove the unimplemented SoC. It will be added later with the driver that supports it. just let me know if you still want to add mt8192 bindings in the next version without the driver. (LVTS support for mt8192 will be sent in a different series). > > Best regards, > Krzysztof >
On 01/02/2023 14:34, Balsam CHIHI wrote: >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - mediatek,mt8195-lvts-ap >>> + - mediatek,mt8195-lvts-mcu >> >> What about other devices? You called the file name as generic for all >> Mediatek SoCs, so why only one SoC is here? Is there going to be more? >> If yes, why they cannot be added now? > > Yes, there is another MTK SoC mt8192 that supports LVTS, > I was asked in v10 of the series to remove the unimplemented SoC. > It will be added later with the driver that supports it. > just let me know if you still want to add mt8192 bindings in the next > version without the driver. The binding should be complete, if that's possible, so if you had mt8192 already there, it could stay. Anyway it's fine then. Best regards, Krzysztof
Hi Krzysztof, On Wed, Feb 1, 2023 at 2:37 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 01/02/2023 14:34, Balsam CHIHI wrote: > >>> + > >>> +properties: > >>> + compatible: > >>> + enum: > >>> + - mediatek,mt8195-lvts-ap > >>> + - mediatek,mt8195-lvts-mcu > >> > >> What about other devices? You called the file name as generic for all > >> Mediatek SoCs, so why only one SoC is here? Is there going to be more? > >> If yes, why they cannot be added now? > > > > Yes, there is another MTK SoC mt8192 that supports LVTS, > > I was asked in v10 of the series to remove the unimplemented SoC. > > It will be added later with the driver that supports it. > > just let me know if you still want to add mt8192 bindings in the next > > version without the driver. > > The binding should be complete, if that's possible, so if you had mt8192 > already there, it could stay. Anyway it's fine then. OK, I will put back mt8192 dt-bindings. this is the link to the v10 patch "https://patchwork.kernel.org/project/linux-pm/patch/20230112152855.216072-3-bchihi@baylibre.com/", it will be the same in next version (v13) of series. it would be great if you review it in advance, so I could take into account the new changes if needed. is it possible to resend this patch under v13, to simplify the review and avoid breaking the series again? > > Best regards, > Krzysztof > Best regards, Balsam
© 2016 - 2024 Red Hat, Inc.