Testing of nolibc can produce a tools/include/nolibc/sysroot file, which
is not known to git. Because it is automatically generated, there is no
reason for it to be known to git. Therefore, add a .gitignore to remove
it from git's field of view.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Willy Tarreau <w@1wt.eu>
Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: Sven Schnelle <svens@linux.ibm.com>
diff --git a/tools/include/nolibc/.gitignore b/tools/include/nolibc/.gitignore
new file mode 100644
index 0000000000000..dea22eaaed2ba
--- /dev/null
+++ b/tools/include/nolibc/.gitignore
@@ -0,0 +1 @@
+sysrootOn Mon, Jan 23, 2023 at 04:47:07PM -0800, Paul E. McKenney wrote: > Testing of nolibc can produce a tools/include/nolibc/sysroot file, which > is not known to git. Because it is automatically generated, there is no > reason for it to be known to git. Therefore, add a .gitignore to remove > it from git's field of view. Yeah, I hit the same "git status" complaint and have a pending patch for that too: https://github.com/ammarfaizi2/linux-block/commit/89bfe86a03c173863de12.patch ^ I'll drop this one. > Signed-off-by: Paul E. McKenney <paulmck@kernel.org> > Cc: Willy Tarreau <w@1wt.eu> > Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org> > Cc: Sven Schnelle <svens@linux.ibm.com> > > diff --git a/tools/include/nolibc/.gitignore b/tools/include/nolibc/.gitignore > new file mode 100644 > index 0000000000000..dea22eaaed2ba > --- /dev/null > +++ b/tools/include/nolibc/.gitignore > @@ -0,0 +1 @@ > +sysroot Small nit about the naming, not so much important, but the common pattern for directory has a trailing slash. So, I would write "sysroot/". ".gitignore" and "tools/testing/selftests/.gitignore" do that too :-) Reviewed-by: Ammar Faizi <ammarfaizi2@gnuweeb.org> Thanks! -- Ammar Faizi
On Tue, Jan 24, 2023 at 08:06:00AM +0700, Ammar Faizi wrote: > On Mon, Jan 23, 2023 at 04:47:07PM -0800, Paul E. McKenney wrote: > > Testing of nolibc can produce a tools/include/nolibc/sysroot file, which > > is not known to git. Because it is automatically generated, there is no > > reason for it to be known to git. Therefore, add a .gitignore to remove > > it from git's field of view. > > Yeah, I hit the same "git status" complaint and have a pending patch > for that too: > > https://github.com/ammarfaizi2/linux-block/commit/89bfe86a03c173863de12.patch > > ^ I'll drop this one. Actually, why don't we take yours? Either way, I have to change something per your feedback below. No hurry, send it along when you normally would have. Thanx, Paul > > Signed-off-by: Paul E. McKenney <paulmck@kernel.org> > > Cc: Willy Tarreau <w@1wt.eu> > > Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org> > > Cc: Sven Schnelle <svens@linux.ibm.com> > > > > diff --git a/tools/include/nolibc/.gitignore b/tools/include/nolibc/.gitignore > > new file mode 100644 > > index 0000000000000..dea22eaaed2ba > > --- /dev/null > > +++ b/tools/include/nolibc/.gitignore > > @@ -0,0 +1 @@ > > +sysroot > > Small nit about the naming, not so much important, but the common > pattern for directory has a trailing slash. So, I would write > "sysroot/". > > ".gitignore" and "tools/testing/selftests/.gitignore" do that too :-) > > Reviewed-by: Ammar Faizi <ammarfaizi2@gnuweeb.org> > > Thanks! > > -- > Ammar Faizi >
On Mon, Jan 23, 2023 at 05:12:57PM -0800, Paul E. McKenney wrote: > On Tue, Jan 24, 2023 at 08:06:00AM +0700, Ammar Faizi wrote: > > On Mon, Jan 23, 2023 at 04:47:07PM -0800, Paul E. McKenney wrote: > > > Testing of nolibc can produce a tools/include/nolibc/sysroot file, which > > > is not known to git. Because it is automatically generated, there is no > > > reason for it to be known to git. Therefore, add a .gitignore to remove > > > it from git's field of view. > > > > Yeah, I hit the same "git status" complaint and have a pending patch > > for that too: > > > > https://github.com/ammarfaizi2/linux-block/commit/89bfe86a03c173863de12.patch > > > > ^ I'll drop this one. > > Actually, why don't we take yours? Either way, I have to change something > per your feedback below. > > No hurry, send it along when you normally would have. OK, I'll keep it then. Will send it together with my other patches later :-) Thanks. -- Ammar Faizi
On Tue, Jan 24, 2023 at 08:17:01AM +0700, Ammar Faizi wrote: > On Mon, Jan 23, 2023 at 05:12:57PM -0800, Paul E. McKenney wrote: > > On Tue, Jan 24, 2023 at 08:06:00AM +0700, Ammar Faizi wrote: > > > On Mon, Jan 23, 2023 at 04:47:07PM -0800, Paul E. McKenney wrote: > > > > Testing of nolibc can produce a tools/include/nolibc/sysroot file, which > > > > is not known to git. Because it is automatically generated, there is no > > > > reason for it to be known to git. Therefore, add a .gitignore to remove > > > > it from git's field of view. > > > > > > Yeah, I hit the same "git status" complaint and have a pending patch > > > for that too: > > > > > > https://github.com/ammarfaizi2/linux-block/commit/89bfe86a03c173863de12.patch > > > > > > ^ I'll drop this one. > > > > Actually, why don't we take yours? Either way, I have to change something > > per your feedback below. > > > > No hurry, send it along when you normally would have. > > OK, I'll keep it then. Will send it together with my other patches later :-) Sorry, I didn't notice it previously. Ack from me for either of your patches of course. Ammar, please note that Paul's subject is a bit more descriptive, so please consider updating when you resend. Thanks! Willy
© 2016 - 2025 Red Hat, Inc.