Fix SMMU on SDX55 and SDX65

[PATCH 0/3] Fix SMMU on SDX55 and SDX65

Posted by Manivannan Sadhasivam 2 years, 7 months ago

Hi,

Both SDX55 and SDX65 SoCs are using the Qcom version of the ARM SMMU-500
IP. Even though the SoC specfic compatibles were being used in devicetree,
the compatibles were not added to the arm-smmu-qcom driver. So they end up
using the generic ARM SMMU-500 driver instead.

Spotting this discrepancy, the recent arm,smmu bindings change moved these
SoCs under the non-qcom implementation of the SMMU.

This series fixes the binding by moving the compatibles under qcom impl.
and also adding the "qcom,smmu-500" fallback compatible to the devicetree
so that the qcom implementation can be used without adding SoC specific
entries to the driver.

Thanks,
Mani

Manivannan Sadhasivam (3):
  dt-bindings: arm-smmu: Fix binding for SDX55 and SDX65
  ARM: dts: qcom: sdx55: Add Qcom SMMU-500 as the fallback for IOMMU
    node
  ARM: dts: qcom: sdx65: Add Qcom SMMU-500 as the fallback for IOMMU
    node

 Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 10 ++--------
 arch/arm/boot/dts/qcom-sdx55.dtsi                     |  2 +-
 arch/arm/boot/dts/qcom-sdx65.dtsi                     |  2 +-
 3 files changed, 4 insertions(+), 10 deletions(-)

-- 
2.25.1

Re: [PATCH 0/3] Fix SMMU on SDX55 and SDX65

Posted by Will Deacon 2 years, 7 months ago

On Mon, 23 Jan 2023 18:49:28 +0530, Manivannan Sadhasivam wrote:
> Both SDX55 and SDX65 SoCs are using the Qcom version of the ARM SMMU-500
> IP. Even though the SoC specfic compatibles were being used in devicetree,
> the compatibles were not added to the arm-smmu-qcom driver. So they end up
> using the generic ARM SMMU-500 driver instead.
> 
> Spotting this discrepancy, the recent arm,smmu bindings change moved these
> SoCs under the non-qcom implementation of the SMMU.
> 
> [...]

Applied bindings change to will (for-joerg/arm-smmu/bindings), thanks!

[1/3] dt-bindings: arm-smmu: Fix binding for SDX55 and SDX65
      https://git.kernel.org/will/c/eb9181a3ae60

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

Re: (subset) [PATCH 0/3] Fix SMMU on SDX55 and SDX65

Posted by Bjorn Andersson 2 years, 7 months ago

On Mon, 23 Jan 2023 18:49:28 +0530, Manivannan Sadhasivam wrote:
> Both SDX55 and SDX65 SoCs are using the Qcom version of the ARM SMMU-500
> IP. Even though the SoC specfic compatibles were being used in devicetree,
> the compatibles were not added to the arm-smmu-qcom driver. So they end up
> using the generic ARM SMMU-500 driver instead.
> 
> Spotting this discrepancy, the recent arm,smmu bindings change moved these
> SoCs under the non-qcom implementation of the SMMU.
> 
> [...]

Applied, thanks!

[2/3] ARM: dts: qcom: sdx55: Add Qcom SMMU-500 as the fallback for IOMMU node
      commit: af4ab377543853b690cc85b4c46cf976ab560dc2
[3/3] ARM: dts: qcom: sdx65: Add Qcom SMMU-500 as the fallback for IOMMU node
      commit: 157178a7912e00a0aa0371dc9041952c1a21d112

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>