[PATCH 1/2] dt-bindings: display: bridge: ldb: Add i.MX93 LDB device tree binding

Liu Ying posted 2 patches 2 years, 7 months ago
There is a newer version of this series
[PATCH 1/2] dt-bindings: display: bridge: ldb: Add i.MX93 LDB device tree binding
Posted by Liu Ying 2 years, 7 months ago
Same to i.MX8mp LDB, i.MX93 LDB is controlled by mediamix blk-ctrl
through 'ldb' register and 'lvds' register.  Also, the 'ldb' clock
is required.  i.MX93 LDB supports only one LVDS channel(channel 0,
a.k.a, LVDS Channel-A in the device tree binding documentation), while
i.MX8mp LDB supports at most two.  Add i.MX93 LDB device tree binding
in the existing i.MX8mp LDB device tree binding documentation.

Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
 .../bindings/display/bridge/fsl,ldb.yaml         | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
index b19be0804abe..6e0e3ba9b49e 100644
--- a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
@@ -16,7 +16,9 @@ description: |
 
 properties:
   compatible:
-    const: fsl,imx8mp-ldb
+    enum:
+      - fsl,imx8mp-ldb
+      - fsl,imx93-ldb
 
   clocks:
     maxItems: 1
@@ -57,6 +59,18 @@ required:
   - clocks
   - ports
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: fsl,imx93-ldb
+    then:
+      properties:
+        ports:
+          properties:
+            port@2: false
+
 additionalProperties: false
 
 examples:
-- 
2.37.1
Re: [PATCH 1/2] dt-bindings: display: bridge: ldb: Add i.MX93 LDB device tree binding
Posted by Krzysztof Kozlowski 2 years, 7 months ago
On 22/01/2023 09:14, Liu Ying wrote:
> Same to i.MX8mp LDB, i.MX93 LDB is controlled by mediamix blk-ctrl
> through 'ldb' register and 'lvds' register.  Also, the 'ldb' clock

Subject: drop second/last, redundant "device tree binding". The
"dt-bindings" prefix is already stating that these are bindings.

> is required.  i.MX93 LDB supports only one LVDS channel(channel 0,
> a.k.a, LVDS Channel-A in the device tree binding documentation), while
> i.MX8mp LDB supports at most two.  Add i.MX93 LDB device tree binding
> in the existing i.MX8mp LDB device tree binding documentation.
> 
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof