ARM: dts: qcom: apq8060-dragonboard: align MPP pin node names with DT schema

[PATCH] ARM: dts: qcom: apq8060-dragonboard: align MPP pin node names with DT schema

Posted by Krzysztof Kozlowski 2 years, 7 months ago

DT schema expects nodes ending with "pins:

  qcom-apq8060-dragonboard.dtb: mpps@50: cm3605-mpps-state: 'oneOf' conditional failed, one must be fixed:
    'mpp5' does not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Warning visible after:
https://lore.kernel.org/r/20230120165103.1278852-1-robh@kernel.org
---
 arch/arm/boot/dts/qcom-apq8060-dragonboard.dts | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
index 7a4c59e04af6..8e4b61e4d4b1 100644
--- a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
+++ b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
@@ -435,15 +435,13 @@ &pm8058_led133 {
 
 &pm8058_mpps {
 	dragon_cm3605_mpps: cm3605-mpps-state {
-		mpp5 {
-			pins = "mpp5";
-			function = "analog";
-			input-enable;
-			bias-high-impedance;
-			/* Let's use channel 5 */
-			qcom,amux-route = <PMIC_MPP_AMUX_ROUTE_CH5>;
-			power-source = <PM8058_GPIO_S3>;
-		};
+		pins = "mpp5";
+		function = "analog";
+		input-enable;
+		bias-high-impedance;
+		/* Let's use channel 5 */
+		qcom,amux-route = <PMIC_MPP_AMUX_ROUTE_CH5>;
+		power-source = <PM8058_GPIO_S3>;
 	};
 };
 
-- 
2.34.1

Re: [PATCH] ARM: dts: qcom: apq8060-dragonboard: align MPP pin node names with DT schema

Posted by Bjorn Andersson 2 years, 7 months ago

On Fri, 20 Jan 2023 18:40:36 +0100, Krzysztof Kozlowski wrote:
> DT schema expects nodes ending with "pins:
> 
>   qcom-apq8060-dragonboard.dtb: mpps@50: cm3605-mpps-state: 'oneOf' conditional failed, one must be fixed:
>     'mpp5' does not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
> 
> 

Applied, thanks!

[1/1] ARM: dts: qcom: apq8060-dragonboard: align MPP pin node names with DT schema
      commit: e58065542e8e95351df86dd3b5ef45dd05c2aa47

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH] ARM: dts: qcom: apq8060-dragonboard: align MPP pin node names with DT schema

Posted by Konrad Dybcio 2 years, 7 months ago


On 20.01.2023 18:40, Krzysztof Kozlowski wrote:
> DT schema expects nodes ending with "pins:
> 
>   qcom-apq8060-dragonboard.dtb: mpps@50: cm3605-mpps-state: 'oneOf' conditional failed, one must be fixed:
>     'mpp5' does not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
> 
> Warning visible after:
> https://lore.kernel.org/r/20230120165103.1278852-1-robh@kernel.org
> ---
>  arch/arm/boot/dts/qcom-apq8060-dragonboard.dts | 16 +++++++---------
>  1 file changed, 7 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> index 7a4c59e04af6..8e4b61e4d4b1 100644
> --- a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> +++ b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> @@ -435,15 +435,13 @@ &pm8058_led133 {
>  
>  &pm8058_mpps {
>  	dragon_cm3605_mpps: cm3605-mpps-state {
> -		mpp5 {
> -			pins = "mpp5";
> -			function = "analog";
> -			input-enable;
> -			bias-high-impedance;
> -			/* Let's use channel 5 */
> -			qcom,amux-route = <PMIC_MPP_AMUX_ROUTE_CH5>;
> -			power-source = <PM8058_GPIO_S3>;
> -		};
> +		pins = "mpp5";
> +		function = "analog";
> +		input-enable;
> +		bias-high-impedance;
> +		/* Let's use channel 5 */
> +		qcom,amux-route = <PMIC_MPP_AMUX_ROUTE_CH5>;
> +		power-source = <PM8058_GPIO_S3>;
>  	};
>  };
>