dt-bindings: mtd: partitions: Fix partition node name pattern

[PATCH] dt-bindings: mtd: partitions: Fix partition node name pattern

Posted by Rob Herring 2 years, 7 months ago

The 'partition' node name pattern is missing start and end anchors, so
anything is allowed before or after the regex pattern. There's no in tree
users needing that, so add anchors to the pattern.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/mtd/partitions/partitions.yaml          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mtd/partitions/partitions.yaml b/Documentation/devicetree/bindings/mtd/partitions/partitions.yaml
index 9aca4e6c6047..2edc65e0e361 100644
--- a/Documentation/devicetree/bindings/mtd/partitions/partitions.yaml
+++ b/Documentation/devicetree/bindings/mtd/partitions/partitions.yaml
@@ -32,7 +32,7 @@ properties:
     enum: [1, 2]
 
 patternProperties:
-  "partition(-.+|@[0-9a-f]+)":
+  "^partition(-.+|@[0-9a-f]+)$":
     $ref: partition.yaml
 
 required:
-- 
2.39.0

Re: [PATCH] dt-bindings: mtd: partitions: Fix partition node name pattern

Posted by Miquel Raynal 2 years, 7 months ago

Hi Rob,

robh@kernel.org wrote on Thu, 19 Jan 2023 20:04:53 -0600:

> The 'partition' node name pattern is missing start and end anchors, so
> anything is allowed before or after the regex pattern. There's no in tree
> users needing that, so add anchors to the pattern.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---

Looks like my scripts did not properly sent the "applied" e-mail, so
here it is, I applied this patch to mtd/next.

Thanks,
Miquèl

Re: [PATCH] dt-bindings: mtd: partitions: Fix partition node name pattern

Posted by Dhruva Gole 2 years, 7 months ago


On 20/01/23 07:34, Rob Herring wrote:
> The 'partition' node name pattern is missing start and end anchors, so
> anything is allowed before or after the regex pattern. There's no in tree
> users needing that, so add anchors to the pattern.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---

Reviewed-by: Dhruva Gole <d-gole@ti.com>



>   .../devicetree/bindings/mtd/partitions/partitions.yaml          | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/partitions/partitions.yaml b/Documentation/devicetree/bindings/mtd/partitions/partitions.yaml
> index 9aca4e6c6047..2edc65e0e361 100644
> --- a/Documentation/devicetree/bindings/mtd/partitions/partitions.yaml
> +++ b/Documentation/devicetree/bindings/mtd/partitions/partitions.yaml
> @@ -32,7 +32,7 @@ properties:
>       enum: [1, 2]
>   
>   patternProperties:
> -  "partition(-.+|@[0-9a-f]+)":
> +  "^partition(-.+|@[0-9a-f]+)$":
>       $ref: partition.yaml
>   
>   required:

-- 
Best regards,
Dhruva Gole
Texas Instruments Incorporated

Re: [PATCH] dt-bindings: mtd: partitions: Fix partition node name pattern

Posted by Pratyush Yadav 2 years, 7 months ago

On Thu, Jan 19 2023, Rob Herring wrote:

> The 'partition' node name pattern is missing start and end anchors, so
> anything is allowed before or after the regex pattern. There's no in tree
> users needing that, so add anchors to the pattern.
>
> Signed-off-by: Rob Herring <robh@kernel.org>

Reviewed-by: Pratyush Yadav <ptyadav@amazon.de>

-- 
Regards,
Pratyush Yadav

Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879