[PATCH] dt-bindings: soc: socionext,uniphier-soc-glue: Make child node names fixed names

Rob Herring posted 1 patch 2 years, 7 months ago
.../bindings/soc/socionext/socionext,uniphier-soc-glue.yaml      | 1 -
1 file changed, 1 deletion(-)
[PATCH] dt-bindings: soc: socionext,uniphier-soc-glue: Make child node names fixed names
Posted by Rob Herring 2 years, 7 months ago
The child nodes 'pinctrl', 'usb-hub', and 'clock-controller' in the
socionext,uniphier-soc-glue binding are not patterns, but the full node
name, so move them to 'properties'. As patterns, they were missing start
and end anchors so any prefix or suffix was allowed.

Fixes: 0611adff8b3a ("dt-bindings: soc: socionext: Add UniPhier SoC-glue logic")
Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../bindings/soc/socionext/socionext,uniphier-soc-glue.yaml      | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
index 4b6852db4747..7845dcfca986 100644
--- a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
+++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
@@ -32,7 +32,6 @@ properties:
   reg:
     maxItems: 1
 
-patternProperties:
   pinctrl:
     $ref: /schemas/pinctrl/socionext,uniphier-pinctrl.yaml#
 
-- 
2.39.0
Re: [PATCH] dt-bindings: soc: socionext,uniphier-soc-glue: Make child node names fixed names
Posted by Rob Herring 2 years, 7 months ago
On Thu, 19 Jan 2023 20:03:39 -0600, Rob Herring wrote:
> The child nodes 'pinctrl', 'usb-hub', and 'clock-controller' in the
> socionext,uniphier-soc-glue binding are not patterns, but the full node
> name, so move them to 'properties'. As patterns, they were missing start
> and end anchors so any prefix or suffix was allowed.
> 
> Fixes: 0611adff8b3a ("dt-bindings: soc: socionext: Add UniPhier SoC-glue logic")
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  .../bindings/soc/socionext/socionext,uniphier-soc-glue.yaml      | 1 -
>  1 file changed, 1 deletion(-)
> 

Applied, thanks!
Re: [PATCH] dt-bindings: soc: socionext,uniphier-soc-glue: Make child node names fixed names
Posted by Kunihiko Hayashi 2 years, 7 months ago
Hi Rob,

On 2023/01/20 11:03, Rob Herring wrote:
> The child nodes 'pinctrl', 'usb-hub', and 'clock-controller' in the
> socionext,uniphier-soc-glue binding are not patterns, but the full node
> name, so move them to 'properties'. As patterns, they were missing start
> and end anchors so any prefix or suffix was allowed.
> 
> Fixes: 0611adff8b3a ("dt-bindings: soc: socionext: Add UniPhier SoC-glue
> logic")
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>   .../bindings/soc/socionext/socionext,uniphier-soc-glue.yaml      | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git
> a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-g
> lue.yaml
> b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-g
> lue.yaml
> index 4b6852db4747..7845dcfca986 100644
> ---
> a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-g
> lue.yaml
> +++
> b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-g
> lue.yaml
> @@ -32,7 +32,6 @@ properties:
>     reg:
>       maxItems: 1
>   
> -patternProperties:
>     pinctrl:
>       $ref: /schemas/pinctrl/socionext,uniphier-pinctrl.yaml#
>   

Thanks for pointing out.
This is because I forgot to remove it when I changed the child node,
and it should be removed.

Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>

Thank you,

---
Best Regards
Kunihiko Hayashi