[v2] ipv6: Document that max_size sysctl is depreciated

[net-next v2] ipv6: Document that max_size sysctl is depreciated

Posted by Jon Maxwell 2 years, 7 months ago

v2: use correct commit syntax.

Document that max_size is depreciated due to:

af6d10345ca7 ("ipv6: remove max_size check inline with ipv4")

Signed-off-by: Jon Maxwell <jmaxwell37@gmail.com>
---
 Documentation/networking/ip-sysctl.rst | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/networking/ip-sysctl.rst b/Documentation/networking/ip-sysctl.rst
index 7fbd060d6047..edf1fcd10c5c 100644
--- a/Documentation/networking/ip-sysctl.rst
+++ b/Documentation/networking/ip-sysctl.rst
@@ -156,6 +156,9 @@ route/max_size - INTEGER
 	From linux kernel 3.6 onwards, this is deprecated for ipv4
 	as route cache is no longer used.
 
+	From linux kernel 6.2 onwards, this is deprecated for ipv6
+	as garbage collection manages cached route entries.
+
 neigh/default/gc_thresh1 - INTEGER
 	Minimum number of entries to keep.  Garbage collector will not
 	purge entries if there are fewer than this number.
-- 
2.31.1

Re: [net-next v2] ipv6: Document that max_size sysctl is depreciated

Posted by Jakub Kicinski 2 years, 7 months ago

On Wed, 18 Jan 2023 09:18:58 +1100 Jon Maxwell wrote:
> Subject: [net-next v2] ipv6: Document that max_size sysctl is depreciated
>
> v2: use correct commit syntax.

change log under the --- lines

> Document that max_size is depreciated due to:
> 
> af6d10345ca7 ("ipv6: remove max_size check inline with ipv4")

 ^ commit

the word "commit" should be there before the hash

> Signed-off-by: Jon Maxwell <jmaxwell37@gmail.com>
> ---
>  Documentation/networking/ip-sysctl.rst | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/networking/ip-sysctl.rst b/Documentation/networking/ip-sysctl.rst
> index 7fbd060d6047..edf1fcd10c5c 100644
> --- a/Documentation/networking/ip-sysctl.rst
> +++ b/Documentation/networking/ip-sysctl.rst
> @@ -156,6 +156,9 @@ route/max_size - INTEGER
>  	From linux kernel 3.6 onwards, this is deprecated for ipv4
>  	as route cache is no longer used.
>  
> +	From linux kernel 6.2 onwards, this is deprecated for ipv6

6.2 or 6.3? 6.2 is what's currently in Linus's tree, net-next 
is 6.3 and the commit in the commit msg is in net-next only.

> +	as garbage collection manages cached route entries.

Re: [net-next v2] ipv6: Document that max_size sysctl is depreciated

Posted by Jonathan Maxwell 2 years, 7 months ago

On Thu, Jan 19, 2023 at 3:38 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Wed, 18 Jan 2023 09:18:58 +1100 Jon Maxwell wrote:
> > Subject: [net-next v2] ipv6: Document that max_size sysctl is depreciated
> >
> > v2: use correct commit syntax.
>
> change log under the --- lines
>
> > Document that max_size is depreciated due to:
> >
> > af6d10345ca7 ("ipv6: remove max_size check inline with ipv4")
>
>  ^ commit

Okay I'll add that.

>
> the word "commit" should be there before the hash
>
> > Signed-off-by: Jon Maxwell <jmaxwell37@gmail.com>
> > ---
> >  Documentation/networking/ip-sysctl.rst | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/networking/ip-sysctl.rst b/Documentation/networking/ip-sysctl.rst
> > index 7fbd060d6047..edf1fcd10c5c 100644
> > --- a/Documentation/networking/ip-sysctl.rst
> > +++ b/Documentation/networking/ip-sysctl.rst
> > @@ -156,6 +156,9 @@ route/max_size - INTEGER
> >       From linux kernel 3.6 onwards, this is deprecated for ipv4
> >       as route cache is no longer used.
> >
> > +     From linux kernel 6.2 onwards, this is deprecated for ipv6
>
> 6.2 or 6.3? 6.2 is what's currently in Linus's tree, net-next
> is 6.3 and the commit in the commit msg is in net-next only.
>

I'll change this to 6.3.

Regards

Jon

> > +     as garbage collection manages cached route entries.