atm: lanai: Use dma_zalloc_coherent()

[PATCH linux-next] atm: lanai: Use dma_zalloc_coherent()

Posted by ye.xingchen@zte.com.cn 2 years, 8 months ago

From: ye xingchen <ye.xingchen@zte.com.cn>

Instead of using dma_alloc_coherent() and memset() directly use
dma_zalloc_coherent().

Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
 drivers/atm/lanai.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/atm/lanai.c b/drivers/atm/lanai.c
index 32d7aa141d96..b7e0199ce642 100644
--- a/drivers/atm/lanai.c
+++ b/drivers/atm/lanai.c
@@ -342,8 +342,8 @@ static void lanai_buf_allocate(struct lanai_buffer *buf,
 		 * everything, but the way the lanai uses DMA memory would
 		 * make that a terrific pain.  This is much simpler.
 		 */
-		buf->start = dma_alloc_coherent(&pci->dev,
-						size, &buf->dmaaddr, GFP_KERNEL);
+		buf->start = dma_zalloc_coherent(&pci->dev,
+						 size, &buf->dmaaddr, GFP_KERNEL);
 		if (buf->start != NULL) {	/* Success */
 			/* Lanai requires 256-byte alignment of DMA bufs */
 			APRINTK((buf->dmaaddr & ~0xFFFFFF00) == 0,
@@ -352,7 +352,6 @@ static void lanai_buf_allocate(struct lanai_buffer *buf,
 			buf->ptr = buf->start;
 			buf->end = (u32 *)
 			    (&((unsigned char *) buf->start)[size]);
-			memset(buf->start, 0, size);
 			break;
 		}
 		size /= 2;
-- 
2.25.1

RE: [PATCH linux-next] atm: lanai: Use dma_zalloc_coherent()

Posted by David Laight 2 years, 8 months ago

From: ye.xingchen@zte.com.cn
> Sent: 17 January 2023 09:21
> 
> Instead of using dma_alloc_coherent() and memset() directly use
> dma_zalloc_coherent().

I'm sure I've a brain cell that remembers that dma_alloc_coherent()
always zeros the buffer.
So the 'zalloc' variant isn't needed and the memset() can just
be deleted.
OTOH is it really worth the churn.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)

Re: RE: [PATCH linux-next] atm: lanai: Use dma_zalloc_coherent()

Posted by Christophe JAILLET 2 years, 8 months ago

Le 17/01/2023 à 16:37, David Laight a écrit :
> From: ye.xingchen@zte.com.cn
>> Sent: 17 January 2023 09:21
>>
>> Instead of using dma_alloc_coherent() and memset() directly use
>> dma_zalloc_coherent().
> 
> I'm sure I've a brain cell that remembers that dma_alloc_coherent()
> always zeros the buffer.
> So the 'zalloc' variant isn't needed and the memset() can just
> be deleted.
> OTOH is it really worth the churn.

More-over, dma_zalloc_coherent() has been removed at the very beginning 
of 2019 in commit dfd32cad146e.

It is not existing since v5.0-rc2.

\o/


CJ

> 
> 	David
> 
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)