1. Patchew
  2. linux
  3. View series

[PATCH] virt: sevguest: add CONFIG_CRYPTO dependency

Arnd Bergmann posted 1 patch 3 years ago 
drivers/virt/coco/sev-guest/Kconfig | 1 +
1 file changed, 1 insertion(+)
[PATCH] virt: sevguest: add CONFIG_CRYPTO dependency
Posted by Arnd Bergmann 3 years ago 
From: Arnd Bergmann <arnd@arndb.de>

This driver fails to link when CRYPTO is disabled, or in a loadable module:

WARNING: unmet direct dependencies detected for CRYPTO_GCM
WARNING: unmet direct dependencies detected for CRYPTO_AEAD2
  Depends on [m]: CRYPTO [=m]
  Selected by [y]:
  - SEV_GUEST [=y] && VIRT_DRIVERS [=y] && AMD_MEM_ENCRYPT [=y]

x86_64-linux-ld: crypto/aead.o: in function `crypto_register_aeads':

Fixes: d63670d23e60 ("virt: sevguest: Rename the sevguest dir and files to sev-guest")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/virt/coco/sev-guest/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/virt/coco/sev-guest/Kconfig b/drivers/virt/coco/sev-guest/Kconfig
index f9db0799ae67..da2d7ca531f0 100644
--- a/drivers/virt/coco/sev-guest/Kconfig
+++ b/drivers/virt/coco/sev-guest/Kconfig
@@ -2,6 +2,7 @@ config SEV_GUEST
 	tristate "AMD SEV Guest driver"
 	default m
 	depends on AMD_MEM_ENCRYPT
+	select CRYPTO
 	select CRYPTO_AEAD2
 	select CRYPTO_GCM
 	help
-- 
2.39.0
Re: [PATCH] virt: sevguest: add CONFIG_CRYPTO dependency
Posted by Tom Lendacky 3 years ago 
On 1/17/23 11:13, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> This driver fails to link when CRYPTO is disabled, or in a loadable module:
> 
> WARNING: unmet direct dependencies detected for CRYPTO_GCM
> WARNING: unmet direct dependencies detected for CRYPTO_AEAD2
>    Depends on [m]: CRYPTO [=m]
>    Selected by [y]:
>    - SEV_GUEST [=y] && VIRT_DRIVERS [=y] && AMD_MEM_ENCRYPT [=y]
> 
> x86_64-linux-ld: crypto/aead.o: in function `crypto_register_aeads':
> 
> Fixes: d63670d23e60 ("virt: sevguest: Rename the sevguest dir and files to sev-guest")

This has been present from when the driver was first added, so I think the 
correct Fixes: tag should be:

Fixes: fce96cf04430 ("virt: Add SEV-SNP guest driver")

Correct?

Thanks,
Tom

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   drivers/virt/coco/sev-guest/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/virt/coco/sev-guest/Kconfig b/drivers/virt/coco/sev-guest/Kconfig
> index f9db0799ae67..da2d7ca531f0 100644
> --- a/drivers/virt/coco/sev-guest/Kconfig
> +++ b/drivers/virt/coco/sev-guest/Kconfig
> @@ -2,6 +2,7 @@ config SEV_GUEST
>   	tristate "AMD SEV Guest driver"
>   	default m
>   	depends on AMD_MEM_ENCRYPT
> +	select CRYPTO
>   	select CRYPTO_AEAD2
>   	select CRYPTO_GCM
>   	help
Re: [PATCH] virt: sevguest: add CONFIG_CRYPTO dependency
Posted by Tom Lendacky 3 years ago 
Updating email for Boris.

On 1/17/23 11:26, Tom Lendacky wrote:
> On 1/17/23 11:13, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> This driver fails to link when CRYPTO is disabled, or in a loadable module:
>>
>> WARNING: unmet direct dependencies detected for CRYPTO_GCM
>> WARNING: unmet direct dependencies detected for CRYPTO_AEAD2
>>    Depends on [m]: CRYPTO [=m]
>>    Selected by [y]:
>>    - SEV_GUEST [=y] && VIRT_DRIVERS [=y] && AMD_MEM_ENCRYPT [=y]
>>
>> x86_64-linux-ld: crypto/aead.o: in function `crypto_register_aeads':
>>
>> Fixes: d63670d23e60 ("virt: sevguest: Rename the sevguest dir and files 
>> to sev-guest")
> 
> This has been present from when the driver was first added, so I think the 
> correct Fixes: tag should be:
> 
> Fixes: fce96cf04430 ("virt: Add SEV-SNP guest driver")
> 
> Correct?
> 
> Thanks,
> Tom
> 
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>>   drivers/virt/coco/sev-guest/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/virt/coco/sev-guest/Kconfig 
>> b/drivers/virt/coco/sev-guest/Kconfig
>> index f9db0799ae67..da2d7ca531f0 100644
>> --- a/drivers/virt/coco/sev-guest/Kconfig
>> +++ b/drivers/virt/coco/sev-guest/Kconfig
>> @@ -2,6 +2,7 @@ config SEV_GUEST
>>       tristate "AMD SEV Guest driver"
>>       default m
>>       depends on AMD_MEM_ENCRYPT
>> +    select CRYPTO
>>       select CRYPTO_AEAD2
>>       select CRYPTO_GCM
>>       help
[tip: x86/cc] virt: sevguest: Add CONFIG_CRYPTO dependency
Posted by tip-bot2 for Arnd Bergmann 2 years, 8 months ago 
The following commit has been merged into the x86/cc branch of tip:

Commit-ID:     84b9b44b99780d35fe72ac63c4724f158771e898
Gitweb:        https://git.kernel.org/tip/84b9b44b99780d35fe72ac63c4724f158771e898
Author:        Arnd Bergmann <arnd@arndb.de>
AuthorDate:    Tue, 17 Jan 2023 18:13:56 +01:00
Committer:     Borislav Petkov (AMD) <bp@alien8.de>
CommitterDate: Fri, 09 Jun 2023 15:53:07 +02:00

virt: sevguest: Add CONFIG_CRYPTO dependency

This driver fails to link when CRYPTO is disabled, or in a loadable
module:

  WARNING: unmet direct dependencies detected for CRYPTO_GCM
  WARNING: unmet direct dependencies detected for CRYPTO_AEAD2
    Depends on [m]: CRYPTO [=m]
    Selected by [y]:
    - SEV_GUEST [=y] && VIRT_DRIVERS [=y] && AMD_MEM_ENCRYPT [=y]

x86_64-linux-ld: crypto/aead.o: in function `crypto_register_aeads':

Fixes: fce96cf04430 ("virt: Add SEV-SNP guest driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/20230117171416.2715125-1-arnd@kernel.org
---
 drivers/virt/coco/sev-guest/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/virt/coco/sev-guest/Kconfig b/drivers/virt/coco/sev-guest/Kconfig
index f9db079..da2d7ca 100644
--- a/drivers/virt/coco/sev-guest/Kconfig
+++ b/drivers/virt/coco/sev-guest/Kconfig
@@ -2,6 +2,7 @@ config SEV_GUEST
 	tristate "AMD SEV Guest driver"
 	default m
 	depends on AMD_MEM_ENCRYPT
+	select CRYPTO
 	select CRYPTO_AEAD2
 	select CRYPTO_GCM
 	help

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.