1. Patchew
  2. linux
  3. View series

[PATCH] arm64: defconfig: enable Qualcomm PCIe modem drivers

Johan Hovold posted 1 patch 2 years, 8 months ago
There is a newer version of this series
arch/arm64/configs/defconfig | 4 ++++
1 file changed, 4 insertions(+)
[PATCH] arm64: defconfig: enable Qualcomm PCIe modem drivers
Posted by Johan Hovold 2 years, 8 months ago 
Enable the MHI PCI controller driver and MHI WWAN drivers for Qualcomm
based PCIe modems such as the ones found on the SC8280XP Compute
Reference Design (CRD) and Lenovo Thinkpad X13s.

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---

Bjorn,

Perhaps you can take this through your tree?

Johan


 arch/arm64/configs/defconfig | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 86aa3730a8b6..117b49f3f1c1 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -250,6 +250,7 @@ CONFIG_DEVTMPFS_MOUNT=y
 CONFIG_FW_LOADER_USER_HELPER=y
 CONFIG_HISILICON_LPC=y
 CONFIG_TEGRA_ACONNECT=m
+CONFIG_MHI_BUS_PCI_GENERIC=m
 CONFIG_ARM_SCMI_PROTOCOL=y
 CONFIG_ARM_SCPI_PROTOCOL=y
 CONFIG_RASPBERRYPI_FIRMWARE=y
@@ -405,6 +406,9 @@ CONFIG_MWIFIEX_SDIO=m
 CONFIG_MWIFIEX_PCIE=m
 CONFIG_WL18XX=m
 CONFIG_WLCORE_SDIO=m
+CONFIG_WWAN=m
+CONFIG_MHI_WWAN_CTRL=m
+CONFIG_MHI_WWAN_MBIM=m
 CONFIG_INPUT_EVDEV=y
 CONFIG_KEYBOARD_ADC=m
 CONFIG_KEYBOARD_GPIO=y
-- 
2.38.2
Re: [PATCH] arm64: defconfig: enable Qualcomm PCIe modem drivers
Posted by Daniele Palmas 2 years, 8 months ago 
Hello Johan,

Il giorno sab 14 gen 2023 alle ore 17:23 Johan Hovold
<johan+linaro@kernel.org> ha scritto:
>
> Enable the MHI PCI controller driver and MHI WWAN drivers for Qualcomm
> based PCIe modems such as the ones found on the SC8280XP Compute
> Reference Design (CRD) and Lenovo Thinkpad X13s.
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>
> Bjorn,
>
> Perhaps you can take this through your tree?
>
> Johan
>
>
>  arch/arm64/configs/defconfig | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 86aa3730a8b6..117b49f3f1c1 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -250,6 +250,7 @@ CONFIG_DEVTMPFS_MOUNT=y
>  CONFIG_FW_LOADER_USER_HELPER=y
>  CONFIG_HISILICON_LPC=y
>  CONFIG_TEGRA_ACONNECT=m
> +CONFIG_MHI_BUS_PCI_GENERIC=m
>  CONFIG_ARM_SCMI_PROTOCOL=y
>  CONFIG_ARM_SCPI_PROTOCOL=y
>  CONFIG_RASPBERRYPI_FIRMWARE=y
> @@ -405,6 +406,9 @@ CONFIG_MWIFIEX_SDIO=m
>  CONFIG_MWIFIEX_PCIE=m
>  CONFIG_WL18XX=m
>  CONFIG_WLCORE_SDIO=m
> +CONFIG_WWAN=m
> +CONFIG_MHI_WWAN_CTRL=m
> +CONFIG_MHI_WWAN_MBIM=m

wondering if it could make sense to also enable CONFIG_MHI_NET, since
in mhi_pci_generic there are also modems bound to that driver and, if
not enabled, those would show just the control device, but not the
netdevice.

Regards,
Daniele

>  CONFIG_INPUT_EVDEV=y
>  CONFIG_KEYBOARD_ADC=m
>  CONFIG_KEYBOARD_GPIO=y
> --
> 2.38.2
>
Re: [PATCH] arm64: defconfig: enable Qualcomm PCIe modem drivers
Posted by Johan Hovold 2 years, 8 months ago 
On Sun, Jan 15, 2023 at 01:11:08PM +0100, Daniele Palmas wrote:
> Hello Johan,
> 
> Il giorno sab 14 gen 2023 alle ore 17:23 Johan Hovold
> <johan+linaro@kernel.org> ha scritto:
> >
> > Enable the MHI PCI controller driver and MHI WWAN drivers for Qualcomm
> > based PCIe modems such as the ones found on the SC8280XP Compute
> > Reference Design (CRD) and Lenovo Thinkpad X13s.
> >
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > ---

> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 86aa3730a8b6..117b49f3f1c1 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -250,6 +250,7 @@ CONFIG_DEVTMPFS_MOUNT=y
> >  CONFIG_FW_LOADER_USER_HELPER=y
> >  CONFIG_HISILICON_LPC=y
> >  CONFIG_TEGRA_ACONNECT=m
> > +CONFIG_MHI_BUS_PCI_GENERIC=m
> >  CONFIG_ARM_SCMI_PROTOCOL=y
> >  CONFIG_ARM_SCPI_PROTOCOL=y
> >  CONFIG_RASPBERRYPI_FIRMWARE=y
> > @@ -405,6 +406,9 @@ CONFIG_MWIFIEX_SDIO=m
> >  CONFIG_MWIFIEX_PCIE=m
> >  CONFIG_WL18XX=m
> >  CONFIG_WLCORE_SDIO=m
> > +CONFIG_WWAN=m
> > +CONFIG_MHI_WWAN_CTRL=m
> > +CONFIG_MHI_WWAN_MBIM=m
> 
> wondering if it could make sense to also enable CONFIG_MHI_NET, since
> in mhi_pci_generic there are also modems bound to that driver and, if
> not enabled, those would show just the control device, but not the
> netdevice.

Yes, indeed, that's a good idea. I had it enabled in my local config but
didn't include it as it isn't needed for the two machines I'm currently
working on.

I'll send a v2. Thanks!

Johan
Re: [PATCH] arm64: defconfig: enable Qualcomm PCIe modem drivers
Posted by Manivannan Sadhasivam 2 years, 8 months ago 
On Sat, Jan 14, 2023 at 05:22:36PM +0100, Johan Hovold wrote:
> Enable the MHI PCI controller driver and MHI WWAN drivers for Qualcomm
> based PCIe modems such as the ones found on the SC8280XP Compute
> Reference Design (CRD) and Lenovo Thinkpad X13s.
> 
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks,
Mani

> ---
> 
> Bjorn,
> 
> Perhaps you can take this through your tree?
> 
> Johan
> 
> 
>  arch/arm64/configs/defconfig | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 86aa3730a8b6..117b49f3f1c1 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -250,6 +250,7 @@ CONFIG_DEVTMPFS_MOUNT=y
>  CONFIG_FW_LOADER_USER_HELPER=y
>  CONFIG_HISILICON_LPC=y
>  CONFIG_TEGRA_ACONNECT=m
> +CONFIG_MHI_BUS_PCI_GENERIC=m
>  CONFIG_ARM_SCMI_PROTOCOL=y
>  CONFIG_ARM_SCPI_PROTOCOL=y
>  CONFIG_RASPBERRYPI_FIRMWARE=y
> @@ -405,6 +406,9 @@ CONFIG_MWIFIEX_SDIO=m
>  CONFIG_MWIFIEX_PCIE=m
>  CONFIG_WL18XX=m
>  CONFIG_WLCORE_SDIO=m
> +CONFIG_WWAN=m
> +CONFIG_MHI_WWAN_CTRL=m
> +CONFIG_MHI_WWAN_MBIM=m
>  CONFIG_INPUT_EVDEV=y
>  CONFIG_KEYBOARD_ADC=m
>  CONFIG_KEYBOARD_GPIO=y
> -- 
> 2.38.2
> 

-- 
மணிவண்ணன் சதாசிவம்

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.