arm64: dts: rockchip: add missing #interrupt-cells to rk356x pcie2x1

[PATCH] arm64: dts: rockchip: add missing #interrupt-cells to rk356x pcie2x1

Posted by Jensen Huang 2 years, 8 months ago

This fixes the following issue:
  pcieport 0000:00:00.0: of_irq_parse_pci: failed with rc=-22

Signed-off-by: Jensen Huang <jensenhuang@friendlyarm.com>
---
 arch/arm64/boot/dts/rockchip/rk356x.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
index 5706c3e24f0a..b3185e4115d9 100644
--- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
@@ -985,6 +985,7 @@ pcie2x1: pcie@fe260000 {
 		resets = <&cru SRST_PCIE20_POWERUP>;
 		reset-names = "pipe";
 		#address-cells = <3>;
+		#interrupt-cells = <1>;
 		#size-cells = <2>;
 		status = "disabled";

--
2.38.1

Re: [PATCH] arm64: dts: rockchip: add missing #interrupt-cells to rk356x pcie2x1

Posted by Heiko Stuebner 2 years, 8 months ago

On Fri, 13 Jan 2023 14:44:57 +0800, Jensen Huang wrote:
> This fixes the following issue:
>   pcieport 0000:00:00.0: of_irq_parse_pci: failed with rc=-22
> 
> 

Applied, thanks!

[1/1] arm64: dts: rockchip: add missing #interrupt-cells to rk356x pcie2x1
      commit: a323e6b5737bb6e3d3946369b97099abb7dde695

Moved the new line to a better position inside the node
(similar to the pcie3 on rk3568)

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

Re: [PATCH] arm64: dts: rockchip: add missing #interrupt-cells to rk356x pcie2x1

Posted by Jensen Huang 2 years, 8 months ago

Hi,

I got this error while testing on a rk3568 based board (NanoPi R5S):
  pcieport 0000:00:00.0: of_irq_parse_pci: failed with rc=-22
Also I checked of_irq_parse_raw(), it looks like this property is necessary.

BR,
Jensen

On Fri, Jan 13, 2023 at 2:45 PM Jensen Huang
<jensenhuang@friendlyarm.com> wrote:
>
> This fixes the following issue:
>   pcieport 0000:00:00.0: of_irq_parse_pci: failed with rc=-22
>
> Signed-off-by: Jensen Huang <jensenhuang@friendlyarm.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk356x.dtsi | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> index 5706c3e24f0a..b3185e4115d9 100644
> --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> @@ -985,6 +985,7 @@ pcie2x1: pcie@fe260000 {
>                 resets = <&cru SRST_PCIE20_POWERUP>;
>                 reset-names = "pipe";
>                 #address-cells = <3>;
> +               #interrupt-cells = <1>;
>                 #size-cells = <2>;
>                 status = "disabled";
>
> --
> 2.38.1
>