arch/x86/events/intel/uncore.c | 34 ++++- arch/x86/events/intel/uncore.h | 4 + arch/x86/events/intel/uncore_discovery.c | 60 ++++++--- arch/x86/events/intel/uncore_discovery.h | 14 +- arch/x86/events/intel/uncore_snbep.c | 158 ++++++++++++++++++----- 5 files changed, 210 insertions(+), 60 deletions(-)
From: Kan Liang <kan.liang@linux.intel.com> The discovery table of UPI on SPR MCC is broken. The patch series is to mitigate the issue by providing a hardcode pre-defined table. The broken discovery table can trigger a kernel warning message, which is overkilled. The patch series also refine the error handling code. Kan Liang (5): perf/x86/uncore: Factor out uncore_device_to_die() perf/x86/uncore: Fix potential NULL pointer in uncore_get_alias_name perf/x86/uncore: Ignore broken units in discovery table perf/x86/uncore: Add a quirk for UPI on SPR perf/x86/uncore: Don't WARN_ON_ONCE() for a broken discovery table arch/x86/events/intel/uncore.c | 34 ++++- arch/x86/events/intel/uncore.h | 4 + arch/x86/events/intel/uncore_discovery.c | 60 ++++++--- arch/x86/events/intel/uncore_discovery.h | 14 +- arch/x86/events/intel/uncore_snbep.c | 158 ++++++++++++++++++----- 5 files changed, 210 insertions(+), 60 deletions(-) -- 2.35.1
Hi Peter & Ingo, Gentle Ping. Please let me know if you have any comments on the patch set. Thanks Kan On 2023-01-12 3:01 p.m., kan.liang@linux.intel.com wrote: > From: Kan Liang <kan.liang@linux.intel.com> > > The discovery table of UPI on SPR MCC is broken. The patch series is > to mitigate the issue by providing a hardcode pre-defined table. > > The broken discovery table can trigger a kernel warning message, which > is overkilled. The patch series also refine the error handling code. > > Kan Liang (5): > perf/x86/uncore: Factor out uncore_device_to_die() > perf/x86/uncore: Fix potential NULL pointer in uncore_get_alias_name > perf/x86/uncore: Ignore broken units in discovery table > perf/x86/uncore: Add a quirk for UPI on SPR > perf/x86/uncore: Don't WARN_ON_ONCE() for a broken discovery table > > arch/x86/events/intel/uncore.c | 34 ++++- > arch/x86/events/intel/uncore.h | 4 + > arch/x86/events/intel/uncore_discovery.c | 60 ++++++--- > arch/x86/events/intel/uncore_discovery.h | 14 +- > arch/x86/events/intel/uncore_snbep.c | 158 ++++++++++++++++++----- > 5 files changed, 210 insertions(+), 60 deletions(-) >
Hello all, gentle ping #2... How does it look with the patchset acceptance? Is everything OK? Does it need any additional testing/etc.? When could the patches be expected to land in Linus' tree? Is it within v6.2 scope? Thank you. Michael On Thu, 19 Jan 2023, Liang, Kan wrote: > Hi Peter & Ingo, > > Gentle Ping. Please let me know if you have any comments on the patch set. > > Thanks > Kan > > On 2023-01-12 3:01 p.m., kan.liang@linux.intel.com wrote: > > From: Kan Liang <kan.liang@linux.intel.com> > > > > The discovery table of UPI on SPR MCC is broken. The patch series is > > to mitigate the issue by providing a hardcode pre-defined table. > > > > The broken discovery table can trigger a kernel warning message, which > > is overkilled. The patch series also refine the error handling code. > > > > Kan Liang (5): > > perf/x86/uncore: Factor out uncore_device_to_die() > > perf/x86/uncore: Fix potential NULL pointer in uncore_get_alias_name > > perf/x86/uncore: Ignore broken units in discovery table > > perf/x86/uncore: Add a quirk for UPI on SPR > > perf/x86/uncore: Don't WARN_ON_ONCE() for a broken discovery table > > > > arch/x86/events/intel/uncore.c | 34 ++++- > > arch/x86/events/intel/uncore.h | 4 + > > arch/x86/events/intel/uncore_discovery.c | 60 ++++++--- > > arch/x86/events/intel/uncore_discovery.h | 14 +- > > arch/x86/events/intel/uncore_snbep.c | 158 ++++++++++++++++++----- > > 5 files changed, 210 insertions(+), 60 deletions(-) > > > >
On Thu, 19 Jan 2023, Liang, Kan wrote: > Hi Peter & Ingo, > > Gentle Ping. Please let me know if you have any comments on the patch set. > > Thanks > Kan > > On 2023-01-12 3:01 p.m., kan.liang@linux.intel.com wrote: > > From: Kan Liang <kan.liang@linux.intel.com> > > > > The discovery table of UPI on SPR MCC is broken. The patch series is > > to mitigate the issue by providing a hardcode pre-defined table. > > > > The broken discovery table can trigger a kernel warning message, which > > is overkilled. The patch series also refine the error handling code. > > > > Kan Liang (5): > > perf/x86/uncore: Factor out uncore_device_to_die() > > perf/x86/uncore: Fix potential NULL pointer in uncore_get_alias_name > > perf/x86/uncore: Ignore broken units in discovery table > > perf/x86/uncore: Add a quirk for UPI on SPR > > perf/x86/uncore: Don't WARN_ON_ONCE() for a broken discovery table For the series, Tested-by: Michael Petlan <mpetlan@redhat.com> > > > > arch/x86/events/intel/uncore.c | 34 ++++- > > arch/x86/events/intel/uncore.h | 4 + > > arch/x86/events/intel/uncore_discovery.c | 60 ++++++--- > > arch/x86/events/intel/uncore_discovery.h | 14 +- > > arch/x86/events/intel/uncore_snbep.c | 158 ++++++++++++++++++----- > > 5 files changed, 210 insertions(+), 60 deletions(-) > > > >
I reviewed this patch series, applied it to a kernel tree, and tested it on two larger (12+ socket) systems, did not notice any adverse affects. So I believe it's appropriate to add both of these tags: Tested-by: Steve Wahl <steve.wahl@hpe.com> Reviewed-by: Steve Wahl <steve.wahl@hpe.com> --> Steve On Thu, Jan 12, 2023 at 12:01:00PM -0800, kan.liang@linux.intel.com wrote: > From: Kan Liang <kan.liang@linux.intel.com> > > The discovery table of UPI on SPR MCC is broken. The patch series is > to mitigate the issue by providing a hardcode pre-defined table. > > The broken discovery table can trigger a kernel warning message, which > is overkilled. The patch series also refine the error handling code. > > Kan Liang (5): > perf/x86/uncore: Factor out uncore_device_to_die() > perf/x86/uncore: Fix potential NULL pointer in uncore_get_alias_name > perf/x86/uncore: Ignore broken units in discovery table > perf/x86/uncore: Add a quirk for UPI on SPR > perf/x86/uncore: Don't WARN_ON_ONCE() for a broken discovery table > > arch/x86/events/intel/uncore.c | 34 ++++- > arch/x86/events/intel/uncore.h | 4 + > arch/x86/events/intel/uncore_discovery.c | 60 ++++++--- > arch/x86/events/intel/uncore_discovery.h | 14 +- > arch/x86/events/intel/uncore_snbep.c | 158 ++++++++++++++++++----- > 5 files changed, 210 insertions(+), 60 deletions(-) > > -- > 2.35.1 > -- Steve Wahl, Hewlett Packard Enterprise
© 2016 - 2025 Red Hat, Inc.