[PATCH net-next 0/5] Add PPS support to am65-cpts driver

Siddharth Vadapalli posted 5 patches 2 years, 8 months ago
There is a newer version of this series
.../bindings/net/ti,k3-am654-cpts.yaml        |   8 +
arch/arm64/boot/dts/ti/k3-am62-main.dtsi      |   9 ++
arch/arm64/boot/dts/ti/k3-am625-sk.dts        |  20 +++
drivers/net/ethernet/ti/am65-cpts.c           | 144 ++++++++++++++++--
4 files changed, 166 insertions(+), 15 deletions(-)
[PATCH net-next 0/5] Add PPS support to am65-cpts driver
Posted by Siddharth Vadapalli 2 years, 8 months ago
The CPTS hardware doesn't support PPS signal generation. Using the GenFx
(periodic signal generator) function, it is possible to model a PPS signal
followed by routing it via the time sync router to the CPTS_HWy_TS_PUSH
(hardware time stamp) input, in order to generate timestamps at 1 second
intervals.

This series adds driver support for enabling PPS signal generation.
Additionally, the documentation for the am65-cpts driver is updated with
the bindings for the "ti,pps" property, which is used to inform the
pair [CPTS_HWy_TS_PUSH, GenFx] to the cpts driver. The PPS example is
enabled for AM625-SK board by default, by adding the timesync_router node
to the AM62x SoC, and configuring it for PPS in the AM625-SK board dts.

Grygorii Strashko (3):
  dt-binding: net: ti: am65x-cpts: add 'ti,pps' property
  net: ethernet: ti: am65-cpts: add pps support
  net: ethernet: ti: am65-cpts: adjust pps following ptp changes

Siddharth Vadapalli (2):
  arm64: dts: ti: k3-am62-main: Add timesync router node
  arm64: dts: ti: k3-am625-sk: Add cpsw3g cpts PPS support

 .../bindings/net/ti,k3-am654-cpts.yaml        |   8 +
 arch/arm64/boot/dts/ti/k3-am62-main.dtsi      |   9 ++
 arch/arm64/boot/dts/ti/k3-am625-sk.dts        |  20 +++
 drivers/net/ethernet/ti/am65-cpts.c           | 144 ++++++++++++++++--
 4 files changed, 166 insertions(+), 15 deletions(-)

-- 
2.25.1
Re: [PATCH net-next 0/5] Add PPS support to am65-cpts driver
Posted by Roger Quadros 2 years, 8 months ago
Siddharth,

On 11/01/2023 13:44, Siddharth Vadapalli wrote:
> The CPTS hardware doesn't support PPS signal generation. Using the GenFx
> (periodic signal generator) function, it is possible to model a PPS signal
> followed by routing it via the time sync router to the CPTS_HWy_TS_PUSH
> (hardware time stamp) input, in order to generate timestamps at 1 second
> intervals.
> 
> This series adds driver support for enabling PPS signal generation.
> Additionally, the documentation for the am65-cpts driver is updated with
> the bindings for the "ti,pps" property, which is used to inform the
> pair [CPTS_HWy_TS_PUSH, GenFx] to the cpts driver. The PPS example is
> enabled for AM625-SK board by default, by adding the timesync_router node
> to the AM62x SoC, and configuring it for PPS in the AM625-SK board dts.
> 
> Grygorii Strashko (3):
>   dt-binding: net: ti: am65x-cpts: add 'ti,pps' property
>   net: ethernet: ti: am65-cpts: add pps support
>   net: ethernet: ti: am65-cpts: adjust pps following ptp changes
> 
> Siddharth Vadapalli (2):
>   arm64: dts: ti: k3-am62-main: Add timesync router node
>   arm64: dts: ti: k3-am625-sk: Add cpsw3g cpts PPS support

Device tree patches need to be sent separately. You don't need to involve
net maintainers for that.

If you introduce a new binding then that needs to be in maintainer's
tree before you can send a related device tree patch.

> 
>  .../bindings/net/ti,k3-am654-cpts.yaml        |   8 +
>  arch/arm64/boot/dts/ti/k3-am62-main.dtsi      |   9 ++
>  arch/arm64/boot/dts/ti/k3-am625-sk.dts        |  20 +++
>  drivers/net/ethernet/ti/am65-cpts.c           | 144 ++++++++++++++++--
>  4 files changed, 166 insertions(+), 15 deletions(-)
> 

cheers,
-roger
Re: [PATCH net-next 0/5] Add PPS support to am65-cpts driver
Posted by Siddharth Vadapalli 2 years, 8 months ago
Hello Roger,

On 13/01/23 15:18, Roger Quadros wrote:
> Siddharth,
> 
> On 11/01/2023 13:44, Siddharth Vadapalli wrote:
>> The CPTS hardware doesn't support PPS signal generation. Using the GenFx
>> (periodic signal generator) function, it is possible to model a PPS signal
>> followed by routing it via the time sync router to the CPTS_HWy_TS_PUSH
>> (hardware time stamp) input, in order to generate timestamps at 1 second
>> intervals.
>>
>> This series adds driver support for enabling PPS signal generation.
>> Additionally, the documentation for the am65-cpts driver is updated with
>> the bindings for the "ti,pps" property, which is used to inform the
>> pair [CPTS_HWy_TS_PUSH, GenFx] to the cpts driver. The PPS example is
>> enabled for AM625-SK board by default, by adding the timesync_router node
>> to the AM62x SoC, and configuring it for PPS in the AM625-SK board dts.
>>
>> Grygorii Strashko (3):
>>   dt-binding: net: ti: am65x-cpts: add 'ti,pps' property
>>   net: ethernet: ti: am65-cpts: add pps support
>>   net: ethernet: ti: am65-cpts: adjust pps following ptp changes
>>
>> Siddharth Vadapalli (2):
>>   arm64: dts: ti: k3-am62-main: Add timesync router node
>>   arm64: dts: ti: k3-am625-sk: Add cpsw3g cpts PPS support
> 
> Device tree patches need to be sent separately. You don't need to involve
> net maintainers for that.
> 
> If you introduce a new binding then that needs to be in maintainer's
> tree before you can send a related device tree patch.

Thank you for letting me know. Would I need to resend the series in order for it
to be reviewed? I was hoping that if I get feedback for this series, I will
implement it and post just the bindings and driver patches as the v2 series,
dropping the device tree patches. Please let me know.

Regards,
Siddharth.
Re: [PATCH net-next 0/5] Add PPS support to am65-cpts driver
Posted by Roger Quadros 2 years, 8 months ago

On 13/01/2023 11:56, Siddharth Vadapalli wrote:
> Hello Roger,
> 
> On 13/01/23 15:18, Roger Quadros wrote:
>> Siddharth,
>>
>> On 11/01/2023 13:44, Siddharth Vadapalli wrote:
>>> The CPTS hardware doesn't support PPS signal generation. Using the GenFx
>>> (periodic signal generator) function, it is possible to model a PPS signal
>>> followed by routing it via the time sync router to the CPTS_HWy_TS_PUSH
>>> (hardware time stamp) input, in order to generate timestamps at 1 second
>>> intervals.
>>>
>>> This series adds driver support for enabling PPS signal generation.
>>> Additionally, the documentation for the am65-cpts driver is updated with
>>> the bindings for the "ti,pps" property, which is used to inform the
>>> pair [CPTS_HWy_TS_PUSH, GenFx] to the cpts driver. The PPS example is
>>> enabled for AM625-SK board by default, by adding the timesync_router node
>>> to the AM62x SoC, and configuring it for PPS in the AM625-SK board dts.
>>>
>>> Grygorii Strashko (3):
>>>   dt-binding: net: ti: am65x-cpts: add 'ti,pps' property
>>>   net: ethernet: ti: am65-cpts: add pps support
>>>   net: ethernet: ti: am65-cpts: adjust pps following ptp changes
>>>
>>> Siddharth Vadapalli (2):
>>>   arm64: dts: ti: k3-am62-main: Add timesync router node
>>>   arm64: dts: ti: k3-am625-sk: Add cpsw3g cpts PPS support
>>
>> Device tree patches need to be sent separately. You don't need to involve
>> net maintainers for that.
>>
>> If you introduce a new binding then that needs to be in maintainer's
>> tree before you can send a related device tree patch.
> 
> Thank you for letting me know. Would I need to resend the series in order for it
> to be reviewed? I was hoping that if I get feedback for this series, I will
> implement it and post just the bindings and driver patches as the v2 series,
> dropping the device tree patches. Please let me know.

You could wait a couple of days for more comments here before spinning off a v2 ;)

cheers,
-roger