mm/slab.c: Delete the if statement

[PATCH V2] mm/slab.c: Delete the if statement

Posted by lvqian@nfschina.com 2 years, 8 months ago

From: lvqian <lvqian@nfschina.com>

	Remove the if statement to increase code readability.

Signed-off-by: lvqian <lvqian@nfschina.com>
---
 v2: Modify the subject content
---
 mm/slab.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/mm/slab.c b/mm/slab.c
index 7a269db050ee..713265fe2dea 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -1415,11 +1415,8 @@ static void kmem_rcu_free(struct rcu_head *head)
 #if DEBUG
 static bool is_debug_pagealloc_cache(struct kmem_cache *cachep)
 {
-	if (debug_pagealloc_enabled_static() && OFF_SLAB(cachep) &&
-		(cachep->size % PAGE_SIZE) == 0)
-		return true;
-
-	return false;
+	return debug_pagealloc_enabled_static() && OFF_SLAB(cachep) &&
+			((cachep->size % PAGE_SIZE) == 0);
 }
 
 #ifdef CONFIG_DEBUG_PAGEALLOC
-- 
2.34.1

Re: [PATCH V2] mm/slab.c: Delete the if statement

Posted by David Rientjes 2 years, 8 months ago

On Wed, 11 Jan 2023, lvqian@nfschina.com wrote:

> From: lvqian <lvqian@nfschina.com>
> 
> 	Remove the if statement to increase code readability.
> 
> Signed-off-by: lvqian <lvqian@nfschina.com>

Acked-by: David Rientjes <rientjes@google.com>

Will rely on Vlastimil to remove the spurious tab in the commit 
description.  Function could be inline, but no strong preference.

Re: [PATCH V2] mm/slab.c: Delete the if statement

Posted by Vlastimil Babka 2 years, 8 months ago

On 1/13/23 00:53, David Rientjes wrote:
> On Wed, 11 Jan 2023, lvqian@nfschina.com wrote:
> 
>> From: lvqian <lvqian@nfschina.com>
>> 
>> 	Remove the if statement to increase code readability.
>> 
>> Signed-off-by: lvqian <lvqian@nfschina.com>
> 
> Acked-by: David Rientjes <rientjes@google.com>
> 
> Will rely on Vlastimil to remove the spurious tab in the commit 
> description.

Right, also changed subject to:
mm/slab.c: cleanup is_debug_pagealloc_cache()

Function could be inline, but no strong preference.

Good point, did that too.

Added to
slab/for-6.3/cleanups

Thanks.