[PATCH v1 1/3] arm64: dts: rockchip: Update sdhci alias for rock-5a

Christopher Obbard posted 3 patches 2 years, 8 months ago
There is a newer version of this series
[PATCH v1 1/3] arm64: dts: rockchip: Update sdhci alias for rock-5a
Posted by Christopher Obbard 2 years, 8 months ago
In the previous version, the sdhci alias was set
to mmc1: an artifact leftover from the port from
vendor kernel. Update the alias to mmc0 to match
the device's boot order.

Fixes: a4a8f1afb360 ("arm64: dts: rockchip: Add rock-5a board")
Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
---
 arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
index 409a43d059d8..c85af1334c05 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
@@ -11,7 +11,7 @@ / {
 	compatible = "radxa,rock-5a", "rockchip,rk3588s";
 
 	aliases {
-		mmc1 = &sdhci;
+		mmc0 = &sdhci;
 		serial2 = &uart2;
 	};
 
-- 
2.39.0
Re: [PATCH v1 1/3] arm64: dts: rockchip: Update sdhci alias for rock-5a
Posted by Krzysztof Kozlowski 2 years, 8 months ago
On 10/01/2023 16:52, Christopher Obbard wrote:
> In the previous version, the sdhci alias was set
> to mmc1: an artifact leftover from the port from
> vendor kernel. Update the alias to mmc0 to match

Please wrap
commit
message
according
to
Linux
coding style / submission process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586


Best regards,
Krzysztof
Re: [PATCH v1 1/3] arm64: dts: rockchip: Update sdhci alias for rock-5a
Posted by Christopher Obbard 2 years, 8 months ago
On Tue, 2023-01-10 at 20:21 +0100, Krzysztof Kozlowski wrote:
> On 10/01/2023 16:52, Christopher Obbard wrote:
> > In the previous version, the sdhci alias was set
> > to mmc1: an artifact leftover from the port from
> > vendor kernel. Update the alias to mmc0 to match
> 
> Please wrap
> commit
> message
> according
> to
> Linux
> coding style / submission process (neither too early nor over the
> limit):
> https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586

thanks
for
the
hint - I sent V2 and will hopefully make less awful Haikus in future ;-
)