[v2] staging: r8188eu: some more xmit cleanups

[PATCH v2 00/12] staging: r8188eu: some more xmit cleanups

Posted by Martin Kaiser 2 years, 8 months ago

Here's another set of xmit cleanups, based on my previous patches.

changes in v2:
- drop "make rtl8188eu_inirp_init a void function" patch
  (we should relay the return value instead of discarding it)

Martin Kaiser (12):
  staging: r8188eu: beq_cnt is write-only
  staging: r8188eu: bkq_cnt is write-only
  staging: r8188eu: viq_cnt is write-only
  staging: r8188eu: voq_cnt is write-only
  staging: r8188eu: replace switch with if
  staging: r8188eu: dir_dev is unused
  staging: r8188eu: remove unused hal_xmit_handler define
  staging: r8188eu: txirp_cnt is write-only
  staging: r8188eu: remove unused QSLT defines
  staging: r8188eu: xmit_priv's vcs_type is not used
  staging: r8188eu: xmit_priv's vcs is not used
  staging: r8188eu: xmit_priv's vcs_setting is not used

 drivers/staging/r8188eu/core/rtw_mlme.c       |  5 ---
 drivers/staging/r8188eu/core/rtw_xmit.c       | 42 -------------------
 drivers/staging/r8188eu/include/drv_types.h   |  1 -
 .../staging/r8188eu/include/rtl8188e_xmit.h   | 11 -----
 drivers/staging/r8188eu/include/rtw_xmit.h    | 10 -----
 drivers/staging/r8188eu/os_dep/os_intfs.c     |  3 --
 .../staging/r8188eu/os_dep/usb_ops_linux.c    | 23 +---------
 7 files changed, 1 insertion(+), 94 deletions(-)

-- 
2.30.2

Re: [PATCH v2 00/12] staging: r8188eu: some more xmit cleanups

Posted by Philipp Hortmann 2 years, 8 months ago

On 1/9/23 22:28, Martin Kaiser wrote:
> Here's another set of xmit cleanups, based on my previous patches.
> 
> changes in v2:
> - drop "make rtl8188eu_inirp_init a void function" patch
>    (we should relay the return value instead of discarding it)
> 
> Martin Kaiser (12):
>    staging: r8188eu: beq_cnt is write-only
>    staging: r8188eu: bkq_cnt is write-only
>    staging: r8188eu: viq_cnt is write-only
>    staging: r8188eu: voq_cnt is write-only
>    staging: r8188eu: replace switch with if
>    staging: r8188eu: dir_dev is unused
>    staging: r8188eu: remove unused hal_xmit_handler define
>    staging: r8188eu: txirp_cnt is write-only
>    staging: r8188eu: remove unused QSLT defines
>    staging: r8188eu: xmit_priv's vcs_type is not used
>    staging: r8188eu: xmit_priv's vcs is not used
>    staging: r8188eu: xmit_priv's vcs_setting is not used
> 
>   drivers/staging/r8188eu/core/rtw_mlme.c       |  5 ---
>   drivers/staging/r8188eu/core/rtw_xmit.c       | 42 -------------------
>   drivers/staging/r8188eu/include/drv_types.h   |  1 -
>   .../staging/r8188eu/include/rtl8188e_xmit.h   | 11 -----
>   drivers/staging/r8188eu/include/rtw_xmit.h    | 10 -----
>   drivers/staging/r8188eu/os_dep/os_intfs.c     |  3 --
>   .../staging/r8188eu/os_dep/usb_ops_linux.c    | 23 +---------
>   7 files changed, 1 insertion(+), 94 deletions(-)
> 

When applying first the 4 patch series and then the 20 patch series this 
series is working.

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150

Re: [PATCH v2 00/12] staging: r8188eu: some more xmit cleanups

Posted by Pavel Skripkin 2 years, 8 months ago

Hi Martin,

Martin Kaiser <martin@kaiser.cx> says:
> Here's another set of xmit cleanups, based on my previous patches.
> 
> changes in v2:
> - drop "make rtl8188eu_inirp_init a void function" patch
>    (we should relay the return value instead of discarding it)
> 
> Martin Kaiser (12):
>    staging: r8188eu: beq_cnt is write-only
>    staging: r8188eu: bkq_cnt is write-only
>    staging: r8188eu: viq_cnt is write-only
>    staging: r8188eu: voq_cnt is write-only
>    staging: r8188eu: replace switch with if
>    staging: r8188eu: dir_dev is unused
>    staging: r8188eu: remove unused hal_xmit_handler define
>    staging: r8188eu: txirp_cnt is write-only
>    staging: r8188eu: remove unused QSLT defines
>    staging: r8188eu: xmit_priv's vcs_type is not used
>    staging: r8188eu: xmit_priv's vcs is not used
>    staging: r8188eu: xmit_priv's vcs_setting is not used
> 
>   drivers/staging/r8188eu/core/rtw_mlme.c       |  5 ---
>   drivers/staging/r8188eu/core/rtw_xmit.c       | 42 -------------------
>   drivers/staging/r8188eu/include/drv_types.h   |  1 -
>   .../staging/r8188eu/include/rtl8188e_xmit.h   | 11 -----
>   drivers/staging/r8188eu/include/rtw_xmit.h    | 10 -----
>   drivers/staging/r8188eu/os_dep/os_intfs.c     |  3 --
>   .../staging/r8188eu/os_dep/usb_ops_linux.c    | 23 +---------
>   7 files changed, 1 insertion(+), 94 deletions(-)
> 

Acked-by: Pavel Skripkin <paskripkin@gmail.com>

Thanks for the update!



With regards,
Pavel Skripkin