[PATCH] nommu: Fix do_munmap() error path

Liam Howlett posted 1 patch 2 years, 8 months ago
There is a newer version of this series
mm/nommu.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[PATCH] nommu: Fix do_munmap() error path
Posted by Liam Howlett 2 years, 8 months ago
When removing a VMA from the tree fails due to no memory, do not free
the VMA since a reference still exists.

Fixes: 8220543df148 ("nommu: remove uses of VMA linked list")
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
 mm/nommu.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mm/nommu.c b/mm/nommu.c
index c8252f01d5db..844af5be7640 100644
--- a/mm/nommu.c
+++ b/mm/nommu.c
@@ -1509,7 +1509,8 @@ int do_munmap(struct mm_struct *mm, unsigned long start, size_t len, struct list
 erase_whole_vma:
 	if (delete_vma_from_mm(vma))
 		ret = -ENOMEM;
-	delete_vma(mm, vma);
+	else
+		delete_vma(mm, vma);
 	return ret;
 }
 
-- 
2.35.1