add folio_headpage() macro

[PATCH 3/3] fs/ceph/addr: use folio_headpage() instead of folio_page()

Posted by SeongJae Park 2 years, 8 months ago

Using 'folio_page(folio, 0)' for getting the head page of a folios is
not the standard idiom and inefficient.  Replace the call in fs/ceph/ to
'folio_headpage()'.

Signed-off-by: SeongJae Park <sj@kernel.org>
---
 fs/ceph/addr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
index 8c74871e37c9..b76e94152b21 100644
--- a/fs/ceph/addr.c
+++ b/fs/ceph/addr.c
@@ -1290,7 +1290,7 @@ static int ceph_netfs_check_write_begin(struct file *file, loff_t pos, unsigned
 	struct ceph_inode_info *ci = ceph_inode(inode);
 	struct ceph_snap_context *snapc;
 
-	snapc = ceph_find_incompatible(folio_page(*foliop, 0));
+	snapc = ceph_find_incompatible(folio_headpage(*foliop));
 	if (snapc) {
 		int r;
 
-- 
2.25.1

Re: [PATCH 3/3] fs/ceph/addr: use folio_headpage() instead of folio_page()

Posted by Matthew Wilcox 2 years, 8 months ago

On Fri, Jan 06, 2023 at 05:40:28PM +0000, SeongJae Park wrote:
> -	snapc = ceph_find_incompatible(folio_page(*foliop, 0));
> +	snapc = ceph_find_incompatible(folio_headpage(*foliop));

ceph_find_incompatible() should take a folio.

[PATCH 1/3] include/linux/page-flags: add folio_headpage()
[PATCH 2/3] mm: use folio_headpage() instead of folio_page()
[PATCH 3/3] fs/ceph/addr: use folio_headpage() instead of folio_page()