[v1] Add support for Samsung Galaxy tab A (2015) tablets

[PATCH 3/8] arm64: dts: qcom: msm8916-samsung-gt58: Add Vibrator

Posted by Nikita Travkin 2 years, 8 months ago

From: Siddharth Manthan <siddharth.manthan@gmail.com>

Motor is powered by VPH_PWR (aka Vbat) and controlled by GPIO.

Signed-off-by: Siddharth Manthan <siddharth.manthan@gmail.com>
Signed-off-by: Nikita Travkin <nikita@trvn.ru>
---
 .../boot/dts/qcom/msm8916-samsung-gt58.dts     | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-gt58.dts b/arch/arm64/boot/dts/qcom/msm8916-samsung-gt58.dts
index 688e9be590ba..37140d041a22 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-samsung-gt58.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-gt58.dts
@@ -8,4 +8,22 @@ / {
 	model = "Samsung Galaxy Tab A 8.0 (2015)";
 	compatible = "samsung,gt58", "qcom,msm8916";
 	chassis-type = "tablet";
+
+	vibrator {
+		compatible = "gpio-vibrator";
+		enable-gpios = <&msmgpio 76 GPIO_ACTIVE_HIGH>;
+
+		pinctrl-0 = <&vibrator_en_default>;
+		pinctrl-names = "default";
+	};
+};
+
+&msmgpio {
+	vibrator_en_default: vibrator-en-default-state {
+		pins = "gpio76";
+		function = "gpio";
+
+		drive-strength = <2>;
+		bias-disable;
+	};
 };
-- 
2.38.1

Re: [PATCH 3/8] arm64: dts: qcom: msm8916-samsung-gt58: Add Vibrator

Posted by Krzysztof Kozlowski 2 years, 8 months ago

On 05/01/2023 13:32, Nikita Travkin wrote:
> From: Siddharth Manthan <siddharth.manthan@gmail.com>
> 
> Motor is powered by VPH_PWR (aka Vbat) and controlled by GPIO.
> 
> Signed-off-by: Siddharth Manthan <siddharth.manthan@gmail.com>
> Signed-off-by: Nikita Travkin <nikita@trvn.ru>
> ---
>  .../boot/dts/qcom/msm8916-samsung-gt58.dts     | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 

You just added this file in previous patch, so this should be squashed.
Patches should be organized logically and logical change is "new board XYZ".

Best regards,
Krzysztof