ALSA: hda/realtek: fix mute/micmute LEDs don't work for a HP platform

[PATCH] ALSA: hda/realtek: fix mute/micmute LEDs don't work for a HP platform

Posted by Jeremy Szu 2 years, 8 months ago

There is a HP platform uses ALC236 codec which using GPIO2 to control
mute LED and GPIO1 to control micmute LED.
Thus, add a quirk to make them work.

Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index eda4914b8aeb..8362eb4642d8 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9409,6 +9409,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8b5d, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
 	SND_PCI_QUIRK(0x103c, 0x8b5e, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
+	SND_PCI_QUIRK(0x103c, 0x8bf0, "HP", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC),
 	SND_PCI_QUIRK(0x1043, 0x103f, "ASUS TX300", ALC282_FIXUP_ASUS_TX300),
 	SND_PCI_QUIRK(0x1043, 0x106d, "Asus K53BE", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
-- 
2.38.1

Re: [PATCH] ALSA: hda/realtek: fix mute/micmute LEDs don't work for a HP platform

Posted by Takashi Iwai 2 years, 8 months ago

On Thu, 05 Jan 2023 05:41:53 +0100,
Jeremy Szu wrote:
> 
> There is a HP platform uses ALC236 codec which using GPIO2 to control
> mute LED and GPIO1 to control micmute LED.
> Thus, add a quirk to make them work.
> 
> Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>

Thanks, applied now.


Takashi

Re: [PATCH] ALSA: hda/realtek: fix mute/micmute LEDs don't work for a HP platform

Posted by Jeremy Szu 2 years, 8 months ago

Besides this, it has the problem described in
https://lore.kernel.org/all/20220719144753.252231-1-kai.heng.feng@canonical.com/
but the solution could seperate with this quirk.

On Thu, Jan 5, 2023 at 12:42 PM Jeremy Szu <jeremy.szu@canonical.com> wrote:
>
> There is a HP platform uses ALC236 codec which using GPIO2 to control
> mute LED and GPIO1 to control micmute LED.
> Thus, add a quirk to make them work.
>
> Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index eda4914b8aeb..8362eb4642d8 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9409,6 +9409,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>         SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
>         SND_PCI_QUIRK(0x103c, 0x8b5d, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
>         SND_PCI_QUIRK(0x103c, 0x8b5e, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> +       SND_PCI_QUIRK(0x103c, 0x8bf0, "HP", ALC236_FIXUP_HP_GPIO_LED),
>         SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC),
>         SND_PCI_QUIRK(0x1043, 0x103f, "ASUS TX300", ALC282_FIXUP_ASUS_TX300),
>         SND_PCI_QUIRK(0x1043, 0x106d, "Asus K53BE", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
> --
> 2.38.1
>


-- 
Sincerely,
Jeremy Su