drivers: iio: cdc: Drop redundant if check

[PATCH] drivers: iio: cdc: Drop redundant if check

Posted by Alexander Vorwerk 2 years, 8 months ago

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Alexander Vorwerk <zabe@avorwerk.net>
---
 drivers/iio/cdc/ad7746.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iio/cdc/ad7746.c b/drivers/iio/cdc/ad7746.c
index 6f68651ce1d5..a1db5469f2d1 100644
--- a/drivers/iio/cdc/ad7746.c
+++ b/drivers/iio/cdc/ad7746.c
@@ -285,8 +285,7 @@ static int ad7746_select_channel(struct iio_dev *indio_dev,
 		if (ret < 0)
 			return ret;
 
-		if (chip->capdac_set != chan->channel)
-			chip->capdac_set = chan->channel;
+		chip->capdac_set = chan->channel;
 		break;
 	case IIO_VOLTAGE:
 	case IIO_TEMP:
-- 
2.17.1

Re: [PATCH] drivers: iio: cdc: Drop redundant if check

Posted by Jonathan Cameron 2 years, 8 months ago

On Thu,  5 Jan 2023 03:53:51 +0100
Alexander Vorwerk <zabe@avorwerk.net> wrote:

> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Alexander Vorwerk <zabe@avorwerk.net>
Applied to the togreg branch of iio.git.

Thanks,

Jonathan

> ---
>  drivers/iio/cdc/ad7746.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/cdc/ad7746.c b/drivers/iio/cdc/ad7746.c
> index 6f68651ce1d5..a1db5469f2d1 100644
> --- a/drivers/iio/cdc/ad7746.c
> +++ b/drivers/iio/cdc/ad7746.c
> @@ -285,8 +285,7 @@ static int ad7746_select_channel(struct iio_dev *indio_dev,
>  		if (ret < 0)
>  			return ret;
>  
> -		if (chip->capdac_set != chan->channel)
> -			chip->capdac_set = chan->channel;
> +		chip->capdac_set = chan->channel;
>  		break;
>  	case IIO_VOLTAGE:
>  	case IIO_TEMP: