[PATCH rcu 21/27] fs/quota: Remove "select SRCU"

Paul E. McKenney posted 27 patches 2 years, 8 months ago
There is a newer version of this series
[PATCH rcu 21/27] fs/quota: Remove "select SRCU"
Posted by Paul E. McKenney 2 years, 8 months ago
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it.  Therefore, remove the "select SRCU"
Kconfig statements.

Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Jan Kara <jack@suse.com>
---
 fs/quota/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/quota/Kconfig b/fs/quota/Kconfig
index b59cd172b5f97..d5a85a8062d05 100644
--- a/fs/quota/Kconfig
+++ b/fs/quota/Kconfig
@@ -6,7 +6,6 @@
 config QUOTA
 	bool "Quota support"
 	select QUOTACTL
-	select SRCU
 	help
 	  If you say Y here, you will be able to set per user limits for disk
 	  usage (also called disk quotas). Currently, it works for the
-- 
2.31.1.189.g2e36527f23
Re: [PATCH rcu 21/27] fs/quota: Remove "select SRCU"
Posted by Jan Kara 2 years, 8 months ago
On Wed 04-01-23 16:38:07, Paul E. McKenney wrote:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it.  Therefore, remove the "select SRCU"
> Kconfig statements.
> 
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: Jan Kara <jack@suse.com>
> ---
>  fs/quota/Kconfig | 1 -
>  1 file changed, 1 deletion(-)

Sure. You can add:

Acked-by: Jan Kara <jack@suse.cz>

								Honza

> 
> diff --git a/fs/quota/Kconfig b/fs/quota/Kconfig
> index b59cd172b5f97..d5a85a8062d05 100644
> --- a/fs/quota/Kconfig
> +++ b/fs/quota/Kconfig
> @@ -6,7 +6,6 @@
>  config QUOTA
>  	bool "Quota support"
>  	select QUOTACTL
> -	select SRCU
>  	help
>  	  If you say Y here, you will be able to set per user limits for disk
>  	  usage (also called disk quotas). Currently, it works for the
> -- 
> 2.31.1.189.g2e36527f23
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR
Re: [PATCH rcu 21/27] fs/quota: Remove "select SRCU"
Posted by Paul E. McKenney 2 years, 8 months ago
On Thu, Jan 05, 2023 at 12:30:15PM +0100, Jan Kara wrote:
> On Wed 04-01-23 16:38:07, Paul E. McKenney wrote:
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it.  Therefore, remove the "select SRCU"
> > Kconfig statements.
> > 
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: Jan Kara <jack@suse.com>
> > ---
> >  fs/quota/Kconfig | 1 -
> >  1 file changed, 1 deletion(-)
> 
> Sure. You can add:
> 
> Acked-by: Jan Kara <jack@suse.cz>

Thank you, Jan!  I will apply both on my next rebase.

> 								Honza
> 
> > 
> > diff --git a/fs/quota/Kconfig b/fs/quota/Kconfig
> > index b59cd172b5f97..d5a85a8062d05 100644
> > --- a/fs/quota/Kconfig
> > +++ b/fs/quota/Kconfig
> > @@ -6,7 +6,6 @@
> >  config QUOTA
> >  	bool "Quota support"
> >  	select QUOTACTL
> > -	select SRCU
> >  	help
> >  	  If you say Y here, you will be able to set per user limits for disk
> >  	  usage (also called disk quotas). Currently, it works for the
> > -- 
> > 2.31.1.189.g2e36527f23
> > 
> -- 
> Jan Kara <jack@suse.com>
> SUSE Labs, CR