[v1] selftests/rseq: Revert "selftests/rseq: Add mm_numa_cid to test script"

[PATCH tip] selftests/rseq: Revert "selftests/rseq: Add mm_numa_cid to test script"

Posted by Mathieu Desnoyers 2 years, 8 months ago

The mm_numa_cid related rseq patches from the series were not picked up
into the tip tree, so enabling the mm_numa_cid test needs to be
reverted.

This reverts commit b344b8f2d88dbf095caf97ac57fd3645843fa70f.

Reported-by: kernel test robot <oliver.sang@intel.com>
Link: https://lore.kernel.org/oe-lkp/202301040903.2dd1e25b-oliver.sang@intel.com
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
---
 tools/testing/selftests/rseq/run_param_test.sh | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/tools/testing/selftests/rseq/run_param_test.sh b/tools/testing/selftests/rseq/run_param_test.sh
index 603b3b69d20c..8d31426ab41f 100755
--- a/tools/testing/selftests/rseq/run_param_test.sh
+++ b/tools/testing/selftests/rseq/run_param_test.sh
@@ -47,11 +47,6 @@ function do_tests()
 		./param_test_mm_cid ${TEST_LIST[$i]} -r ${REPS} -t ${NR_THREADS} ${@} ${EXTRA_ARGS} || exit 1
 		echo "Running mm_cid compare-twice test ${TEST_NAME[$i]}"
 		./param_test_mm_cid_compare_twice ${TEST_LIST[$i]} -r ${REPS} -t ${NR_THREADS} ${@} ${EXTRA_ARGS} || exit 1
-
-		echo "Running mm_numa_cid test ${TEST_NAME[$i]}"
-		./param_test_mm_numa_cid ${TEST_LIST[$i]} -r ${REPS} -t ${NR_THREADS} ${@} ${EXTRA_ARGS} || exit 1
-		echo "Running mm_numa_cid compare-twice test ${TEST_NAME[$i]}"
-		./param_test_mm_numa_cid_compare_twice ${TEST_LIST[$i]} -r ${REPS} -t ${NR_THREADS} ${@} ${EXTRA_ARGS} || exit 1
 		let "i++"
 	done
 }
-- 
2.25.1

Re: [PATCH tip] selftests/rseq: Revert "selftests/rseq: Add mm_numa_cid to test script"

Posted by Peter Zijlstra 2 years, 8 months ago

On Wed, Jan 04, 2023 at 11:35:42AM -0500, Mathieu Desnoyers wrote:
> The mm_numa_cid related rseq patches from the series were not picked up
> into the tip tree, so enabling the mm_numa_cid test needs to be
> reverted.
> 
> This reverts commit b344b8f2d88dbf095caf97ac57fd3645843fa70f.

Oh my bad, I got confused between the regular numa_id (which I did do
merge, right?) and the fancy numa_cid, which I indeed didn't merge yet.
I meant to give that a wee bit more thought, but that sadly hasn't
happened yet :/

Applied, thanks!

Re: [PATCH tip] selftests/rseq: Revert "selftests/rseq: Add mm_numa_cid to test script"

Posted by Mathieu Desnoyers 2 years, 8 months ago

On 2023-01-11 09:12, Peter Zijlstra wrote:
> On Wed, Jan 04, 2023 at 11:35:42AM -0500, Mathieu Desnoyers wrote:
>> The mm_numa_cid related rseq patches from the series were not picked up
>> into the tip tree, so enabling the mm_numa_cid test needs to be
>> reverted.
>>
>> This reverts commit b344b8f2d88dbf095caf97ac57fd3645843fa70f.
> 
> Oh my bad, I got confused between the regular numa_id (which I did do
> merge, right?) and the fancy numa_cid, which I indeed didn't merge yet.

Yes, that's indeed what happened.

> I meant to give that a wee bit more thought, but that sadly hasn't
> happened yet :/
> 
> Applied, thanks!

No worries, let me know when you have time to discuss the fancy numa_cid 
some more.

Thanks,

Mathieu


-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com